Reland "Make <menuitem> automatically be an interest invoker" [chromium/src : main]
0 views
Skip to first unread message
David Baron (Gerrit)
Jan 9, 2026, 12:18:46 PM (2 days ago) Jan 9
to Mason Freed, Chromium LUCI CQ, David Baron, AyeAye, Blink W3C Test Autoroller, Dominic Farolino, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org
Attention needed from Mason Freed
David Baron added 1 comment![]( "Open in Gerrit")
Commit Message
Line 9, Patchset 1 (Latest):
This is a reland of commit 106ba087eb332736a27034e848184551d8e144e4David Baron . unresolved
It doesn't look like there are any diffs from the original landing. Did you mean to request review at this point?
Related details
Attention is currently required from:
- Mason Freed
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mason Freed (Gerrit)
Jan 9, 2026, 12:33:36 PM (2 days ago) Jan 9
to Chromium LUCI CQ, David Baron, AyeAye, Blink W3C Test Autoroller, Dominic Farolino, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org
Attention needed from Mason Freed
Mason Freed added 1 comment![]( "Open in Gerrit")
Commit Message
Line 9, Patchset 1 (Latest):
This is a reland of commit 106ba087eb332736a27034e848184551d8e144e4David Baron . unresolved
It doesn't look like there are any diffs from the original landing. Did you mean to request review at this point?
Mason Freed
Nope, I hit "don't notify reviewers" but of course it does anyway. I'll ping again when this is ready. I haven't even looked at it yet, just created the reland to start. Sorry!
Mason Freed (Gerrit)
Jan 9, 2026, 2:30:57 PM (2 days ago) Jan 9
to Chromium LUCI CQ, David Baron, AyeAye, Blink W3C Test Autoroller, Dominic Farolino, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org
Attention needed from David Baron
Mason Freed voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mason Freed
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Mason Freed . resolved
Alright, ready for review. Patchset 1 vs. 3 shows the difference - in the tests only.
Related details
Attention is currently required from:
- David Baron
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Baron (Gerrit)
Jan 9, 2026, 2:37:44 PM (2 days ago) Jan 9
to Mason Freed, David Baron, Chromium LUCI CQ, AyeAye, Blink W3C Test Autoroller, Dominic Farolino, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org
David Baron voted and added 1 comment![]( "Open in Gerrit")
Votes added by David Baron
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Commit Message
Line 9, Patchset 1:
This is a reland of commit 106ba087eb332736a27034e848184551d8e144e4David Baron . resolved
Mason FreedIt doesn't look like there are any diffs from the original landing. Did you mean to request review at this point?
Nope, I hit "don't notify reviewers" but of course it does anyway. I'll ping again when this is ready. I haven't even looked at it yet, just created the reland to start. Sorry!
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Jan 9, 2026, 2:48:51 PM (2 days ago) Jan 9
to Mason Freed, David Baron, Chromium LUCI CQ, AyeAye, Dominic Farolino, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/57113.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 9, 2026, 4:04:52 PM (2 days ago) Jan 9
to Mason Freed, David Baron, AyeAye, Blink W3C Test Autoroller, Dominic Farolino, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Reland "Make <menuitem> automatically be an interest invoker"
This is a reland of commit 106ba087eb332736a27034e848184551d8e144e4
The problem was that the addition of interest invoker behavior
caused some tests (particularly ones that test focus navigation)
to flakily activate menus while traversing focus. Patchset 3+ fixes
that by explicitly setting the interest invoker delays accordingly.
Original change's description:
> Make <menuitem> automatically be an interest invoker
>
> If a menuitem is a submenu invoker, it automatically becomes
> an interest invoker, so that hovering it opens the submenu.
>
> Fixed: 422216068
> Bug: 406566432
> Change-Id: I93b844dea7b4c321cdb6b148bae8654e73c90038
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7276492
> Auto-Submit: Mason Freed <mas...@chromium.org>
> Commit-Queue: Mason Freed <mas...@chromium.org>
> Reviewed-by: David Baron <dba...@chromium.org>
> Commit-Queue: David Baron <dba...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1566675}
Bug: 406566432, 422216068
Change-Id: Icec74709640f48a0110b52a51a2570f21176d7b1
Auto-Submit: Mason Freed <mas...@chromium.org>
Commit-Queue: Mason Freed <mas...@chromium.org>
Reviewed-by: David Baron <dba...@chromium.org>
Commit-Queue: David Baron <dba...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1567165}
Files:
- M third_party/blink/renderer/core/dom/element.cc
- M third_party/blink/renderer/core/html/html_menu_item_element.cc
- M third_party/blink/renderer/core/html/html_menu_item_element.h
- M third_party/blink/web_tests/external/wpt/html/semantics/menu/tentative/focus-menu-elements-arrowoperations.html
- M third_party/blink/web_tests/external/wpt/html/semantics/menu/tentative/menuitem-activate.html
- M third_party/blink/web_tests/external/wpt/shadow-dom/focus-navigation/menu/tentative/focus-menu-elements.html
Change size: M
Delta: 6 files changed, 113 insertions(+), 76 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by David Baron
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Jan 9, 2026, 5:46:50 PM (2 days ago) Jan 9
to Mason Freed, Chromium LUCI CQ, David Baron, AyeAye, Dominic Farolino, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/57113
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages