[webaudio-testharness] Migrate audioworkletprocessor-param-getter [chromium/src : main]

0 views

Skip to first unread message

Michael Wilson (Gerrit)

unread,

Jan 9, 2026, 7:58:43 PM (2 days ago) Jan 9

to Muhammad Saqlain, Hongchan Choi, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Hongchan Choi and Muhammad Saqlain

Michael Wilson added 3 comments

File third_party/blink/web_tests/external/wpt/webaudio/the-audio-api/the-audioworklet-interface/audioworkletprocessor-param-getter-overridden.https.html

Line 21, Patchset 2 (Latest): const buffer = context.createBuffer(1, 2, context.sampleRate);

Michael Wilson . unresolved

Can we use the constructor here?

Line 25, Patchset 2 (Latest):

        source.buffer = buffer;
        source.loop = true;

Michael Wilson . unresolved

Nit: we could put these options in the constructor.

Line 45, Patchset 2 (Latest): new Float32Array(actual.length).fill(0),

Michael Wilson . unresolved

I don't think we need to use `fill(0)` here, since it should initialize as zero-filled.

Open in Gerrit

Related details

Attention is currently required from:

Hongchan Choi
Muhammad Saqlain

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages