Fix null deref in ApplyIterationAccumulation [chromium/src : main]

0 views
Skip to first unread message

Kevin Ellis (Gerrit)

unread,
Jan 9, 2026, 11:09:45 AM (2 days ago) Jan 9
to David Awogbemila, Felipe Erias, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from David Awogbemila

Kevin Ellis added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Kevin Ellis . resolved

Please take a look.

Open in Gerrit

Related details

Attention is currently required from:
  • David Awogbemila
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I86fad1fe41326c78bed290db0c35c56be364b64f
Gerrit-Change-Number: 7422843
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Ellis <kev...@chromium.org>
Gerrit-Reviewer: David Awogbemila <awogb...@chromium.org>
Gerrit-Reviewer: Kevin Ellis <kev...@chromium.org>
Gerrit-CC: Felipe Erias <felip...@igalia.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-Attention: David Awogbemila <awogb...@chromium.org>
Gerrit-Comment-Date: Fri, 09 Jan 2026 16:09:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

David Awogbemila (Gerrit)

unread,
Jan 9, 2026, 11:25:23 AM (2 days ago) Jan 9
to Kevin Ellis, Felipe Erias, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Kevin Ellis

David Awogbemila voted and added 1 comment

Votes added by David Awogbemila

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
David Awogbemila . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Kevin Ellis
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I86fad1fe41326c78bed290db0c35c56be364b64f
    Gerrit-Change-Number: 7422843
    Gerrit-PatchSet: 3
    Gerrit-Owner: Kevin Ellis <kev...@chromium.org>
    Gerrit-Reviewer: David Awogbemila <awogb...@chromium.org>
    Gerrit-Reviewer: Kevin Ellis <kev...@chromium.org>
    Gerrit-CC: Felipe Erias <felip...@igalia.com>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Attention: Kevin Ellis <kev...@chromium.org>
    Gerrit-Comment-Date: Fri, 09 Jan 2026 16:25:14 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Blink W3C Test Autoroller (Gerrit)

    unread,
    Jan 9, 2026, 11:29:46 AM (2 days ago) Jan 9
    to Kevin Ellis, David Awogbemila, Felipe Erias, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
    Attention needed from Kevin Ellis

    Message from Blink W3C Test Autoroller

    Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/57108.

    When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

    WPT Export docs:
    https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Kevin Ellis
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I86fad1fe41326c78bed290db0c35c56be364b64f
    Gerrit-Change-Number: 7422843
    Gerrit-PatchSet: 3
    Gerrit-Owner: Kevin Ellis <kev...@chromium.org>
    Gerrit-Reviewer: David Awogbemila <awogb...@chromium.org>
    Gerrit-Reviewer: Kevin Ellis <kev...@chromium.org>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    Gerrit-CC: Felipe Erias <felip...@igalia.com>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Attention: Kevin Ellis <kev...@chromium.org>
    Gerrit-Comment-Date: Fri, 09 Jan 2026 16:29:32 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy

    Kevin Ellis (Gerrit)

    unread,
    Jan 9, 2026, 12:32:33 PM (2 days ago) Jan 9
    to Blink W3C Test Autoroller, David Awogbemila, Felipe Erias, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

    Kevin Ellis voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I86fad1fe41326c78bed290db0c35c56be364b64f
    Gerrit-Change-Number: 7422843
    Gerrit-PatchSet: 3
    Gerrit-Owner: Kevin Ellis <kev...@chromium.org>
    Gerrit-Reviewer: David Awogbemila <awogb...@chromium.org>
    Gerrit-Reviewer: Kevin Ellis <kev...@chromium.org>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    Gerrit-CC: Felipe Erias <felip...@igalia.com>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Comment-Date: Fri, 09 Jan 2026 17:32:25 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 9, 2026, 1:10:46 PM (2 days ago) Jan 9
    to Kevin Ellis, Blink W3C Test Autoroller, David Awogbemila, Felipe Erias, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Fix null deref in ApplyIterationAccumulation

    Addresses 3 Clusterfuzz failures due to null dereferencing.
    Bug: 467450081, 467312393, 467312393
    Change-Id: I86fad1fe41326c78bed290db0c35c56be364b64f
    Commit-Queue: Kevin Ellis <kev...@chromium.org>
    Reviewed-by: David Awogbemila <awogb...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1567027}
    Files:
    • M third_party/blink/renderer/core/animation/invalidatable_interpolation.cc
    • A third_party/blink/web_tests/external/wpt/web-animations/crashtests/iteration-composite-unsupported-propery.html
    Change size: S
    Delta: 2 files changed, 29 insertions(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by David Awogbemila
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I86fad1fe41326c78bed290db0c35c56be364b64f
    Gerrit-Change-Number: 7422843
    Gerrit-PatchSet: 4
    Gerrit-Owner: Kevin Ellis <kev...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: David Awogbemila <awogb...@chromium.org>
    Gerrit-Reviewer: Kevin Ellis <kev...@chromium.org>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    open
    diffy
    satisfied_requirement

    Blink W3C Test Autoroller (Gerrit)

    unread,
    Jan 9, 2026, 2:28:45 PM (2 days ago) Jan 9
    to Kevin Ellis, Chromium LUCI CQ, David Awogbemila, Felipe Erias, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

    Message from Blink W3C Test Autoroller

    The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/57108

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I86fad1fe41326c78bed290db0c35c56be364b64f
    Gerrit-Change-Number: 7422843
    Gerrit-PatchSet: 4
    Gerrit-Owner: Kevin Ellis <kev...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: David Awogbemila <awogb...@chromium.org>
    Gerrit-Reviewer: Kevin Ellis <kev...@chromium.org>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    Gerrit-CC: Felipe Erias <felip...@igalia.com>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Comment-Date: Fri, 09 Jan 2026 19:28:37 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages