Add tests for maxAge being 0 [chromium/src : main]
0 views
Skip to first unread message
Anusha Muley (Gerrit)
Jan 8, 2026, 3:16:30 PM (3 days ago) Jan 8
to Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, storage...@chromium.org
Attention needed from Anusha Muley
Message from Anusha Muley![]( "Open in Gerrit")
Set Ready For Review
Related details
Attention is currently required from:
- Anusha Muley
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anusha Muley (Gerrit)
Jan 8, 2026, 3:20:45 PM (3 days ago) Jan 8
to Dylan Cutler, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, storage...@chromium.org
Attention needed from Dylan Cutler
Anusha Muley voted Commit-Queue+1![]( "Open in Gerrit")
Attention is currently required from:
- Dylan Cutler
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dylan Cutler (Gerrit)
Jan 9, 2026, 4:58:10 PM (2 days ago) Jan 9
to Anusha Muley, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, storage...@chromium.org
Attention needed from Anusha Muley
Dylan Cutler voted and added 2 comments![]( "Open in Gerrit")
Votes added by Dylan Cutler
| Code-Review | +1 |
2 comments
Patchset-level comments
File third_party/blink/web_tests/external/wpt/cookiestore/cookieStore_set_maxAge.https.any.js
Line 43, Patchset 6 (Latest):
'Duplicate cookie is not observed.');Dylan Cutler . unresolved
`Already expired cookie is not observed.`
Related details
Attention is currently required from:
- Anusha Muley
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anusha Muley (Gerrit)
Jan 9, 2026, 5:32:32 PM (2 days ago) Jan 9
to Dylan Cutler, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, storage...@chromium.org
Anusha Muley added 1 comment![]( "Open in Gerrit")
File third_party/blink/web_tests/external/wpt/cookiestore/cookieStore_set_maxAge.https.any.js
`Already expired cookie is not observed.`
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anusha Muley (Gerrit)
Jan 9, 2026, 5:32:50 PM (2 days ago) Jan 9
to Dylan Cutler, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, storage...@chromium.org
Anusha Muley voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Jan 9, 2026, 5:44:59 PM (2 days ago) Jan 9
to Anusha Muley, Dylan Cutler, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, storage...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/57119.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 9, 2026, 6:10:59 PM (2 days ago) Jan 9
to Anusha Muley, Blink W3C Test Autoroller, Dylan Cutler, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, storage...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
6 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: third_party/blink/web_tests/external/wpt/cookiestore/cookieStore_set_maxAge.https.any.js
Insertions: 1, Deletions: 1.
@@ -40,7 +40,7 @@
await cookieStore.set('alt-cookie', 'IGNORE');
await verifyCookieChangeEvent(
eventPromise, {changed: [{name: 'alt-cookie', value: 'IGNORE'}]},
- 'Duplicate cookie is not observed.');
+ 'Already expired cookie is not observed.');
}, 'cookieStore.set with maxAge set to zero, cookie change event not dispatched');
cookie_test(async testCase => {
```
Change information
Commit message:
Add tests for maxAge being 0
Makes sure cookie events are not created and cookies are not written if
the maxAge is set to zero.
Change-Id: I0ed4d77c300ed3cc01c07fce45c5cf2daad0ca7c
Bug: 430926231
Commit-Queue: Anusha Muley <anush...@google.com>
Reviewed-by: Dylan Cutler <dylan...@google.com>
Cr-Commit-Position: refs/heads/main@{#1567247}
Files:
- M third_party/blink/renderer/modules/cookie_store/cookie_store_unittest.cc
- M third_party/blink/web_tests/external/wpt/cookiestore/cookieStore_set_maxAge.https.any-expected.txt
- M third_party/blink/web_tests/external/wpt/cookiestore/cookieStore_set_maxAge.https.any.js
- M third_party/blink/web_tests/external/wpt/cookiestore/cookieStore_set_maxAge.https.any.serviceworker-expected.txt
Change size: M
Delta: 4 files changed, 51 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Dylan Cutler
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Jan 9, 2026, 7:52:26 PM (2 days ago) Jan 9
to Chromium LUCI CQ, Anusha Muley, Dylan Cutler, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, storage...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/57119
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages