Fix encoding of the suffix of CJK counter styles in UA style sheet [chromium/src : master]

Xiaocheng Hu (Gerrit)

unread,

Feb 4, 2021, 4:14:06 PM2/4/21

to Anders Hartvoll Ruud, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Attention is currently required from: Anders Hartvoll Ruud.

Xiaocheng Hu would like Anders Hartvoll Ruud to review this change.

View Change

Fix encoding of the suffix of CJK counter styles in UA style sheet

Many CJK counter styles use "、" (U+3001) as the suffix. This patch
properly escapes it in the UA style sheet to make the encoding correct.

As verification, this patch also adds ref files to the related WPT
tests. The new ref files are mechanically generated using the same
method as crrev.com/c/2674491

Bug: 687225
Change-Id: I4f29f17c290e21906601d8366a6a7db7d67b02a5
---
M third_party/blink/renderer/core/css/predefined_counter_styles.css
M third_party/blink/web_tests/TestExpectations
A third_party/blink/web_tests/external/wpt/css/css-counter-styles/hiragana-iroha/css3-counter-styles-033-ref.html
M third_party/blink/web_tests/external/wpt/css/css-counter-styles/hiragana-iroha/css3-counter-styles-033.html
A third_party/blink/web_tests/external/wpt/css/css-counter-styles/hiragana-iroha/css3-counter-styles-034-ref.html
M third_party/blink/web_tests/external/wpt/css/css-counter-styles/hiragana-iroha/css3-counter-styles-034.html
A third_party/blink/web_tests/external/wpt/css/css-counter-styles/hiragana-iroha/css3-counter-styles-035-ref.html
M third_party/blink/web_tests/external/wpt/css/css-counter-styles/hiragana-iroha/css3-counter-styles-035.html
A third_party/blink/web_tests/external/wpt/css/css-counter-styles/hiragana/css3-counter-styles-030-ref.html
M third_party/blink/web_tests/external/wpt/css/css-counter-styles/hiragana/css3-counter-styles-030.html
A third_party/blink/web_tests/external/wpt/css/css-counter-styles/hiragana/css3-counter-styles-031-ref.html
M third_party/blink/web_tests/external/wpt/css/css-counter-styles/hiragana/css3-counter-styles-031.html
A third_party/blink/web_tests/external/wpt/css/css-counter-styles/hiragana/css3-counter-styles-032-ref.html
M third_party/blink/web_tests/external/wpt/css/css-counter-styles/hiragana/css3-counter-styles-032.html
A third_party/blink/web_tests/external/wpt/css/css-counter-styles/japanese-formal/css3-counter-styles-047-ref.html
M third_party/blink/web_tests/external/wpt/css/css-counter-styles/japanese-formal/css3-counter-styles-047.html
A third_party/blink/web_tests/external/wpt/css/css-counter-styles/japanese-formal/css3-counter-styles-048-ref.html
M third_party/blink/web_tests/external/wpt/css/css-counter-styles/japanese-formal/css3-counter-styles-048.html
A third_party/blink/web_tests/external/wpt/css/css-counter-styles/japanese-formal/css3-counter-styles-049-ref.html
M third_party/blink/web_tests/external/wpt/css/css-counter-styles/japanese-formal/css3-counter-styles-049.html
A third_party/blink/web_tests/external/wpt/css/css-counter-styles/japanese-formal/css3-counter-styles-050-ref.html
M third_party/blink/web_tests/external/wpt/css/css-counter-styles/japanese-formal/css3-counter-styles-050.html
A third_party/blink/web_tests/external/wpt/css/css-counter-styles/japanese-formal/css3-counter-styles-051-ref.html
M third_party/blink/web_tests/external/wpt/css/css-counter-styles/japanese-formal/css3-counter-styles-051.html
A third_party/blink/web_tests/external/wpt/css/css-counter-styles/japanese-informal/css3-counter-styles-042-ref.html
M third_party/blink/web_tests/external/wpt/css/css-counter-styles/japanese-informal/css3-counter-styles-042.html
A third_party/blink/web_tests/external/wpt/css/css-counter-styles/japanese-informal/css3-counter-styles-043-ref.html
M third_party/blink/web_tests/external/wpt/css/css-counter-styles/japanese-informal/css3-counter-styles-043.html
A third_party/blink/web_tests/external/wpt/css/css-counter-styles/japanese-informal/css3-counter-styles-044-ref.html
M third_party/blink/web_tests/external/wpt/css/css-counter-styles/japanese-informal/css3-counter-styles-044.html
A third_party/blink/web_tests/external/wpt/css/css-counter-styles/japanese-informal/css3-counter-styles-045-ref.html
M third_party/blink/web_tests/external/wpt/css/css-counter-styles/japanese-informal/css3-counter-styles-045.html
A third_party/blink/web_tests/external/wpt/css/css-counter-styles/japanese-informal/css3-counter-styles-046-ref.html
M third_party/blink/web_tests/external/wpt/css/css-counter-styles/japanese-informal/css3-counter-styles-046.html
A third_party/blink/web_tests/external/wpt/css/css-counter-styles/katakana-iroha/css3-counter-styles-039-ref.html
M third_party/blink/web_tests/external/wpt/css/css-counter-styles/katakana-iroha/css3-counter-styles-039.html
A third_party/blink/web_tests/external/wpt/css/css-counter-styles/katakana-iroha/css3-counter-styles-040-ref.html
M third_party/blink/web_tests/external/wpt/css/css-counter-styles/katakana-iroha/css3-counter-styles-040.html
A third_party/blink/web_tests/external/wpt/css/css-counter-styles/katakana-iroha/css3-counter-styles-041-ref.html
M third_party/blink/web_tests/external/wpt/css/css-counter-styles/katakana-iroha/css3-counter-styles-041.html
A third_party/blink/web_tests/external/wpt/css/css-counter-styles/katakana/css3-counter-styles-036-ref.html
M third_party/blink/web_tests/external/wpt/css/css-counter-styles/katakana/css3-counter-styles-036.html
A third_party/blink/web_tests/external/wpt/css/css-counter-styles/katakana/css3-counter-styles-037-ref.html
M third_party/blink/web_tests/external/wpt/css/css-counter-styles/katakana/css3-counter-styles-037.html
A third_party/blink/web_tests/external/wpt/css/css-counter-styles/katakana/css3-counter-styles-038-ref.html
M third_party/blink/web_tests/external/wpt/css/css-counter-styles/katakana/css3-counter-styles-038.html
46 files changed, 1,097 insertions(+), 56 deletions(-)

To view, visit change 2676274. To unsubscribe, or for help writing mail filters, visit settings.

Xiaocheng Hu (Gerrit)

unread,

Feb 4, 2021, 4:14:15 PM2/4/21

to apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, Anders Hartvoll Ruud, Alexis Menard, chromium...@chromium.org

Attention is currently required from: Anders Hartvoll Ruud.

Patch set 1:Commit-Queue +1

View Change

To view, visit change 2676274. To unsubscribe, or for help writing mail filters, visit settings.

Blink WPT Bot (Gerrit)

unread,

Feb 4, 2021, 4:33:57 PM2/4/21

to Xiaocheng Hu, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, Chromium LUCI CQ, Anders Hartvoll Ruud, Alexis Menard, chromium...@chromium.org

Attention is currently required from: Xiaocheng Hu, Anders Hartvoll Ruud.

Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/27493.

When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md#Automatic-export-process

View Change

To view, visit change 2676274. To unsubscribe, or for help writing mail filters, visit settings.

Anders Hartvoll Ruud (Gerrit)

unread,

Feb 5, 2021, 6:04:05 AM2/5/21

to Xiaocheng Hu, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, Blink WPT Bot, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org

Attention is currently required from: Xiaocheng Hu.

Patch set 1:Code-Review +1

View Change

To view, visit change 2676274. To unsubscribe, or for help writing mail filters, visit settings.

Xiaocheng Hu (Gerrit)

unread,

Feb 5, 2021, 2:16:45 PM2/5/21

to apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, Anders Hartvoll Ruud, Blink WPT Bot, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org

Attention is currently required from: Xiaocheng Hu.

Patch set 1:Commit-Queue +2

View Change

To view, visit change 2676274. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Feb 5, 2021, 2:20:29 PM2/5/21

to Xiaocheng Hu, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, Anders Hartvoll Ruud, Blink WPT Bot, Alexis Menard, chromium...@chromium.org

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Anders Hartvoll Ruud: Looks good to me
  Xiaocheng Hu: Commit

Fix encoding of the suffix of CJK counter styles in UA style sheet

Many CJK counter styles use "、" (U+3001) as the suffix. This patch
properly escapes it in the UA style sheet to make the encoding correct.

As verification, this patch also adds ref files to the related WPT
tests. The new ref files are mechanically generated using the same
method as crrev.com/c/2674491

Bug: 687225
Change-Id: I4f29f17c290e21906601d8366a6a7db7d67b02a5

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2676274
Reviewed-by: Anders Hartvoll Ruud <and...@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaoc...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#851227}

To view, visit change 2676274. To unsubscribe, or for help writing mail filters, visit settings.

Blink WPT Bot (Gerrit)

unread,

Feb 5, 2021, 3:06:49 PM2/5/21

to Xiaocheng Hu, Chromium LUCI CQ, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, Anders Hartvoll Ruud, Alexis Menard, chromium...@chromium.org

The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/27493

View Change

To view, visit change 2676274. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward