[HIC] Create composited layers for canvas descendants [chromium/src : main]

0 views
Skip to first unread message

Philip Rogers (Gerrit)

unread,
Jan 21, 2026, 5:36:28 PM (2 days ago) Jan 21
to Stefan Zager, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Attention needed from Stefan Zager

Philip Rogers voted and added 2 comments

Votes added by Philip Rogers

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Philip Rogers . resolved

LGTM

File third_party/blink/renderer/core/paint/inline_box_fragment_painter.cc
Line 135, Patchset 5 (Latest): (!style_.MaskBoxImage().GetImage()->IsLoaded() ||
Philip Rogers . resolved

I filed https://crbug.com/477643905 to remove these.

Open in Gerrit

Related details

Attention is currently required from:
  • Stefan Zager
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id4aafd0ea0924c51e16e5a5fb4db8925ca418542
Gerrit-Change-Number: 7487907
Gerrit-PatchSet: 5
Gerrit-Owner: Stefan Zager <sza...@chromium.org>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Stefan Zager <sza...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Stefan Zager <sza...@chromium.org>
Gerrit-Comment-Date: Wed, 21 Jan 2026 22:36:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Philip Rogers (Gerrit)

unread,
Jan 21, 2026, 5:38:21 PM (2 days ago) Jan 21
to Stefan Zager, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Attention needed from Stefan Zager

Philip Rogers voted Commit-Queue+2

Commit-Queue+2
Gerrit-Comment-Date: Wed, 21 Jan 2026 22:38:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jan 21, 2026, 5:43:07 PM (2 days ago) Jan 21
to Stefan Zager, Philip Rogers, AyeAye, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[HIC] Create composited layers for canvas descendants

Composited layers will be created unconditionally for all drawn canvas
direct children. At the grandchild level and below, composited layers
will be created according to the same heuristics as non-canvas html
content.

This is a first step towards enabling compositor-thread scrolling and
animations in html-in-canvas content.
Bug: 475579174
Change-Id: Id4aafd0ea0924c51e16e5a5fb4db8925ca418542
Commit-Queue: Philip Rogers <p...@chromium.org>
Reviewed-by: Philip Rogers <p...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1572581}
Files:
  • M third_party/blink/renderer/core/html/canvas/canvas_rendering_context.cc
  • M third_party/blink/renderer/core/paint/box_painter_base.cc
  • M third_party/blink/renderer/core/paint/compositing/compositing_reason_finder.cc
  • M third_party/blink/renderer/core/paint/compositing/compositing_test.cc
  • M third_party/blink/renderer/core/paint/cull_rect_updater.cc
  • M third_party/blink/renderer/core/paint/inline_box_fragment_painter.cc
  • M third_party/blink/renderer/core/paint/paint_flags.h
  • M third_party/blink/renderer/core/paint/paint_layer_painter.cc
  • M third_party/blink/renderer/core/style/style_crossfade_image.cc
  • M third_party/blink/renderer/platform/graphics/compositing_reasons.cc
  • M third_party/blink/renderer/platform/graphics/compositing_reasons.h
  • M third_party/blink/web_tests/TestExpectations
Change size: M
Delta: 12 files changed, 105 insertions(+), 22 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Philip Rogers
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id4aafd0ea0924c51e16e5a5fb4db8925ca418542
Gerrit-Change-Number: 7487907
Gerrit-PatchSet: 6
Gerrit-Owner: Stefan Zager <sza...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Stefan Zager <sza...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages