Javier Fernandez (Gerrit)

unread,

May 27, 2026, 5:03:12 PMMay 27

to Dan Clark, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Dan Clark

Javier Fernandez added 1 comment

Patchset-level comments

File-level comment, Patchset 10:

Javier Fernandez . resolved

Hi daniec@

I know the tests this change tries to fix are tentative, but I think the expected behavior they define make sense. These tests were added by Firefox in the bug 1777905 [1]

I have filed an issue [2] in the WPT to ask about some clarifications regarding the expectations proposed by these tests.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1777905
[2] https://github.com/web-platform-tests/wpt/issues/59509

Open in Gerrit

Related details

Attention is currently required from:

Dan Clark

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dan Clark (Gerrit)

unread,

May 29, 2026, 6:55:08 PMMay 29

to Javier Fernandez, Sambamurthy Bandaru, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Javier Fernandez and Sambamurthy Bandaru

Dan Clark added 1 comment

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Dan Clark . resolved

I timed out on this review this week -- Samba, mind taking a first pass?

Open in Gerrit

Related details

Attention is currently required from:

Javier Fernandez
Sambamurthy Bandaru

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Javier Fernandez (Gerrit)

unread,

Jun 12, 2026, 10:31:21 AMJun 12

to Sambamurthy Bandaru, Dan Clark, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Sambamurthy Bandaru

Javier Fernandez added 1 comment

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Javier Fernandez . resolved

Hi sambamurthy.bandaru@

A gentle ping to remind you about this pending review.
Thanks.

Open in Gerrit

Related details

Attention is currently required from:

Sambamurthy Bandaru

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Javier Fernandez (Gerrit)

unread,

Jun 25, 2026, 9:21:04 AMJun 25

to Sambamurthy Bandaru, Dan Clark, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Dan Clark and Sambamurthy Bandaru

Javier Fernandez added 1 comment

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Javier Fernandez . resolved

Hi daniec@
Could you take a look at this CL ?
Thanks

Open in Gerrit

Related details

Attention is currently required from:

Dan Clark
Sambamurthy Bandaru

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dan Clark (Gerrit)

unread,

Jul 23, 2026, 6:34:39 PM (5 days ago) Jul 23

to Javier Fernandez, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Javier Fernandez

Dan Clark added 3 comments

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Dan Clark . resolved

Sorry for the long wait on this.

Commit Message

Line 7, Patchset 11 (Latest):Ensure metadata-tags are not editable content.

Dan Clark . unresolved

A behavior change like this should be guarded with a flag in `runtime_enabled_features.json5`.

File third_party/blink/renderer/core/html/resources/html.css

Line 985, Patchset 11 (Latest): -webkit-user-modify: read-only !important;

Dan Clark . unresolved

I'm unsure about broadly making metadata content non-editable under <head> or <html>. It's a little odd, but stuff like this works under both Safari and Chromium: https://dandclark.github.io/demos/editable-head.html

Currently Firefox is the odd one out by not allowing it, so if we change to match them we haven't really improved overall interoperability unless we convince Safari to also make the change.

I saw you opened an issue at https://github.com/web-platform-tests/wpt/issues/59509, but I think the better venue to discuss this would be the Editing WG, so I took the liberty of opening https://github.com/w3c/editing/issues/546.

Agreeing there to align on one behavior seems like the best way forward.

Open in Gerrit

Related details

Attention is currently required from:

Javier Fernandez

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Javier Fernandez (Gerrit)

unread,

Jul 27, 2026, 1:45:34 PM (yesterday) Jul 27

to Dan Clark, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Dan Clark

Javier Fernandez added 1 comment

File third_party/blink/renderer/core/html/resources/html.css

Line 985, Patchset 11 (Latest): -webkit-user-modify: read-only !important;

Dan Clark . unresolved

I'm unsure about broadly making metadata content non-editable under <head> or <html>. It's a little odd, but stuff like this works under both Safari and Chromium: https://dandclark.github.io/demos/editable-head.html
Currently Firefox is the odd one out by not allowing it, so if we change to match them we haven't really improved overall interoperability unless we convince Safari to also make the change.
I saw you opened an issue at https://github.com/web-platform-tests/wpt/issues/59509, but I think the better venue to discuss this would be the Editing WG, so I took the liberty of opening https://github.com/w3c/editing/issues/546.
Agreeing there to align on one behavior seems like the best way forward.

Javier Fernandez

Thanks for the comment and for moving the issue to the Editing WG, it's indeed a more appropriated venue for the discussion.

I think we can put this CL on hold until the WG issue is discussed.

Open in Gerrit

Related details

Attention is currently required from:

Dan Clark

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Ensure metadata-tags are not editable content. [chromium/src : main]

Javier Fernandez (Gerrit)

Javier Fernandez added 1 comment

Related details

Dan Clark (Gerrit)

Dan Clark added 1 comment

Related details

Javier Fernandez (Gerrit)

Javier Fernandez added 1 comment

Related details

Javier Fernandez (Gerrit)

Javier Fernandez added 1 comment

Related details

Dan Clark (Gerrit)

Dan Clark added 3 comments

Related details

Javier Fernandez (Gerrit)

Javier Fernandez added 1 comment

Related details