Daniil Sakhapov (Gerrit)

unread,

Apr 13, 2026, 10:58:58 AM (5 days ago) Apr 13

to android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, Rune Lillesveen, Menard, Alexis, chromium...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Rune Lillesveen

Daniil Sakhapov added 1 comment

File third_party/blink/renderer/core/css/resolver/style_adjuster.cc

Line 1402, Patchset 1: }

Rune Lillesveen . resolved

The spec says it should be ignored, not affect the computed value.

Daniil Sakhapov

Done

Open in Gerrit

Related details

Attention is currently required from:

Rune Lillesveen

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Rune Lillesveen (Gerrit)

unread,

Apr 14, 2026, 3:14:23 AM (5 days ago) Apr 14

to Daniil Sakhapov, Rune Lillesveen, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Daniil Sakhapov

Rune Lillesveen voted and added 3 comments

Votes added by Rune Lillesveen

Code-Review

+1

3 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Rune Lillesveen . resolved

lgtm with nits

File third_party/blink/web_tests/external/wpt/css/css-borders/border-shape/border-shape-ignore-radius-ref.html

Line 11, Patchset 2 (Latest):.test {

Rune Lillesveen . unresolved

Ditto

File third_party/blink/web_tests/external/wpt/css/css-borders/border-shape/border-shape-ignore-radius.html

Line 14, Patchset 2 (Latest):.test {

Rune Lillesveen . unresolved

Nit: it's a bit strange that you use two selectors here. Why not just use 'div', '.test', or '#test'?

Open in Gerrit

Related details

Attention is currently required from:

Daniil Sakhapov

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Daniil Sakhapov (Gerrit)

unread,

Apr 14, 2026, 7:37:49 AM (5 days ago) Apr 14

to Rune Lillesveen, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Daniil Sakhapov voted and added 2 comments

Votes added by Daniil Sakhapov

Commit-Queue

+2

2 comments

File third_party/blink/web_tests/external/wpt/css/css-borders/border-shape/border-shape-ignore-radius-ref.html

Line 11, Patchset 2:.test {

Rune Lillesveen . resolved

Ditto

Daniil Sakhapov

Done

File third_party/blink/web_tests/external/wpt/css/css-borders/border-shape/border-shape-ignore-radius.html

Line 14, Patchset 2:.test {

Rune Lillesveen . resolved

Nit: it's a bit strange that you use two selectors here. Why not just use 'div', '.test', or '#test'?

Daniil Sakhapov

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Blink W3C Test Autoroller (Gerrit)

unread,

Apr 14, 2026, 7:57:34 AM (5 days ago) Apr 14

to Daniil Sakhapov, Rune Lillesveen, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Message from Blink W3C Test Autoroller

Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/59205.

When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Daniil Sakhapov (Gerrit)

unread,

Apr 14, 2026, 9:25:14 AM (4 days ago) Apr 14

to Blink W3C Test Autoroller, Rune Lillesveen, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Daniil Sakhapov voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

chromium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,

Apr 14, 2026, 9:54:35 AM (4 days ago) Apr 14

to Daniil Sakhapov, Blink W3C Test Autoroller, Rune Lillesveen, android-bu...@system.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

chromiu...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed changes

Unreviewed changes

2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: third_party/blink/web_tests/external/wpt/css/css-borders/border-shape/border-shape-ignore-radius.html
Insertions: 1, Deletions: 3.

The diff is too large to show. Please review the diff.
```
```
The name of the file: third_party/blink/web_tests/external/wpt/css/css-borders/border-shape/border-shape-ignore-radius-ref.html
Insertions: 1, Deletions: 3.

The diff is too large to show. Please review the diff.
```

Change information

Commit message:

[border-shape] Disable border-radius and corner-shape with border-shape

https://drafts.csswg.org/css-borders-4/#border-shape-radius-interaction
The border-shape property is not compatible with border-radius and
corner-shape, so disable it explicitly instead of doing so in layout/
paint.

Fixed: 501626908

Change-Id: I34eb29d8de2c8c4049e0b7e315b5cc0e640ff67c

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7748831

Reviewed-by: Rune Lillesveen <fut...@chromium.org>

Commit-Queue: Daniil Sakhapov <sakh...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1614410}

Files:

M third_party/blink/renderer/core/paint/box_painter_base.cc
M third_party/blink/renderer/core/style/computed_style.h
A third_party/blink/web_tests/external/wpt/css/css-borders/border-shape/border-shape-ignore-radius-computed.html
A third_party/blink/web_tests/external/wpt/css/css-borders/border-shape/border-shape-ignore-radius-ref.html
A third_party/blink/web_tests/external/wpt/css/css-borders/border-shape/border-shape-ignore-radius.html

Change size: M

Delta: 5 files changed, 68 insertions(+), 1 deletion(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Rune Lillesveen

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Blink W3C Test Autoroller (Gerrit)

unread,

Apr 14, 2026, 9:50:15 PM (4 days ago) Apr 14

to chromiu...@luci-project-accounts.iam.gserviceaccount.com, Daniil Sakhapov, Rune Lillesveen, android-bu...@system.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Message from Blink W3C Test Autoroller

The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/59205

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[border-shape] Disable border-radius and corner-shape with border-shape [chromium/src : main]

Daniil Sakhapov (Gerrit)

Daniil Sakhapov added 1 comment

Related details

Rune Lillesveen (Gerrit)

Rune Lillesveen voted and added 3 comments

Votes added by Rune Lillesveen

3 comments

Related details

Daniil Sakhapov (Gerrit)

Daniil Sakhapov voted and added 2 comments

Votes added by Daniil Sakhapov

2 comments

Related details

Blink W3C Test Autoroller (Gerrit)

Message from Blink W3C Test Autoroller

Related details

Daniil Sakhapov (Gerrit)

Daniil Sakhapov voted Commit-Queue+2

Related details

chromium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

chromiu...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed changes

Unreviewed changes

Change information

Blink W3C Test Autoroller (Gerrit)

Message from Blink W3C Test Autoroller

Related details