[iframe] Remove the `from-element` keyword [chromium/src : main]

0 views
Skip to first unread message

Koji Ishii (Gerrit)

unread,
Feb 2, 2026, 1:07:16 AM (11 days ago) Feb 2
to Kent Tamura, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Kent Tamura

Koji Ishii voted and added 1 comment

Votes added by Koji Ishii

Auto-Submit+1

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic22610419ce9029a81ca4b97ba15dc14d64107fe
Gerrit-Change-Number: 7534797
Gerrit-PatchSet: 2
Gerrit-Owner: Koji Ishii <ko...@chromium.org>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-Attention: Kent Tamura <tk...@chromium.org>
Gerrit-Comment-Date: Mon, 02 Feb 2026 06:06:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Kent Tamura (Gerrit)

unread,
Feb 2, 2026, 1:13:46 AM (11 days ago) Feb 2
to Koji Ishii, Kent Tamura, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Koji Ishii

Kent Tamura voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Koji Ishii
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic22610419ce9029a81ca4b97ba15dc14d64107fe
    Gerrit-Change-Number: 7534797
    Gerrit-PatchSet: 2
    Gerrit-Owner: Koji Ishii <ko...@chromium.org>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-Attention: Koji Ishii <ko...@chromium.org>
    Gerrit-Comment-Date: Mon, 02 Feb 2026 06:13:12 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Koji Ishii (Gerrit)

    unread,
    Feb 2, 2026, 5:59:56 AM (11 days ago) Feb 2
    to Kent Tamura, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
    Attention needed from Kent Tamura

    Koji Ishii voted

    Code-Review+1
    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Kent Tamura
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ic22610419ce9029a81ca4b97ba15dc14d64107fe
      Gerrit-Change-Number: 7534797
      Gerrit-PatchSet: 2
      Gerrit-Owner: Koji Ishii <ko...@chromium.org>
      Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
      Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-Attention: Kent Tamura <tk...@chromium.org>
      Gerrit-Comment-Date: Mon, 02 Feb 2026 10:59:24 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Blink W3C Test Autoroller (Gerrit)

      unread,
      Feb 2, 2026, 6:03:21 AM (11 days ago) Feb 2
      to Koji Ishii, Kent Tamura, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
      Attention needed from Kent Tamura

      Message from Blink W3C Test Autoroller

      Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/57485.

      When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

      WPT Export docs:
      https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Kent Tamura
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ic22610419ce9029a81ca4b97ba15dc14d64107fe
      Gerrit-Change-Number: 7534797
      Gerrit-PatchSet: 2
      Gerrit-Owner: Koji Ishii <ko...@chromium.org>
      Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
      Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
      Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-Attention: Kent Tamura <tk...@chromium.org>
      Gerrit-Comment-Date: Mon, 02 Feb 2026 11:03:06 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: No
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Feb 2, 2026, 6:03:44 AM (11 days ago) Feb 2
      to Koji Ishii, Blink W3C Test Autoroller, Kent Tamura, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      [iframe] Remove the `from-element` keyword

      This patch removes the `from-element` keyword from the CSS
      parser, as per the resolution[1] to change the CSS property
      for the responsive iframes.

      All changes are under an experimental runtime flag.

      [1] https://github.com/w3c/csswg-drafts/issues/1771#issuecomment-3806716273
      Bug: 418397278
      Change-Id: Ic22610419ce9029a81ca4b97ba15dc14d64107fe
      Commit-Queue: Koji Ishii <ko...@chromium.org>
      Reviewed-by: Kent Tamura <tk...@chromium.org>
      Reviewed-by: Koji Ishii <ko...@chromium.org>
      Auto-Submit: Koji Ishii <ko...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1578017}
      Files:
      • M third_party/blink/renderer/core/css/css_value_keywords.json5
      • M third_party/blink/renderer/core/css/properties/computed_style_utils.cc
      • M third_party/blink/renderer/core/css/properties/css_parsing_utils.cc
      • M third_party/blink/renderer/core/css/resolver/style_builder_converter.cc
      • M third_party/blink/renderer/core/style/style_intrinsic_length.h
      • D third_party/blink/web_tests/external/wpt/css/css-sizing/contain-intrinsic-size/parsing/from-element-computed.tentative.html
      • D third_party/blink/web_tests/external/wpt/css/css-sizing/contain-intrinsic-size/parsing/from-element-valid.tentative.html
      Change size: M
      Delta: 7 files changed, 5 insertions(+), 115 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Koji Ishii, +1 by Kent Tamura
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ic22610419ce9029a81ca4b97ba15dc14d64107fe
      Gerrit-Change-Number: 7534797
      Gerrit-PatchSet: 3
      Gerrit-Owner: Koji Ishii <ko...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
      Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
      Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
      open
      diffy
      satisfied_requirement

      Blink W3C Test Autoroller (Gerrit)

      unread,
      Feb 2, 2026, 6:50:17 AM (11 days ago) Feb 2
      to Chromium LUCI CQ, Koji Ishii, Kent Tamura, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

      Message from Blink W3C Test Autoroller

      The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/57485

      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ic22610419ce9029a81ca4b97ba15dc14d64107fe
      Gerrit-Change-Number: 7534797
      Gerrit-PatchSet: 3
      Gerrit-Owner: Koji Ishii <ko...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
      Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
      Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-Comment-Date: Mon, 02 Feb 2026 11:50:10 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: No
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages