Add `normal` keyword for interest-*-delay properties [chromium/src : main]
AI Code Reviewer (Gerrit)
AI Code Reviewer added 2 comments![]( "Open in Gerrit")
static StyleInterestDelay ConvertInterestDelayValue(const StyleResolverState&,Blink Style Guide: Naming - May leave obvious parameter names out of function declarations. For clarity, please add parameter names to this function declaration. The roles of `StyleResolverState&` and `CSSValue&` are not obvious from the types alone.
***
_To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options: \
**Done** | **Won't fix**: reason | **b/<bug_id>** | **Invalid:** reason \
\
This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent). \
AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve. \
[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
unsigned DelaySeconds() const { return seconds_; }nit: Blink Style Guide: Naming - Precede setters with the word “Set”; use bare words for getters. Please consider renaming this getter to `Seconds()` to match the member variable `seconds_` and follow the 'bare words for getters' convention.
***
_To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options: \
**Done** | **Won't fix**: reason | **b/<bug_id>** | **Invalid:** reason \
\
This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent). \
AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve. \
[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
Related details
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mason Freed (Gerrit)
Mason Freed added 1 comment![]( "Open in Gerrit")
Hey andruud@ I'm hoping you can help me with this CL. Mostly to review it, but actually first to help me stop flailing around to fix the last couple tests. Something is odd about serialization of the shorthand, and maybe the longhands too, I'm not sure. The `normal` keyword is maybe not round-tripping, but I cannot figure out why, despite digging into the test's [RoundTripProperty()](https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/css/parser/css_parser_impl_test.cc;l=1214;drc=ee6f23f5d4fd4999d26400e5ab390d9daa56accf) function to see why it returns `""` for `interest-delay: normal`.
In particular, these two tests still fail:
- CSSParserImplTest.AllPropertiesCanParseImportant
- external/wpt/css/cssom/cssom-getPropertyValue-common-checks.html
Can you take a look and maybe start reviewing what I've done to see where I've gone horribly wrong? Did I do the `StyleInterestDelay` thing correctly? Or should that be derived from `CSSValue`? I thought for a `normal` value I could get away without doing that.
Related details
- Anders Hartvoll Ruud
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |