ComputedStyleTest.AnimationFlags() with less macro code. [chromium/src : main]
0 views
Skip to first unread message
Morten Stenshorne (Gerrit)
Jan 16, 2026, 5:39:08 AM (7 days ago) Jan 16
to Rune Lillesveen, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Rune Lillesveen
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Rune Lillesveen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rune Lillesveen (Gerrit)
Jan 16, 2026, 5:47:14 AM (7 days ago) Jan 16
to Morten Stenshorne, Rune Lillesveen, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Morten Stenshorne
Rune Lillesveen voted and added 2 comments![]( "Open in Gerrit")
Votes added by Rune Lillesveen
| Code-Review | +1 |
2 comments
Patchset-level comments
File third_party/blink/renderer/core/style/computed_style_test.cc
Line 567, Patchset 1 (Latest):
ComputedStyle::Difference::kNonInherited, true);Rune Lillesveen . unresolved
Nit: would be easier to read these expectations via a named boolean or similar.
Related details
Attention is currently required from:
- Morten Stenshorne
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Morten Stenshorne (Gerrit)
Jan 16, 2026, 6:34:05 AM (7 days ago) Jan 16
to Rune Lillesveen, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Morten Stenshorne added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/style/computed_style_test.cc
Nit: would be easier to read these expectations via a named boolean or similar.
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Morten Stenshorne (Gerrit)
Jan 19, 2026, 3:30:27 AM (4 days ago) Jan 19
to Rune Lillesveen, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Morten Stenshorne voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 19, 2026, 3:54:54 AM (4 days ago) Jan 19
to Morten Stenshorne, Rune Lillesveen, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: third_party/blink/renderer/core/style/computed_style_test.cc
Insertions: 28, Deletions: 16.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
ComputedStyleTest.AnimationFlags() with less macro code.
In a follow-up CL, I want to test the combination of
`!VisualInvalidationDiff().HasDifference()` and
`ComputedStyle::ComputeDifference()` != kEqual. Updating the existing
macros (which had lots of code duplication anyway) wasn't too
compelling, so I did this instead.
Change-Id: I6bbd0439ec35871cbd675254a182dc918232e221
Reviewed-by: Rune Lillesveen <fut...@chromium.org>
Commit-Queue: Morten Stenshorne <mste...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1571013}
Files:
- M third_party/blink/renderer/core/style/computed_style_test.cc
Change size: M
Delta: 1 file changed, 67 insertions(+), 45 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Rune Lillesveen
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages