Remove computed-width-values-depend-on-style-values Virtual Test Suite [chromium/src : main]

0 views
Skip to first unread message

Sam Davis Omekara (Gerrit)

unread,
May 4, 2026, 7:30:33 PM (10 days ago) May 4
to Kevin Babbitt, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Kevin Babbitt

Sam Davis Omekara voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kevin Babbitt
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1eb3a8910b4dbad327ef8b4b0fe9804bd9000d96
Gerrit-Change-Number: 7812736
Gerrit-PatchSet: 4
Gerrit-Owner: Sam Davis Omekara <samome...@microsoft.com>
Gerrit-Reviewer: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-Reviewer: Sam Davis Omekara <samome...@microsoft.com>
Gerrit-Attention: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-Comment-Date: Mon, 04 May 2026 23:30:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Kevin Babbitt (Gerrit)

unread,
May 4, 2026, 7:55:55 PM (10 days ago) May 4
to Sam Davis Omekara, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Sam Davis Omekara

Kevin Babbitt added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Kevin Babbitt . resolved

I don't think we should delete the suite until we're ready to delete the flag and the old codepath. The change shipped in 147. Given that it's a change to a longstanding behavior and exposed at least one site issue (which has been fixed), I'd feel comfortable if we kept the old code and the suite around for another release or two - extending the expiry of the suite is also an option, right?

Open in Gerrit

Related details

Attention is currently required from:
  • Sam Davis Omekara
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1eb3a8910b4dbad327ef8b4b0fe9804bd9000d96
Gerrit-Change-Number: 7812736
Gerrit-PatchSet: 4
Gerrit-Owner: Sam Davis Omekara <samome...@microsoft.com>
Gerrit-Reviewer: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-Reviewer: Sam Davis Omekara <samome...@microsoft.com>
Gerrit-Attention: Sam Davis Omekara <samome...@microsoft.com>
Gerrit-Comment-Date: Mon, 04 May 2026 23:55:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kevin Babbitt (Gerrit)

unread,
May 4, 2026, 7:56:35 PM (10 days ago) May 4
to Sam Davis Omekara, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Sam Davis Omekara

Kevin Babbitt added 1 comment

Patchset-level comments
Kevin Babbitt . unresolved

I don't think we should delete the suite until we're ready to delete the flag and the old codepath. The change shipped in 147. Given that it's a change to a longstanding behavior and exposed at least one site issue (which has been fixed), I'd feel comfortable if we kept the old code and the suite around for another release or two - extending the expiry of the suite is also an option, right?

Kevin Babbitt

(mark as unresolved)

Open in Gerrit

Related details

Attention is currently required from:
  • Sam Davis Omekara
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1eb3a8910b4dbad327ef8b4b0fe9804bd9000d96
    Gerrit-Change-Number: 7812736
    Gerrit-PatchSet: 4
    Gerrit-Owner: Sam Davis Omekara <samome...@microsoft.com>
    Gerrit-Reviewer: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-Reviewer: Sam Davis Omekara <samome...@microsoft.com>
    Gerrit-Attention: Sam Davis Omekara <samome...@microsoft.com>
    Gerrit-Comment-Date: Mon, 04 May 2026 23:56:26 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Kevin Babbitt <kbab...@microsoft.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Sam Davis Omekara (Gerrit)

    unread,
    May 14, 2026, 1:16:17 AM (yesterday) May 14
    to Kevin Babbitt, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

    Sam Davis Omekara abandoned this change.

    View Change

    Abandoned

    Sam Davis Omekara abandoned this change

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: abandon
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages