[layout] Reinsert LayoutObjects which undergo a positioned-state change. [chromium/src : main]

0 views
Skip to first unread message

Ian Kilpatrick (Gerrit)

unread,
Dec 17, 2025, 5:30:29 PM12/17/25
to Philip Rogers, Rune Lillesveen, Morten Stenshorne, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, zol...@webkit.org
Attention needed from Morten Stenshorne, Philip Rogers and Rune Lillesveen

Ian Kilpatrick voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Morten Stenshorne
  • Philip Rogers
  • Rune Lillesveen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ied7a212aae707b2db627a8ee15ba57b5b289235a
Gerrit-Change-Number: 7271268
Gerrit-PatchSet: 2
Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
Gerrit-Attention: Philip Rogers <p...@chromium.org>
Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
Gerrit-Comment-Date: Wed, 17 Dec 2025 22:30:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Ian Kilpatrick (Gerrit)

unread,
Dec 17, 2025, 5:31:54 PM12/17/25
to Philip Rogers, Rune Lillesveen, Morten Stenshorne, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, zol...@webkit.org
Attention needed from Morten Stenshorne, Philip Rogers and Rune Lillesveen

Ian Kilpatrick added 1 comment

File third_party/blink/renderer/core/layout/layout_object.cc
Line 3378, Patchset 2 (Latest): }
Ian Kilpatrick . resolved

This logic shifts to LayoutObject::UpdateAfterReinsert

Gerrit-Comment-Date: Wed, 17 Dec 2025 22:31:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

AI Code Reviewer (Gerrit)

unread,
Dec 17, 2025, 5:44:58 PM12/17/25
to Ian Kilpatrick, Philip Rogers, Rune Lillesveen, Morten Stenshorne, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, zol...@webkit.org
Attention needed from Morten Stenshorne, Philip Rogers and Rune Lillesveen

AI Code Reviewer added 1 comment

File third_party/blink/renderer/core/layout/layout_block_flow.cc
Line 371, Patchset 2 (Latest): if (!FirstChild() && IsMergeableAnonymousBlock(this)) {
AI Code Reviewer . unresolved

nit: Grammar/Clarity. "was created" -> "were created" (matching "we") or "it was created". "remove ourselves" -> "remove this object".

To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason


_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Open in Gerrit

Related details

Attention is currently required from:
  • Morten Stenshorne
  • Philip Rogers
  • Rune Lillesveen
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ied7a212aae707b2db627a8ee15ba57b5b289235a
    Gerrit-Change-Number: 7271268
    Gerrit-PatchSet: 2
    Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
    Gerrit-Attention: Philip Rogers <p...@chromium.org>
    Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Comment-Date: Wed, 17 Dec 2025 22:44:54 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Rune Lillesveen (Gerrit)

    unread,
    Dec 18, 2025, 3:40:37 AM12/18/25
    to Ian Kilpatrick, AI Code Reviewer, Philip Rogers, Rune Lillesveen, Morten Stenshorne, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, zol...@webkit.org
    Attention needed from Ian Kilpatrick, Morten Stenshorne and Philip Rogers

    Rune Lillesveen added 1 comment

    File third_party/blink/renderer/core/dom/element.cc
    Line 5726, Patchset 3 (Latest): LayoutTreeBuilderTraversal::NextSiblingLayoutObject(*this));
    Rune Lillesveen . unresolved

    This can be more expensive than the current implementation in the presence of display:none and display:contents subtrees (assuming the current code only has to work on the box tree?).

    The pathological cases are unlikely, though.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ian Kilpatrick
    • Morten Stenshorne
    • Philip Rogers
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ied7a212aae707b2db627a8ee15ba57b5b289235a
    Gerrit-Change-Number: 7271268
    Gerrit-PatchSet: 3
    Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
    Gerrit-Attention: Philip Rogers <p...@chromium.org>
    Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Comment-Date: Thu, 18 Dec 2025 08:40:19 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Morten Stenshorne (Gerrit)

    unread,
    Dec 18, 2025, 5:47:20 AM12/18/25
    to Ian Kilpatrick, AI Code Reviewer, Philip Rogers, Rune Lillesveen, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, zol...@webkit.org
    Attention needed from Ian Kilpatrick and Philip Rogers

    Morten Stenshorne voted and added 3 comments

    Votes added by Morten Stenshorne

    Code-Review+1

    3 comments

    Commit Message
    Line 7, Patchset 3 (Latest):[layout] Reinsert LayoutObjects which undergo a positioned-state change.
    Morten Stenshorne . unresolved

    Also floats.

    So "out-of-flow-state" would be more correct, although "out-of-flow" is often taken as either abspos and fixedpos. How about "in-flow state" then?

    Maybe also reflect this in the runtime feature flag name, but I won't insist.

    Line 11, Patchset 3 (Latest):position:absolute).
    Morten Stenshorne . unresolved

    or float:left to float:none

    File third_party/blink/renderer/core/layout/layout_object.cc
    Line 3272, Patchset 3 (Latest): SetScrollAnchorDisablingStyleChangedOnAncestor();
    Morten Stenshorne . unresolved

    If you happen to know why this (and the below) is necessary, please add a comment.

    I see that this CL disables the corresponding code in StyleDidChange()...

    But I wish we knew what this is about, and why it's still needed, now that the layout object is taken out and re-inserted.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ian Kilpatrick
    • Philip Rogers
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ied7a212aae707b2db627a8ee15ba57b5b289235a
      Gerrit-Change-Number: 7271268
      Gerrit-PatchSet: 3
      Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
      Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
      Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
      Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
      Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
      Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
      Gerrit-Attention: Philip Rogers <p...@chromium.org>
      Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
      Gerrit-Comment-Date: Thu, 18 Dec 2025 10:47:03 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages