[html-in-canvas] Prevent cross-origin images in paint worklets [chromium/src : main]

0 views

Skip to first unread message

Philip Rogers (Gerrit)

unread,

May 13, 2026, 8:13:33 PM (2 days ago) May 13

to Stefan Zager, chromium...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Attention needed from Stefan Zager

Philip Rogers voted and added 1 comment

Votes added by Philip Rogers

Commit-Queue

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Philip Rogers . unresolved

I think this is too brittle and complex. I'd like to switch to just pessimistically treating all css paint worklet images as cross-origin. WDYT? This would prevent them from working in html-in-canvas. Paint worklet is currently chromium-only, and we could bring this patch back in the future if needed.

Open in Gerrit

Related details

Attention is currently required from:

Stefan Zager

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Stefan Zager (Gerrit)

unread,

May 14, 2026, 11:17:09 AM (16 hours ago) May 14

to Philip Rogers, Menard, Alexis, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, apavlo...@chromium.org, blink-revi...@chromium.org, zol...@webkit.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Attention needed from Philip Rogers

Stefan Zager added 1 comment

File third_party/blink/renderer/core/style/style_generated_image.cc

Line 105, Patchset 2 (Latest):bool StyleGeneratedImage::IsCorsSameOrigin(const ComputedStyle* style,

Stefan Zager . unresolved

This might feel less gross if we could pre-compute it during style resolution rather than computing it on the fly from paint.