[autosizer] Condense SpecifiedLineHeight, LineHeight, LineHeightInternal [chromium/src : main]
0 views
Skip to first unread message
David Grogan (Gerrit)
Apr 15, 2026, 1:34:06 AM (4 days ago) Apr 15
to David Grogan, Ian Kilpatrick, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Ian Kilpatrick
David Grogan voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Ian Kilpatrick
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Kilpatrick (Gerrit)
Apr 15, 2026, 1:20:44 PM (3 days ago) Apr 15
to David Grogan, chromiu...@luci-project-accounts.iam.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from David Grogan
Ian Kilpatrick voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ian Kilpatrick
| Code-Review | +1 |
1 comment
File third_party/blink/renderer/core/css/css_to_length_conversion_data.cc
Line 201, Patchset 3 (Latest):
style.SpecifiedLineHeight(),Ian Kilpatrick . unresolved
Would be good to also change these - but can do in a followup if you like.
Related details
Attention is currently required from:
- David Grogan
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Grogan (Gerrit)
Apr 16, 2026, 3:28:16 AM (3 days ago) Apr 16
to David Grogan, Ian Kilpatrick, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Ian Kilpatrick
David Grogan voted and added 1 comment![]( "Open in Gerrit")
Votes added by David Grogan
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
File third_party/blink/renderer/core/css/css_to_length_conversion_data.cc
Would be good to also change these - but can do in a followup if you like.
Attention is currently required from:
- Ian Kilpatrick
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Kilpatrick (Gerrit)
Apr 16, 2026, 10:48:43 AM (2 days ago) Apr 16
to David Grogan, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from David Grogan
Ian Kilpatrick voted![]( "Open in Gerrit")
Attention is currently required from:
- David Grogan
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 16, 2026, 10:52:04 AM (2 days ago) Apr 16
to David Grogan, Ian Kilpatrick, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[autosizer] Condense SpecifiedLineHeight, LineHeight, LineHeightInternal
We don't need these to be separate after removing the autosizer.
Change-Id: I515fc2dc17c26f90a13321cc99fac0616e5ee622
Bug: 391990606
Auto-Submit: David Grogan <dgr...@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilp...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1615855}
Files:
- M third_party/blink/renderer/core/animation/length_property_functions.cc
- M third_party/blink/renderer/core/animation/number_property_functions.cc
- M third_party/blink/renderer/core/css/css_properties.json5
- M third_party/blink/renderer/core/css/css_property_equality.cc
- M third_party/blink/renderer/core/css/css_to_length_conversion_data.cc
- M third_party/blink/renderer/core/style/computed_style.cc
- M third_party/blink/renderer/core/style/computed_style.h
- M third_party/blink/renderer/core/style/font_size_style.h
Change size: S
Delta: 8 files changed, 9 insertions(+), 23 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ian Kilpatrick
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages