Ian Kilpatrick (Gerrit)

unread,

Apr 15, 2026, 6:48:48 PM (3 days ago) Apr 15

to Morten Stenshorne, Anders Hartvoll Ruud, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, zol...@webkit.org

Attention needed from Anders Hartvoll Ruud and Morten Stenshorne

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Anders Hartvoll Ruud
Morten Stenshorne

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Anders Hartvoll Ruud (Gerrit)

unread,

Apr 16, 2026, 2:09:06 AM (3 days ago) Apr 16

to Ian Kilpatrick, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Morten Stenshorne, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, zol...@webkit.org

Attention needed from Ian Kilpatrick and Morten Stenshorne

Anders Hartvoll Ruud voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Ian Kilpatrick
Morten Stenshorne

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Morten Stenshorne (Gerrit)

unread,

Apr 16, 2026, 4:28:28 AM (3 days ago) Apr 16

to Ian Kilpatrick, Anders Hartvoll Ruud, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, zol...@webkit.org

Attention needed from Ian Kilpatrick

Morten Stenshorne voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Ian Kilpatrick

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Ian Kilpatrick (Gerrit)

unread,

Apr 16, 2026, 10:02:58 AM (2 days ago) Apr 16

to Morten Stenshorne, Anders Hartvoll Ruud, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, zol...@webkit.org

Ian Kilpatrick voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Apr 16, 2026, 10:11:13 AM (2 days ago) Apr 16

to Ian Kilpatrick, Morten Stenshorne, Anders Hartvoll Ruud, android-bu...@system.gserviceaccount.com, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, blink-revie...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, zol...@webkit.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[flex-balance] Add flex-line-count: <integer>

This implements most of the resolution in:
https://github.com/w3c/csswg-drafts/issues/13414

Remove the min-line-count logic from flex-wrap, and instead shifts it to
a new property flex-line-count.

Should be behind the flag: FlexWrapBalance

Adjusts the tests as appropriate.

Bug: 498645659

Change-Id: I9d8041a77c42580692367ac68fcf6f3d586f3da5

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7766770

Reviewed-by: Morten Stenshorne <mste...@chromium.org>

Commit-Queue: Ian Kilpatrick <ikilp...@chromium.org>

Reviewed-by: Anders Hartvoll Ruud <and...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1615817}

Files:

M third_party/blink/public/mojom/use_counter/metrics/css_property_id.mojom
M third_party/blink/renderer/build/scripts/core/css/css_properties.py
M third_party/blink/renderer/build/scripts/core/style/make_computed_style_base.py
M third_party/blink/renderer/core/css/css_properties.json5
M third_party/blink/renderer/core/css/css_property_equality.cc
M third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc
M third_party/blink/renderer/core/css/resolver/style_builder_converter.cc
M third_party/blink/renderer/core/layout/flex/flex_layout_algorithm.cc
M third_party/blink/renderer/core/style/computed_style.h
M third_party/blink/renderer/core/style/style_flex_wrap_data.h
M third_party/blink/web_tests/external/wpt/css/cssom/getComputedStyle-pseudo-expected.txt
M third_party/blink/web_tests/external/wpt/css/cssom/getComputedStyle-pseudo-picker-expected.txt
M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-listing-expected.txt
M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
M third_party/blink/web_tests/platform/linux/virtual/cssom-getcomputedstyle-pseudo-no-colon-disabled/external/wpt/css/cssom/getComputedStyle-pseudo-expected.txt
M third_party/blink/web_tests/svg/css/getComputedStyle-listing-expected.txt
M third_party/blink/web_tests/webexposed/css-properties-as-js-properties-expected.txt
M third_party/blink/web_tests/webexposed/css-property-listing-expected.txt
M third_party/blink/web_tests/wpt_internal/css/css-flexbox/balance/balance-available-size-001.html
M third_party/blink/web_tests/wpt_internal/css/css-flexbox/balance/balance-available-size-002.html
M third_party/blink/web_tests/wpt_internal/css/css-flexbox/balance/balance-min-line-count-001.html
M third_party/blink/web_tests/wpt_internal/css/css-flexbox/balance/balance-min-line-count-002.html
M third_party/blink/web_tests/wpt_internal/css/css-flexbox/balance/balance-min-line-count-003.html
M third_party/blink/web_tests/wpt_internal/css/css-flexbox/balance/balance-min-line-count-004.html
M third_party/blink/web_tests/wpt_internal/css/css-flexbox/balance/balance-min-line-count-005.html
A third_party/blink/web_tests/wpt_internal/css/css-flexbox/balance/flex-line-count-computed.html
A third_party/blink/web_tests/wpt_internal/css/css-flexbox/balance/flex-line-count-invalid.html
A third_party/blink/web_tests/wpt_internal/css/css-flexbox/balance/flex-line-count-valid.html
M third_party/blink/web_tests/wpt_internal/css/css-flexbox/balance/flex-wrap-computed.html
M third_party/blink/web_tests/wpt_internal/css/css-flexbox/balance/flex-wrap-valid.html
M tools/metrics/histograms/metadata/blink/enums.xml

Change size: M

Delta: 31 files changed, 110 insertions(+), 81 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Morten Stenshorne, +1 by Anders Hartvoll Ruud

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[flex-balance] Add flex-line-count: <integer> [chromium/src : main]

Ian Kilpatrick (Gerrit)

New activity on the change

Related details

Anders Hartvoll Ruud (Gerrit)

Anders Hartvoll Ruud voted Code-Review+1

Related details

Morten Stenshorne (Gerrit)

Morten Stenshorne voted Code-Review+1

Related details

Ian Kilpatrick (Gerrit)

Ian Kilpatrick voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information