Felipe Erias (Gerrit)

unread,

May 8, 2026, 7:31:50 AM (7 days ago) May 8

to Chromium LUCI CQ, chromium...@chromium.org, Menard, Alexis, android-bu...@system.gserviceaccount.com, blink-rev...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org

Felipe Erias abandoned this change.

View Change

Abandoned

Replaced by https://chromium-review.googlesource.com/c/chromium/src/+/7832427

Felipe Erias abandoned this change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Rune Lillesveen (Gerrit)

unread,

May 8, 2026, 8:43:03 AM (7 days ago) May 8

to Felipe Erias, Rune Lillesveen, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Felipe Erias

Rune Lillesveen added 1 comment

Commit Message

Line 27, Patchset 1 (Latest):Bug: 507904199

Rune Lillesveen . unresolved

I split this out into issue 510840009.

Open in Gerrit

Related details

Attention is currently required from:

Felipe Erias

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Felipe Erias (Gerrit)

unread,

May 10, 2026, 9:55:37 PM (4 days ago) May 10

to Daniil Sakhapov, Rune Lillesveen, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Daniil Sakhapov and Rune Lillesveen

Felipe Erias added 2 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Felipe Erias . resolved

Hello,

This CL fixes several Interop failures related to the computed values of counter-increment, counter-reset, and counter-set

Thank you for your review.

Best regards,
Felipe

Commit Message

Line 27, Patchset 1:Bug: 507904199

Rune Lillesveen . resolved

I split this out into issue 510840009.

Felipe Erias

Thank you. I have assigned that bug to myself and updated the commit message here. Would it be possible for you to review the CL?

Open in Gerrit

Related details

Attention is currently required from:

Daniil Sakhapov
Rune Lillesveen

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Daniil Sakhapov (Gerrit)

unread,

May 11, 2026, 5:19:51 AM (4 days ago) May 11

to Felipe Erias, Rune Lillesveen, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Felipe Erias and Rune Lillesveen

Daniil Sakhapov voted and added 2 comments

Votes added by Daniil Sakhapov

Code-Review

+1

2 comments

File third_party/blink/renderer/core/css/properties/computed_style_utils.cc

Line 3543, Patchset 2 (Latest): break;

Daniil Sakhapov . unresolved

nit: let's add default: NOTREACHED()

File third_party/blink/renderer/core/style/counter_directives.h

Line 155, Patchset 2 (Latest): return base::WrapUnique(new CounterPropertyList(*this));

Daniil Sakhapov . unresolved

optional nit: `return std::make_unique<CounterPropertyList>(*this);`
and below if you feel like

Open in Gerrit

Related details

Attention is currently required from:

Felipe Erias
Rune Lillesveen

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Rune Lillesveen (Gerrit)

unread,

May 11, 2026, 5:23:36 AM (4 days ago) May 11

to Felipe Erias, Daniil Sakhapov, Rune Lillesveen, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Felipe Erias

Rune Lillesveen added 1 comment

File third_party/blink/renderer/core/css/properties/computed_style_utils.cc

Line 3543, Patchset 2 (Latest): break;

Daniil Sakhapov . resolved

nit: let's add default: NOTREACHED()

Rune Lillesveen

That should not be necessary since missing cases without a default would result in compilation error.

Open in Gerrit

Related details

Attention is currently required from:

Felipe Erias

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Rune Lillesveen (Gerrit)

unread,

May 11, 2026, 5:24:55 AM (4 days ago) May 11

to Felipe Erias, Rune Lillesveen, Daniil Sakhapov, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Felipe Erias

Rune Lillesveen voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Felipe Erias

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Felipe Erias (Gerrit)

unread,

May 11, 2026, 9:58:44 PM (3 days ago) May 11

to Rune Lillesveen, Daniil Sakhapov, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Daniil Sakhapov and Rune Lillesveen

Felipe Erias added 2 comments

File third_party/blink/renderer/core/css/properties/computed_style_utils.cc

Line 3543, Patchset 2: break;

Daniil Sakhapov . resolved

nit: let's add default: NOTREACHED()

Rune Lillesveen

That should not be necessary since missing cases without a default would result in compilation error.

Felipe Erias

Done.

File third_party/blink/renderer/core/style/counter_directives.h

Line 155, Patchset 2: return base::WrapUnique(new CounterPropertyList(*this));

Daniil Sakhapov . resolved

optional nit: `return std::make_unique<CounterPropertyList>(*this);`
and below if you feel like

Felipe Erias

Thank you, I have updated the CL as suggested.

Open in Gerrit

Related details

Attention is currently required from:

Daniil Sakhapov
Rune Lillesveen

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Rune Lillesveen (Gerrit)

unread,

May 12, 2026, 5:18:50 AM (3 days ago) May 12

to Felipe Erias, Rune Lillesveen, Daniil Sakhapov, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Daniil Sakhapov and Felipe Erias

Rune Lillesveen added 1 comment

File third_party/blink/renderer/core/css/properties/computed_style_utils.cc

Line 3543, Patchset 2: break;

Daniil Sakhapov . unresolved

nit: let's add default: NOTREACHED()

Rune Lillesveen

That should not be necessary since missing cases without a default would result in compilation error.

Felipe Erias

Done.

Rune Lillesveen

I don't think this should be added.

Open in Gerrit

Related details

Attention is currently required from:

Daniil Sakhapov
Felipe Erias

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Felipe Erias (Gerrit)

unread,

May 13, 2026, 6:17:43 AM (2 days ago) May 13

to Rune Lillesveen, Daniil Sakhapov, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Daniil Sakhapov and Rune Lillesveen

Felipe Erias added 1 comment

File third_party/blink/renderer/core/css/properties/computed_style_utils.cc

Line 3543, Patchset 2: break;

Daniil Sakhapov . unresolved

nit: let's add default: NOTREACHED()

Rune Lillesveen

That should not be necessary since missing cases without a default would result in compilation error.

Felipe Erias

Done.

Rune Lillesveen

I don't think this should be added.

Felipe Erias

Removed.

Sorry, I didn't see your earlier comment before I updated the CL.

Open in Gerrit

Related details

Attention is currently required from:

Daniil Sakhapov
Rune Lillesveen

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Rune Lillesveen (Gerrit)

unread,

May 13, 2026, 7:14:29 AM (2 days ago) May 13

to Felipe Erias, Rune Lillesveen, Daniil Sakhapov, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Daniil Sakhapov and Felipe Erias

Rune Lillesveen voted and added 1 comment

Votes added by Rune Lillesveen

Code-Review

+1

1 comment

File third_party/blink/renderer/core/css/properties/computed_style_utils.cc

Line 3543, Patchset 2: break;

Daniil Sakhapov . resolved

nit: let's add default: NOTREACHED()

Rune Lillesveen

That should not be necessary since missing cases without a default would result in compilation error.

Felipe Erias

Done.

Rune Lillesveen

I don't think this should be added.

Felipe Erias

Removed.
Sorry, I didn't see your earlier comment before I updated the CL.

Rune Lillesveen

Acknowledged

Open in Gerrit

Related details

Attention is currently required from:

Daniil Sakhapov
Felipe Erias

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Daniil Sakhapov (Gerrit)

unread,

May 13, 2026, 7:34:18 AM (2 days ago) May 13

to Felipe Erias, Rune Lillesveen, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Felipe Erias

Daniil Sakhapov voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Felipe Erias

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Felipe Erias (Gerrit)

unread,

May 13, 2026, 8:54:07 PM (2 days ago) May 13

to Daniil Sakhapov, Rune Lillesveen, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Felipe Erias voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

May 13, 2026, 11:26:47 PM (2 days ago) May 13

to Felipe Erias, Daniil Sakhapov, Rune Lillesveen, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Preserve order and duplicates in counter property computed values

The computed values of counter-increment, counter-reset, and counter-set
must serialize as the source list, including order and duplicates.

Blink served getComputedStyle() from CounterDirectiveMap, which is keyed
by counter name and collapses both.

Add a parallel CounterPropertyList per longhand that stores the complete
list, and serialize getComputedStyle() from it. CounterDirectiveMap
remains the collapsed view used by layout.

See: https://drafts.csswg.org/css-lists-3/

Tests:
  - external/wpt/css/css-lists/parsing/counter-increment-computed.html
  - external/wpt/css/css-lists/parsing/counter-reset-computed.html
  - external/wpt/css/css-lists/parsing/counter-set-computed.html

Bug: 510840009, 507904199

Change-Id: If575a53a6390b532a088e96de1a552dace423462

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7832427

Reviewed-by: Daniil Sakhapov <sakh...@chromium.org>

Reviewed-by: Rune Lillesveen <fut...@chromium.org>

Commit-Queue: Felipe Erias <felip...@igalia.com>

Cr-Commit-Position: refs/heads/main@{#1630411}

Files:

M third_party/blink/renderer/build/scripts/core/css/properties/templates/style_builder_functions.tmpl
M third_party/blink/renderer/core/css/css_properties.json5
M third_party/blink/renderer/core/css/properties/computed_style_utils.cc
M third_party/blink/renderer/core/style/computed_style_extra_fields.json5
M third_party/blink/renderer/core/style/counter_directives.h
D third_party/blink/web_tests/external/wpt/css/css-lists/parsing/counter-increment-computed-expected.txt
D third_party/blink/web_tests/external/wpt/css/css-lists/parsing/counter-reset-computed-expected.txt
D third_party/blink/web_tests/external/wpt/css/css-lists/parsing/counter-set-computed-expected.txt

Change size: M

Delta: 8 files changed, 114 insertions(+), 102 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Rune Lillesveen, +1 by Daniil Sakhapov

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Preserve order and duplicates in counter property computed values [chromium/src : main]

Felipe Erias (Gerrit)

Felipe Erias abandoned this change

Related details

Rune Lillesveen (Gerrit)

Rune Lillesveen added 1 comment

Related details

Felipe Erias (Gerrit)

Felipe Erias added 2 comments

Related details

Daniil Sakhapov (Gerrit)

Daniil Sakhapov voted and added 2 comments

Votes added by Daniil Sakhapov

2 comments

Related details

Rune Lillesveen (Gerrit)

Rune Lillesveen added 1 comment

Related details

Rune Lillesveen (Gerrit)

Rune Lillesveen voted Code-Review+1

Related details

Felipe Erias (Gerrit)

Felipe Erias added 2 comments

Related details

Rune Lillesveen (Gerrit)

Rune Lillesveen added 1 comment

Related details

Felipe Erias (Gerrit)

Felipe Erias added 1 comment

Related details

Rune Lillesveen (Gerrit)

Rune Lillesveen voted and added 1 comment

Votes added by Rune Lillesveen

1 comment

Related details

Daniil Sakhapov (Gerrit)

Daniil Sakhapov voted Code-Review+1

Related details

Felipe Erias (Gerrit)

Felipe Erias voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information