[animation-trigger] Rename entry range to activation range [chromium/src : main]

0 views
Skip to first unread message

David Awogbemila (Gerrit)

unread,
Feb 6, 2026, 9:41:58 AM (7 days ago) Feb 6
to Vladimir Levin, Kevin Ellis, Chromium LUCI CQ, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Kevin Ellis and Vladimir Levin

David Awogbemila added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
David Awogbemila . resolved

+vmpstr for webexposed/

Open in Gerrit

Related details

Attention is currently required from:
  • Kevin Ellis
  • Vladimir Levin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iafb735182cacb113da83fdbb4d158d2b3813e1f1
Gerrit-Change-Number: 7541794
Gerrit-PatchSet: 3
Gerrit-Owner: David Awogbemila <awogb...@chromium.org>
Gerrit-Reviewer: David Awogbemila <awogb...@chromium.org>
Gerrit-Reviewer: Kevin Ellis <kev...@chromium.org>
Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-Attention: Kevin Ellis <kev...@chromium.org>
Gerrit-Attention: Vladimir Levin <vmp...@chromium.org>
Gerrit-Comment-Date: Fri, 06 Feb 2026 14:41:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kevin Ellis (Gerrit)

unread,
Feb 6, 2026, 10:24:47 AM (7 days ago) Feb 6
to David Awogbemila, Vladimir Levin, Chromium LUCI CQ, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from David Awogbemila and Vladimir Levin

Kevin Ellis voted and added 1 comment

Votes added by Kevin Ellis

Code-Review+1

1 comment

Patchset-level comments
Kevin Ellis . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • David Awogbemila
  • Vladimir Levin
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iafb735182cacb113da83fdbb4d158d2b3813e1f1
    Gerrit-Change-Number: 7541794
    Gerrit-PatchSet: 3
    Gerrit-Owner: David Awogbemila <awogb...@chromium.org>
    Gerrit-Reviewer: David Awogbemila <awogb...@chromium.org>
    Gerrit-Reviewer: Kevin Ellis <kev...@chromium.org>
    Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Attention: David Awogbemila <awogb...@chromium.org>
    Gerrit-Attention: Vladimir Levin <vmp...@chromium.org>
    Gerrit-Comment-Date: Fri, 06 Feb 2026 15:24:39 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Vladimir Levin (Gerrit)

    unread,
    Feb 6, 2026, 10:45:07 AM (7 days ago) Feb 6
    to David Awogbemila, Kevin Ellis, Chromium LUCI CQ, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
    Attention needed from David Awogbemila

    Vladimir Levin voted and added 1 comment

    Votes added by Vladimir Levin

    Code-Review+1

    1 comment

    Patchset-level comments
    Vladimir Levin . resolved

    lgtm

    Open in Gerrit

    Related details

    Attention is currently required from:
    • David Awogbemila
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iafb735182cacb113da83fdbb4d158d2b3813e1f1
    Gerrit-Change-Number: 7541794
    Gerrit-PatchSet: 3
    Gerrit-Owner: David Awogbemila <awogb...@chromium.org>
    Gerrit-Reviewer: David Awogbemila <awogb...@chromium.org>
    Gerrit-Reviewer: Kevin Ellis <kev...@chromium.org>
    Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Attention: David Awogbemila <awogb...@chromium.org>
    Gerrit-Comment-Date: Fri, 06 Feb 2026 15:45:01 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    David Awogbemila (Gerrit)

    unread,
    Feb 6, 2026, 10:53:52 AM (7 days ago) Feb 6
    to Vladimir Levin, Kevin Ellis, Chromium LUCI CQ, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

    David Awogbemila voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iafb735182cacb113da83fdbb4d158d2b3813e1f1
    Gerrit-Change-Number: 7541794
    Gerrit-PatchSet: 3
    Gerrit-Owner: David Awogbemila <awogb...@chromium.org>
    Gerrit-Reviewer: David Awogbemila <awogb...@chromium.org>
    Gerrit-Reviewer: Kevin Ellis <kev...@chromium.org>
    Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Comment-Date: Fri, 06 Feb 2026 15:53:47 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Feb 6, 2026, 11:31:58 AM (7 days ago) Feb 6
    to David Awogbemila, Vladimir Levin, Kevin Ellis, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [animation-trigger] Rename entry range to activation range

    The working group resolved[1] to rename the entry range to activation
    range.

    [1] https://github.com/w3c/csswg-drafts/issues/13307#issuecomment-3812914602
    Bug: 390314945
    Change-Id: Iafb735182cacb113da83fdbb4d158d2b3813e1f1
    Reviewed-by: Kevin Ellis <kev...@chromium.org>
    Reviewed-by: Vladimir Levin <vmp...@chromium.org>
    Commit-Queue: David Awogbemila <awogb...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1580877}
    Files:
    • M third_party/blink/public/mojom/use_counter/metrics/css_property_id.mojom
    • M third_party/blink/renderer/core/animation/css/css_animation_data.cc
    • M third_party/blink/renderer/core/animation/css/css_animation_data.h
    • M third_party/blink/renderer/core/animation/css/css_animations.cc
    • M third_party/blink/renderer/core/css/css_properties.json5
    • M third_party/blink/renderer/core/css/css_property_equality.cc
    • M third_party/blink/renderer/core/css/properties/computed_style_utils.cc
    • M third_party/blink/renderer/core/css/properties/computed_style_utils.h
    • M third_party/blink/renderer/core/css/properties/css_parsing_utils.cc
    • M third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc
    • M third_party/blink/renderer/core/css/properties/shorthands/shorthands_custom.cc
    • M third_party/blink/renderer/core/css/resolver/css_to_style_map.cc
    • M third_party/blink/renderer/core/css/resolver/css_to_style_map.h
    • M third_party/blink/renderer/core/css/style_property_serializer.cc
    • M third_party/blink/renderer/core/css/style_property_serializer.h
    • M third_party/blink/web_tests/external/wpt/scroll-animations/animation-trigger/parsing/timeline-trigger-entry-range-end-computed.tentative.html
    • M third_party/blink/web_tests/external/wpt/scroll-animations/animation-trigger/parsing/timeline-trigger-entry-range-end-invalid.tentative.html
    • M third_party/blink/web_tests/external/wpt/scroll-animations/animation-trigger/parsing/timeline-trigger-entry-range-end-valid.tentative.html
    • M third_party/blink/web_tests/external/wpt/scroll-animations/animation-trigger/parsing/timeline-trigger-entry-range-shorthand.tentative.html
    • M third_party/blink/web_tests/external/wpt/scroll-animations/animation-trigger/parsing/timeline-trigger-entry-range-start-computed.tentative.html
    • M third_party/blink/web_tests/external/wpt/scroll-animations/animation-trigger/parsing/timeline-trigger-entry-range-start-invalid.tentative.html
    • M third_party/blink/web_tests/external/wpt/scroll-animations/animation-trigger/parsing/timeline-trigger-entry-range-start-valid.tentative.html
    • M third_party/blink/web_tests/external/wpt/scroll-animations/animation-trigger/parsing/timeline-trigger-shorthand.tentative.html
    • M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-listing-expected.txt
    • M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
    • M third_party/blink/web_tests/svg/css/getComputedStyle-listing-expected.txt
    • M third_party/blink/web_tests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt
    • M third_party/blink/web_tests/virtual/stable/webexposed/css-property-listing-expected.txt
    • M third_party/blink/web_tests/webexposed/css-properties-as-js-properties-expected.txt
    • M third_party/blink/web_tests/webexposed/css-property-listing-expected.txt
    • M tools/metrics/histograms/metadata/blink/enums.xml
    Change size: L
    Delta: 31 files changed, 449 insertions(+), 430 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Kevin Ellis, +1 by Vladimir Levin
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iafb735182cacb113da83fdbb4d158d2b3813e1f1
    Gerrit-Change-Number: 7541794
    Gerrit-PatchSet: 4
    Gerrit-Owner: David Awogbemila <awogb...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: David Awogbemila <awogb...@chromium.org>
    Gerrit-Reviewer: Kevin Ellis <kev...@chromium.org>
    Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
    open
    diffy
    satisfied_requirement

    Blink W3C Test Autoroller (Gerrit)

    unread,
    Feb 6, 2026, 12:40:26 PM (7 days ago) Feb 6
    to David Awogbemila, Chromium LUCI CQ, Vladimir Levin, Kevin Ellis, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

    Message from Blink W3C Test Autoroller

    The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/57617

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iafb735182cacb113da83fdbb4d158d2b3813e1f1
    Gerrit-Change-Number: 7541794
    Gerrit-PatchSet: 4
    Gerrit-Owner: David Awogbemila <awogb...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: David Awogbemila <awogb...@chromium.org>
    Gerrit-Reviewer: Kevin Ellis <kev...@chromium.org>
    Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Comment-Date: Fri, 06 Feb 2026 17:40:19 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages