Kevin Ellis (Gerrit)

unread,

Jan 21, 2026, 9:24:01 AM (2 days ago) Jan 21

to Chromium LUCI CQ, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Kevin Ellis added 2 comments

File third_party/blink/renderer/core/css/resolver/style_adjuster.cc

Line 1202, Patchset 5 (Parent): (builder.Contain() & kContainsViewTransition) || is_transition_scope) {

Kevin Ellis . resolved

Does not appear to be needed any longer. Having a vt-name or being a vt-participant is enough to force a stacking context. See HasStackingGroupingProperty in computed_style.h. This code was introduce prior to streamlining style and layout for VTs.

File third_party/blink/renderer/core/view_transition/view_transition_supplement.cc

Line 289, Patchset 6 (Parent): LayoutObject* layout_object = scope->GetLayoutObject();

Kevin Ellis . resolved

Needed prior to standardization of style and layout for view-transitions. Now obsolete.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kevin Ellis (Gerrit)

unread,

Jan 21, 2026, 10:46:07 AM (2 days ago) Jan 21

to Rune Lillesveen, Chromium LUCI CQ, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Attention needed from Rune Lillesveen

Kevin Ellis added 1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Kevin Ellis . resolved

Please take a look.

Open in Gerrit

Related details

Attention is currently required from:

Rune Lillesveen

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Rune Lillesveen (Gerrit)

unread,

Jan 21, 2026, 1:49:12 PM (2 days ago) Jan 21

to Kevin Ellis, Rune Lillesveen, Chromium LUCI CQ, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Attention needed from Kevin Ellis

Rune Lillesveen voted and added 2 comments

Votes added by Rune Lillesveen

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Rune Lillesveen . resolved

lgtm with the field_group added

File third_party/blink/renderer/core/css/css_properties.json5

Line 6297, Patchset 7 (Latest): name: "view-transition-scope",

Rune Lillesveen . unresolved

I think you want `field_group: "*",`, otherwise it's stored directly on ComputedStyle which we use for the most performance-sensitive properties. We should possibly make `"*"` the default and offer `field_group: "root"` or something.

Open in Gerrit

Related details

Attention is currently required from:

Kevin Ellis

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kevin Ellis (Gerrit)

unread,

Jan 21, 2026, 2:52:10 PM (2 days ago) Jan 21

to Vladimir Levin, Rune Lillesveen, Chromium LUCI CQ, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Attention needed from Kevin Ellis and Vladimir Levin

Kevin Ellis voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Kevin Ellis
Vladimir Levin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kevin Ellis (Gerrit)

unread,

Jan 21, 2026, 2:59:34 PM (2 days ago) Jan 21

to Vladimir Levin, Rune Lillesveen, Chromium LUCI CQ, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Attention needed from Vladimir Levin

Kevin Ellis added 1 comment

File third_party/blink/renderer/core/css/css_properties.json5

Line 6297, Patchset 7: name: "view-transition-scope",

Rune Lillesveen . resolved

I think you want `field_group: "*",`, otherwise it's stored directly on ComputedStyle which we use for the most performance-sensitive properties. We should possibly make `"*"` the default and offer `field_group: "root"` or something.

Kevin Ellis

Done

Open in Gerrit

Related details

Attention is currently required from:

Vladimir Levin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Blink W3C Test Autoroller (Gerrit)

unread,

Jan 21, 2026, 3:14:27 PM (2 days ago) Jan 21

to Kevin Ellis, Vladimir Levin, Rune Lillesveen, Chromium LUCI CQ, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Attention needed from Vladimir Levin

Message from Blink W3C Test Autoroller

Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/57284.

When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

Open in Gerrit

Related details

Attention is currently required from:

Vladimir Levin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Vladimir Levin (Gerrit)

unread,

Jan 22, 2026, 10:56:54 AM (yesterday) Jan 22

to Kevin Ellis, Blink W3C Test Autoroller, Rune Lillesveen, Chromium LUCI CQ, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Attention needed from Kevin Ellis

Vladimir Levin voted and added 1 comment

Votes added by Vladimir Levin

Code-Review

+1

1 comment

File third_party/blink/renderer/core/view_transition/view_transition_style_tracker.cc

Line 740, Patchset 8 (Latest): (root_style.ViewTransitionScope() == EViewTransitionScope::kAuto)) {

Vladimir Levin . unresolved

We might want to add a TODO/bug here as well to make sure we can handle view-transition-scope: auto on display: contents elements

Open in Gerrit

Related details

Attention is currently required from:

Kevin Ellis

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kevin Ellis (Gerrit)

unread,

11:31 AM (1 hour ago) 11:31 AM

to Vladimir Levin, Blink W3C Test Autoroller, Rune Lillesveen, Chromium LUCI CQ, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Kevin Ellis added 1 comment

File third_party/blink/renderer/core/view_transition/view_transition_style_tracker.cc

Line 740, Patchset 8: (root_style.ViewTransitionScope() == EViewTransitionScope::kAuto)) {

Vladimir Levin . resolved

We might want to add a TODO/bug here as well to make sure we can handle view-transition-scope: auto on display: contents elements

Kevin Ellis

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Kevin Ellis (Gerrit)

unread,

12:30 PM (20 minutes ago) 12:30 PM

to Vladimir Levin, Blink W3C Test Autoroller, Rune Lillesveen, Chromium LUCI CQ, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Kevin Ellis voted Commit-Queue+2

Commit-Queue

+2

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

12:35 PM (15 minutes ago) 12:35 PM

to Kevin Ellis, Vladimir Levin, Blink W3C Test Autoroller, Rune Lillesveen, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

8 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: third_party/blink/renderer/core/view_transition/view_transition_style_tracker.cc
Insertions: 2, Deletions: 0.

The diff is too large to show. Please review the diff.
```

Change information

Commit message:

Contain: v-t --> view-transtion-scope: auto

Though still pending CSSWG resolution, this is our latest
recommendation for handling of of name discovery in a subtree.


Bug: 476025617
Change-Id: I7ef4e97ce5801dc78ac7a5ebb63d07606c3bb6f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7493821
Commit-Queue: Kevin Ellis <kev...@chromium.org>
Reviewed-by: Rune Lillesveen <fut...@chromium.org>
Reviewed-by: Vladimir Levin <vmp...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1573754}

Files:

M third_party/blink/public/mojom/use_counter/metrics/css_property_id.mojom
M third_party/blink/renderer/core/css/css_identifier_value_mappings.h
M third_party/blink/renderer/core/css/css_properties.json5
M third_party/blink/renderer/core/css/css_property_equality.cc
M third_party/blink/renderer/core/css/css_value_keywords.json5
M third_party/blink/renderer/core/css/parser/css_parser_fast_paths.cc
M third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc
M third_party/blink/renderer/core/css/resolver/style_adjuster.cc
M third_party/blink/renderer/core/style/computed_style_constants.h
M third_party/blink/renderer/core/view_transition/view_transition_style_tracker.cc
M third_party/blink/renderer/core/view_transition/view_transition_supplement.cc
M third_party/blink/web_tests/external/wpt/css/css-contain/parsing/contain-invalid.html
D third_party/blink/web_tests/external/wpt/css/css-contain/parsing/contain-valid.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-view-transitions/scoped/callback-order.tentative.html
M third_party/blink/web_tests/external/wpt/css/css-view-transitions/scoped/nested-scope.html
R third_party/blink/web_tests/external/wpt/css/css-view-transitions/scoped/view-transtion-scope-name-discovery.html
M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-listing-expected.txt
M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
M third_party/blink/web_tests/svg/css/getComputedStyle-listing-expected.txt
M third_party/blink/web_tests/webexposed/css-properties-as-js-properties-expected.txt
M third_party/blink/web_tests/webexposed/css-property-listing-expected.txt
M tools/metrics/histograms/metadata/blink/enums.xml

Change size: M

Delta: 22 files changed, 59 insertions(+), 78 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Rune Lillesveen, +1 by Vladimir Levin

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Contain: v-t --> view-transtion-scope: auto [chromium/src : main]

Kevin Ellis (Gerrit)

Kevin Ellis added 2 comments

Related details

Kevin Ellis (Gerrit)

Kevin Ellis added 1 comment

Related details

Rune Lillesveen (Gerrit)

Rune Lillesveen voted and added 2 comments

Votes added by Rune Lillesveen

2 comments

Related details

Kevin Ellis (Gerrit)

Kevin Ellis voted Commit-Queue+1

Related details

Kevin Ellis (Gerrit)

Kevin Ellis added 1 comment

Related details

Blink W3C Test Autoroller (Gerrit)

Message from Blink W3C Test Autoroller

Related details

Vladimir Levin (Gerrit)

Vladimir Levin voted and added 1 comment

Votes added by Vladimir Levin

1 comment

Related details

Kevin Ellis (Gerrit)

Kevin Ellis added 1 comment

Related details

Kevin Ellis (Gerrit)

Kevin Ellis voted Commit-Queue+2

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

Change information