Enforce fast-path parsing for CSS "keyword" properties [chromium/src : main]
0 views
Skip to first unread message
Rune Lillesveen (Gerrit)
Jan 21, 2026, 8:27:22 AM (2 days ago) Jan 21
to Rune Lillesveen, Anders Hartvoll Ruud, Steinar H Gunderson, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Anders Hartvoll Ruud and Steinar H Gunderson
Rune Lillesveen added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Rune Lillesveen . unresolved
Does this look like a reasonable approach?
We could consider generate the "fast-path" keyword parser as well.
Related details
Attention is currently required from:
- Anders Hartvoll Ruud
- Steinar H Gunderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anders Hartvoll Ruud (Gerrit)
Jan 21, 2026, 8:36:05 AM (2 days ago) Jan 21
to Rune Lillesveen, Steinar H Gunderson, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Rune Lillesveen and Steinar H Gunderson
Anders Hartvoll Ruud voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Rune Lillesveen
- Steinar H Gunderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anders Hartvoll Ruud (Gerrit)
Jan 21, 2026, 8:37:43 AM (2 days ago) Jan 21
to Rune Lillesveen, Steinar H Gunderson, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Rune Lillesveen and Steinar H Gunderson
Anders Hartvoll Ruud added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Rune Lillesveen . resolved
Does this look like a reasonable approach?
We could consider generate the "fast-path" keyword parser as well.
Anders Hartvoll Ruud
We probably should generate that, yeah. If we do, it would be great if certain keywords would be allowed only given a certain runtime flag.
Related details
Attention is currently required from:
- Rune Lillesveen
- Steinar H Gunderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rune Lillesveen (Gerrit)
Jan 21, 2026, 8:46:54 AM (2 days ago) Jan 21
to Rune Lillesveen, Anders Hartvoll Ruud, Steinar H Gunderson, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Steinar H Gunderson
Rune Lillesveen voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Steinar H Gunderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rune Lillesveen (Gerrit)
Jan 21, 2026, 8:59:32 AM (2 days ago) Jan 21
to Rune Lillesveen, Chromium LUCI CQ, Anders Hartvoll Ruud, Steinar H Gunderson, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Steinar H Gunderson
Rune Lillesveen voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Steinar H Gunderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 21, 2026, 9:50:43 AM (2 days ago) Jan 21
to Rune Lillesveen, Anders Hartvoll Ruud, Steinar H Gunderson, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Enforce fast-path parsing for CSS "keyword" properties
Some simple keyword properties had a custom ParseSingleValue(). Make
sure that new properties use
CSSParserFastPaths::IsValidKeywordPropertyAndValue() instead of a custom
ParseSingleValue().
Provide a keyword_custom for the cases where we use the keyword template
but need custom parsing implementation.
Currently:
- The cursor property also parses and stores a set of urls and a hotspot
in the computed_style_extra_flags. Should probably not have been a
"keyword" in the first place.
- The ruby-position property does some use counting for currently
unsupported keywords.
Change-Id: I72e3b4818902aeab31e1acef4071d9b9215fe2e0
Reviewed-by: Anders Hartvoll Ruud <and...@chromium.org>
Commit-Queue: Rune Lillesveen <fut...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1572289}
Files:
- M third_party/blink/renderer/build/scripts/core/css/css_properties.py
- M third_party/blink/renderer/build/scripts/core/css/make_css_value_id_mappings.py
- M third_party/blink/renderer/build/scripts/core/style/make_computed_style_base.py
- M third_party/blink/renderer/build/scripts/core/style/templates/computed_style_base.h.tmpl
- M third_party/blink/renderer/build/scripts/core/style/templates/computed_style_initial_values.h.tmpl
- M third_party/blink/renderer/build/scripts/keyword_utils.py
- M third_party/blink/renderer/core/css/css_properties.json5
Change size: S
Delta: 7 files changed, 23 insertions(+), 11 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Anders Hartvoll Ruud
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages