SVG New Zoom: Scale path, offset-path and text-path geometry [chromium/src : main]
0 views
Skip to first unread message
Vinay Singh (Gerrit)
Jun 29, 2026, 4:50:29 AM (6 days ago) Jun 29
to Fredrik Söderquist, Divyansh Mangal, Virali Purbey, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org, zol...@webkit.org
Attention needed from Divyansh Mangal, Fredrik Söderquist and Virali Purbey
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Divyansh Mangal
- Fredrik Söderquist
- Virali Purbey
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fredrik Söderquist (Gerrit)
Jun 29, 2026, 8:00:54 AM (6 days ago) Jun 29
to Vinay Singh, Divyansh Mangal, Virali Purbey, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org, zol...@webkit.org
Attention needed from Divyansh Mangal, Vinay Singh and Virali Purbey
Fredrik Söderquist voted and added 2 comments![]( "Open in Gerrit")
Votes added by Fredrik Söderquist
| Code-Review | +1 |
2 comments
Patchset-level comments
File third_party/blink/renderer/core/svg/svg_path_element.cc
Line 162, Patchset 13 (Parent):
// We want the exact bounds.Fredrik Söderquist . unresolved
Don't remove this comment
Related details
Attention is currently required from:
- Divyansh Mangal
- Vinay Singh
- Virali Purbey
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vinay Singh (Gerrit)
Jun 30, 2026, 1:31:32 AM (5 days ago) Jun 30
to Fredrik Söderquist, Divyansh Mangal, Virali Purbey, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org, zol...@webkit.org
Attention needed from Divyansh Mangal, Fredrik Söderquist and Virali Purbey
Vinay Singh added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/svg/svg_path_element.cc
Line 162, Patchset 13 (Parent):
// We want the exact bounds.Fredrik Söderquist . resolved
Don't remove this comment
Attention is currently required from:
- Divyansh Mangal
- Fredrik Söderquist
- Virali Purbey
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fredrik Söderquist (Gerrit)
Jun 30, 2026, 8:55:29 AM (5 days ago) Jun 30
to Vinay Singh, Divyansh Mangal, Virali Purbey, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org, zol...@webkit.org
Attention needed from Divyansh Mangal, Vinay Singh and Virali Purbey
Fredrik Söderquist voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Divyansh Mangal
- Vinay Singh
- Virali Purbey
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vinay Singh (Gerrit)
Jul 3, 2026, 7:35:25 AM (2 days ago) Jul 3
to Fredrik Söderquist, Divyansh Mangal, Virali Purbey, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org, zol...@webkit.org
Attention needed from Divyansh Mangal and Virali Purbey
Vinay Singh voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Divyansh Mangal
- Virali Purbey
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 3, 2026, 8:32:56 AM (2 days ago) Jul 3
to Vinay Singh, Fredrik Söderquist, Divyansh Mangal, Virali Purbey, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org, zol...@webkit.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
16 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
SVG New Zoom: Scale path, offset-path and text-path geometry
Part of the SvgNewZoom migration (umbrella draft CL:7931148). Scales
`<path>`, `offset-path` and `text-path` geometry by zoom and adds the
unzoomed path accessors so they stay consistent with other shapes.
No-op while the flag is off.
Change-Id: Ie2ec95581eb6e18f24eb949ba5ce6c6541cf3587
Reviewed-by: Fredrik Söderquist <f...@opera.com>
Commit-Queue: Vinay Singh <vinay...@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1656511}
Files:
- M third_party/blink/renderer/core/layout/svg/layout_svg_text_path.cc
- M third_party/blink/renderer/core/style/computed_style.cc
- M third_party/blink/renderer/core/style/computed_style.h
- M third_party/blink/renderer/core/style/style_path.cc
- M third_party/blink/renderer/core/style/style_path.h
- M third_party/blink/renderer/core/svg/svg_path_element.cc
- M third_party/blink/renderer/core/svg/svg_path_element.h
Change size: M
Delta: 7 files changed, 37 insertions(+), 14 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Fredrik Söderquist
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages