Remove the BasicShapeCenterCoordinate type [chromium/src : main]

0 views
Skip to first unread message

Fredrik Söderquist (Gerrit)

unread,
Jul 1, 2026, 8:59:24 AM (4 days ago) Jul 1
to Anders Hartvoll Ruud, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, Xida Chen, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Anders Hartvoll Ruud

Fredrik Söderquist voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Anders Hartvoll Ruud
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I35791ea4f63a1f544189d453c5f67e7dcb4a3bfb
Gerrit-Change-Number: 8027454
Gerrit-PatchSet: 1
Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Xida Chen <xida...@chromium.org>
Gerrit-Attention: Anders Hartvoll Ruud <and...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Jul 2026 12:59:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Anders Hartvoll Ruud (Gerrit)

unread,
Jul 2, 2026, 5:07:19 AM (3 days ago) Jul 2
to Fredrik Söderquist, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, Xida Chen, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Fredrik Söderquist

Anders Hartvoll Ruud voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I35791ea4f63a1f544189d453c5f67e7dcb4a3bfb
    Gerrit-Change-Number: 8027454
    Gerrit-PatchSet: 1
    Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-CC: Xida Chen <xida...@chromium.org>
    Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
    Gerrit-Comment-Date: Thu, 02 Jul 2026 09:07:02 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jul 2, 2026, 5:38:40 AM (3 days ago) Jul 2
    to Fredrik Söderquist, Anders Hartvoll Ruud, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, Xida Chen, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Remove the BasicShapeCenterCoordinate type

    The direction for all BasicShapeCenterCoordinates are now kTopLeft,
    which makes the stored `direction_` useless, and the `computed_length_`
    always equal to `length_`. Thus this class can be replaced by just a
    plain Length.

    Do that, and get rid of the ValueForCenterCoordinate() helper and
    convert the ConvertToCenterCoordinate() helper to use
    StyleBuilderConverter::ConvertPositionLength() which performs the same
    operation.
    Bug: 529841773
    Change-Id: I35791ea4f63a1f544189d453c5f67e7dcb4a3bfb
    Auto-Submit: Fredrik Söderquist <f...@opera.com>
    Commit-Queue: Anders Hartvoll Ruud <and...@chromium.org>
    Reviewed-by: Anders Hartvoll Ruud <and...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1655973}
    Files:
    • M third_party/blink/renderer/core/animation/basic_shape_interpolation_functions.cc
    • M third_party/blink/renderer/core/animation/css_ray_interpolation_type.cc
    • M third_party/blink/renderer/core/css/basic_shape_functions.cc
    • M third_party/blink/renderer/core/style/basic_shapes.cc
    • M third_party/blink/renderer/core/style/basic_shapes.h
    • M third_party/blink/renderer/core/style/style_ray.cc
    • M third_party/blink/renderer/core/style/style_ray.h
    • M third_party/blink/renderer/modules/csspaint/nativepaint/clip_path_paint_definition_test.cc
    Change size: M
    Delta: 8 files changed, 70 insertions(+), 160 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Anders Hartvoll Ruud
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I35791ea4f63a1f544189d453c5f67e7dcb4a3bfb
    Gerrit-Change-Number: 8027454
    Gerrit-PatchSet: 2
    Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages