[anchor] Stop using unsafe alignment for position-area. [chromium/src : main]

0 views
Skip to first unread message

Ian Kilpatrick (Gerrit)

unread,
Aug 28, 2025, 7:12:23 PM (12 days ago) Aug 28
to Vladimir Levin, Morten Stenshorne, Alexis Menard, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
Attention needed from Morten Stenshorne and Vladimir Levin

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Morten Stenshorne
  • Vladimir Levin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3a3fa613064b2c1b494845341a7edbd73e0401b8
Gerrit-Change-Number: 6898171
Gerrit-PatchSet: 2
Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-Attention: Vladimir Levin <vmp...@chromium.org>
Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
Gerrit-Comment-Date: Thu, 28 Aug 2025 23:12:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Morten Stenshorne (Gerrit)

unread,
Aug 29, 2025, 2:29:46 AM (12 days ago) Aug 29
to Ian Kilpatrick, Vladimir Levin, Alexis Menard, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
Attention needed from Ian Kilpatrick and Vladimir Levin

Morten Stenshorne voted and added 1 comment

Votes added by Morten Stenshorne

Code-Review+1

1 comment

Commit Message
Line 10, Patchset 2 (Latest):the anchor. This is now the desired behaviour - stop doing that.
Morten Stenshorne . unresolved

As in "Overlapping"?

"Stop doing that, since overlapping is now the desired behavior"?

Open in Gerrit

Related details

Attention is currently required from:
  • Ian Kilpatrick
  • Vladimir Levin
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3a3fa613064b2c1b494845341a7edbd73e0401b8
    Gerrit-Change-Number: 6898171
    Gerrit-PatchSet: 2
    Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Attention: Vladimir Levin <vmp...@chromium.org>
    Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Comment-Date: Fri, 29 Aug 2025 06:29:28 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Ian Kilpatrick (Gerrit)

    unread,
    Aug 29, 2025, 2:22:52 PM (11 days ago) Aug 29
    to Morten Stenshorne, Vladimir Levin, Alexis Menard, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
    Attention needed from Vladimir Levin

    Ian Kilpatrick added 1 comment

    Commit Message
    Line 10, Patchset 2:the anchor. This is now the desired behaviour - stop doing that.
    Morten Stenshorne . resolved

    As in "Overlapping"?

    "Stop doing that, since overlapping is now the desired behavior"?

    Ian Kilpatrick

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Vladimir Levin
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3a3fa613064b2c1b494845341a7edbd73e0401b8
    Gerrit-Change-Number: 6898171
    Gerrit-PatchSet: 3
    Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Attention: Vladimir Levin <vmp...@chromium.org>
    Gerrit-Comment-Date: Fri, 29 Aug 2025 18:22:41 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Morten Stenshorne <mste...@chromium.org>
    satisfied_requirement
    open
    diffy

    Ian Kilpatrick (Gerrit)

    unread,
    Aug 29, 2025, 4:37:27 PM (11 days ago) Aug 29
    to Morten Stenshorne, Vladimir Levin, Alexis Menard, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
    Attention needed from Morten Stenshorne and Vladimir Levin

    Ian Kilpatrick voted and added 1 comment

    Votes added by Ian Kilpatrick

    Auto-Submit+1
    Commit-Queue+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 4 (Latest):
    Ian Kilpatrick . resolved

    PTAL - shakes fist a rebase.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Morten Stenshorne
    • Vladimir Levin
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I3a3fa613064b2c1b494845341a7edbd73e0401b8
      Gerrit-Change-Number: 6898171
      Gerrit-PatchSet: 4
      Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
      Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
      Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
      Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
      Gerrit-CC: Alexis Menard <alexis...@intel.com>
      Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
      Gerrit-Attention: Vladimir Levin <vmp...@chromium.org>
      Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
      Gerrit-Comment-Date: Fri, 29 Aug 2025 20:37:16 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      David Grogan (Gerrit)

      unread,
      Aug 29, 2025, 4:39:37 PM (11 days ago) Aug 29
      to Ian Kilpatrick, David Grogan, Chromium LUCI CQ, Morten Stenshorne, Vladimir Levin, Alexis Menard, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
      Attention needed from Ian Kilpatrick, Morten Stenshorne and Vladimir Levin

      David Grogan voted

      Code-Review+1
      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Ian Kilpatrick
      • Morten Stenshorne
      • Vladimir Levin
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I3a3fa613064b2c1b494845341a7edbd73e0401b8
        Gerrit-Change-Number: 6898171
        Gerrit-PatchSet: 4
        Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
        Gerrit-Reviewer: David Grogan <dgr...@chromium.org>
        Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
        Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
        Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
        Gerrit-CC: Alexis Menard <alexis...@intel.com>
        Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
        Gerrit-Attention: Vladimir Levin <vmp...@chromium.org>
        Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
        Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
        Gerrit-Comment-Date: Fri, 29 Aug 2025 20:39:27 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Ian Kilpatrick (Gerrit)

        unread,
        Aug 29, 2025, 5:37:05 PM (11 days ago) Aug 29
        to David Grogan, Chromium LUCI CQ, Morten Stenshorne, Vladimir Levin, Alexis Menard, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
        Attention needed from David Grogan, Morten Stenshorne and Vladimir Levin

        Ian Kilpatrick voted and added 2 comments

        Votes added by Ian Kilpatrick

        Auto-Submit+1

        2 comments

        Patchset-level comments
        File-level comment, Patchset 5 (Latest):
        Ian Kilpatrick . resolved

        ptal again 😊

        File third_party/blink/web_tests/external/wpt/css/css-anchor-position/last-successful-animation.html
        Line 59, Patchset 5 (Latest): assert_equals(anchored.offsetTop, 200);
        Open in Gerrit

        Related details

        Attention is currently required from:
        • David Grogan
        • Morten Stenshorne
        • Vladimir Levin
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement is not satisfiedCode-Review
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I3a3fa613064b2c1b494845341a7edbd73e0401b8
          Gerrit-Change-Number: 6898171
          Gerrit-PatchSet: 5
          Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
          Gerrit-Reviewer: David Grogan <dgr...@chromium.org>
          Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
          Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
          Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
          Gerrit-CC: Alexis Menard <alexis...@intel.com>
          Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
          Gerrit-Attention: Vladimir Levin <vmp...@chromium.org>
          Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
          Gerrit-Attention: David Grogan <dgr...@chromium.org>
          Gerrit-Comment-Date: Fri, 29 Aug 2025 21:36:53 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          David Grogan (Gerrit)

          unread,
          Aug 29, 2025, 5:38:07 PM (11 days ago) Aug 29
          to Ian Kilpatrick, David Grogan, Chromium LUCI CQ, Morten Stenshorne, Vladimir Levin, Alexis Menard, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org
          Attention needed from Ian Kilpatrick, Morten Stenshorne and Vladimir Levin

          David Grogan voted

          Code-Review+1
          Commit-Queue+2
          Open in Gerrit

          Related details

          Attention is currently required from:
          • Ian Kilpatrick
          • Morten Stenshorne
          • Vladimir Levin
          Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement satisfiedCode-Owners
            • requirement satisfiedCode-Review
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: I3a3fa613064b2c1b494845341a7edbd73e0401b8
            Gerrit-Change-Number: 6898171
            Gerrit-PatchSet: 5
            Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
            Gerrit-Reviewer: David Grogan <dgr...@chromium.org>
            Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
            Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
            Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
            Gerrit-CC: Alexis Menard <alexis...@intel.com>
            Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
            Gerrit-Attention: Vladimir Levin <vmp...@chromium.org>
            Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
            Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
            Gerrit-Comment-Date: Fri, 29 Aug 2025 21:37:53 +0000
            Gerrit-HasComments: No
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            open
            diffy

            Chromium LUCI CQ (Gerrit)

            unread,
            Aug 29, 2025, 6:13:54 PM (11 days ago) Aug 29
            to Ian Kilpatrick, David Grogan, Morten Stenshorne, Vladimir Levin, Alexis Menard, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org

            Chromium LUCI CQ submitted the change

            Change information

            Commit message:
            [anchor] Stop using unsafe alignment for position-area.

            Previously we needed to use unsafe alignment to prevent overlapping with
            the anchor. Stop doing that, since overlapping is now the desired
            behavior.

            This behaviour change is behind the flag: CSSAnchorUpdate
            Bug: 438515315
            Change-Id: I3a3fa613064b2c1b494845341a7edbd73e0401b8
            Commit-Queue: David Grogan <dgr...@chromium.org>
            Commit-Queue: Ian Kilpatrick <ikilp...@chromium.org>
            Auto-Submit: Ian Kilpatrick <ikilp...@chromium.org>
            Reviewed-by: David Grogan <dgr...@chromium.org>
            Cr-Commit-Position: refs/heads/main@{#1508644}
            Files:
            • M third_party/blink/renderer/core/style/position_area.cc
            • M third_party/blink/web_tests/TestExpectations
            • M third_party/blink/web_tests/external/wpt/css/css-anchor-position/last-successful-animation.html
            • D third_party/blink/web_tests/external/wpt/css/css-anchor-position/last-successful-basic-expected.txt
            • D third_party/blink/web_tests/external/wpt/css/css-anchor-position/last-successful-change-fallbacks-expected.txt
            • D third_party/blink/web_tests/external/wpt/css/css-anchor-position/last-successful-change-try-rule-expected.txt
            • D third_party/blink/web_tests/external/wpt/css/css-anchor-position/last-successful-iframe-expected.txt
            • D third_party/blink/web_tests/external/wpt/css/css-anchor-position/last-successful-intermediate-ignored-expected.txt
            Change size: M
            Delta: 8 files changed, 33 insertions(+), 47 deletions(-)
            Branch: refs/heads/main
            Submit Requirements:
            • requirement satisfiedCode-Review: +1 by David Grogan
            Open in Gerrit
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: merged
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: I3a3fa613064b2c1b494845341a7edbd73e0401b8
            Gerrit-Change-Number: 6898171
            Gerrit-PatchSet: 6
            Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
            Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
            Gerrit-Reviewer: David Grogan <dgr...@chromium.org>
            Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
            Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
            Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
            Gerrit-CC: Alexis Menard <alexis...@intel.com>
            open
            diffy
            satisfied_requirement

            Blink W3C Test Autoroller (Gerrit)

            unread,
            Aug 29, 2025, 7:01:00 PM (11 days ago) Aug 29
            to Chromium LUCI CQ, Ian Kilpatrick, David Grogan, Morten Stenshorne, Vladimir Levin, Alexis Menard, chromium...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org

            Message from Blink W3C Test Autoroller

            The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/54602

            Open in Gerrit

            Related details

            Attention set is empty
            Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement satisfiedCode-Owners
            • requirement satisfiedCode-Review
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: I3a3fa613064b2c1b494845341a7edbd73e0401b8
            Gerrit-Change-Number: 6898171
            Gerrit-PatchSet: 6
            Gerrit-Owner: Ian Kilpatrick <ikilp...@chromium.org>
            Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
            Gerrit-Reviewer: David Grogan <dgr...@chromium.org>
            Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
            Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
            Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
            Gerrit-CC: Alexis Menard <alexis...@intel.com>
            Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
            Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
            Gerrit-Comment-Date: Fri, 29 Aug 2025 23:00:54 +0000
            Gerrit-HasComments: No
            Gerrit-Has-Labels: No
            satisfied_requirement
            open
            diffy
            Reply all
            Reply to author
            Forward
            0 new messages