[gestures] Apply default styles to ::overscroll-* [chromium/src : main]
0 views
Skip to first unread message
Rune Lillesveen (Gerrit)
Nov 25, 2025, 6:34:30 AMNov 25
to Robert Flack, Rune Lillesveen, Vladimir Levin, AyeAye, Menard, Alexis, chromium...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Robert Flack and Vladimir Levin
Rune Lillesveen voted and added 3 comments![]( "Open in Gerrit")
Votes added by Rune Lillesveen
| Code-Review | +1 |
3 comments
Patchset-level comments
File third_party/blink/renderer/core/css/selector_checker.cc
Line 3146, Patchset 4 (Latest):
return element.GetPseudoIdForStyling() == pseudo_id;Rune Lillesveen . resolved
Note: If these were author-exposed, you would strictly have had to deal with dynamic_pseudo and context.pseudo_id (for getComputedStyle).
File third_party/blink/renderer/core/style/computed_style_constants.h
Line 129, Patchset 4 (Latest):
kLastPublicPseudoId = kPseudoIdOverscrollClientArea,Rune Lillesveen . unresolved
Was this the change that solved your issue?
Related details
Attention is currently required from:
- Robert Flack
- Vladimir Levin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robert Flack (Gerrit)
Nov 25, 2025, 9:20:19 AMNov 25
to Rune Lillesveen, Vladimir Levin, AyeAye, Menard, Alexis, chromium...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Vladimir Levin
Robert Flack voted and added 2 comments![]( "Open in Gerrit")
Votes added by Robert Flack
| Commit-Queue | +1 |
2 comments
File third_party/blink/renderer/core/css/selector_checker.cc
Line 3146, Patchset 4 (Latest):
return element.GetPseudoIdForStyling() == pseudo_id;Rune Lillesveen . resolved
Note: If these were author-exposed, you would strictly have had to deal with dynamic_pseudo and context.pseudo_id (for getComputedStyle).
Robert Flack
Thanks, good to know.
File third_party/blink/renderer/core/style/computed_style_constants.h
Line 129, Patchset 4 (Latest):
kLastPublicPseudoId = kPseudoIdOverscrollClientArea,Rune Lillesveen . resolved
Was this the change that solved your issue?
Robert Flack
Yes, this is the one. Per my other comment we have a check here https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/css/selector_checker.cc?q=file:selector_checker.cc%20pseudo_id%5C%20%5C%3C%5C%3D%5C%20kLastPublicPseudoId&ss=chromium%2Fchromium%2Fsrc that was critical to descending to the pseudo-element in selector matching. Without this, we try to match against the owning element.
Related details
Attention is currently required from:
- Vladimir Levin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vladimir Levin (Gerrit)
Nov 25, 2025, 9:20:35 AMNov 25
to Robert Flack, Chromium LUCI CQ, Rune Lillesveen, AyeAye, Menard, Alexis, chromium...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Vladimir Levin voted Code-Review+1![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robert Flack (Gerrit)
Nov 25, 2025, 9:22:29 AMNov 25
to Chris Harrelson, Vladimir Levin, Chromium LUCI CQ, Rune Lillesveen, AyeAye, Menard, Alexis, chromium...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Chris Harrelson
Robert Flack added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Robert Flack . resolved
+chrishtr for third_party/blink/public
Related details
Attention is currently required from:
- Chris Harrelson
Submit Requirements:
Code-Coverage
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chris Harrelson (Gerrit)
Nov 25, 2025, 11:00:14 AMNov 25
to Robert Flack, Vladimir Levin, Chromium LUCI CQ, Rune Lillesveen, AyeAye, Menard, Alexis, chromium...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Robert Flack
Chris Harrelson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Chris Harrelson
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Robert Flack
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robert Flack (Gerrit)
Nov 25, 2025, 12:48:37 PMNov 25
to Chris Harrelson, Vladimir Levin, Chromium LUCI CQ, Rune Lillesveen, AyeAye, Menard, Alexis, chromium...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Robert Flack voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 25, 2025, 1:42:05 PMNov 25
to Robert Flack, Chris Harrelson, Vladimir Levin, Rune Lillesveen, AyeAye, Menard, Alexis, chromium...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: third_party/blink/renderer/core/dom/element_test.cc
Insertions: 3, Deletions: 9.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[gestures] Apply default styles to ::overscroll-*
Sets UA styles for ::overscroll-area-parent and ::overscroll-client-area.
Bug: 457468300
Change-Id: Ib6fe138e8b18319f42563144fab35a142af710d3
Reviewed-by: Chris Harrelson <chri...@chromium.org>
Commit-Queue: Robert Flack <fla...@chromium.org>
Reviewed-by: Vladimir Levin <vmp...@chromium.org>
Reviewed-by: Rune Lillesveen <fut...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1549924}
Files:
- M third_party/blink/public/blink_resources.grd
- M third_party/blink/renderer/core/css/css_default_style_sheets.cc
- M third_party/blink/renderer/core/css/css_default_style_sheets.h
- M third_party/blink/renderer/core/css/css_selector.cc
- M third_party/blink/renderer/core/css/invalidation/rule_invalidation_data_visitor.cc
- A third_party/blink/renderer/core/css/overscroll.css
- M third_party/blink/renderer/core/css/parser/css_selector_parser.cc
- M third_party/blink/renderer/core/css/resolver/style_resolver.cc
- M third_party/blink/renderer/core/css/rule_set.cc
- M third_party/blink/renderer/core/css/selector_checker.cc
- M third_party/blink/renderer/core/dom/element_test.cc
- M third_party/blink/renderer/core/style/computed_style_constants.h
Change size: M
Delta: 12 files changed, 145 insertions(+), 14 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Vladimir Levin, +1 by Rune Lillesveen, +1 by Chris Harrelson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages