Avoid Member<>'s on stack in core/style [chromium/src : main]
0 views
Skip to first unread message
Anders Hartvoll Ruud (Gerrit)
Aug 19, 2025, 3:39:02 AMAug 19
to Kurt Catti-Schmidt, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Kurt Catti-Schmidt
Anders Hartvoll Ruud voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Kurt Catti-Schmidt
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kurt Catti-Schmidt (Gerrit)
Aug 19, 2025, 12:15:47 PMAug 19
to Anders Hartvoll Ruud, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Kurt Catti-Schmidt voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Aug 19, 2025, 12:27:13 PMAug 19
to Kurt Catti-Schmidt, Anders Hartvoll Ruud, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Avoid Member<>'s on stack in core/style
Per crbug.com/40209908 Member<>'s on the stack have extra overhead and
should be avoided. This change converts them to Member<>&'s, which do
not incur this overhead.
No behavioral changes are expected (other than slightly less Oilpan
overhead).
Bug: 439630585
Change-Id: I1cc48590bdf0c59bf292ae42be6f4cdaa49eca9f
Reviewed-by: Anders Hartvoll Ruud <and...@chromium.org>
Commit-Queue: Kurt Catti-Schmidt <ksc...@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1503392}
Files:
- M third_party/blink/renderer/core/style/computed_style.cc
- M third_party/blink/renderer/core/style/style_highlight_data.cc
Change size: S
Delta: 2 files changed, 5 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Anders Hartvoll Ruud
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages