[caret-color] Styling caret-color with optional second color value. [chromium/src : main]
Ziran Sun (Gerrit)
Ziran Sun voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
- Kent Tamura
- Manuel Rego Casasnovas
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kent Tamura (Gerrit)
Kent Tamura voted Code-Review+1![]( "Open in Gerrit")
- Manuel Rego Casasnovas
- Ziran Sun
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/59715.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
- Manuel Rego Casasnovas
- Ziran Sun
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ziran Sun (Gerrit)
Ziran Sun voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
- Manuel Rego Casasnovas
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
[caret-color] Styling caret-color with optional second color value.
A recent spec change at [1] that introduces a second color to
caret-color in order to allow to set the text color when caret-shape
is block. This CL adds the the styling support.
[1] https://drafts.csswg.org/css-ui/#caret-color/
- M third_party/blink/renderer/build/scripts/core/style/make_computed_style_base.py
- M third_party/blink/renderer/core/animation/color_property_functions.cc
- M third_party/blink/renderer/core/css/build.gni
- M third_party/blink/renderer/core/css/css_properties.json5
- M third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc
- M third_party/blink/renderer/core/css/resolver/style_builder_converter.cc
- M third_party/blink/renderer/core/css/resolver/style_builder_converter.h
- A third_party/blink/renderer/core/css/style_caret_color.h
- M third_party/blink/renderer/core/style/computed_style.cc
- M third_party/blink/renderer/core/style/computed_style.h
- M third_party/blink/renderer/platform/runtime_enabled_features.json5
- M third_party/blink/web_tests/external/wpt/css/css-ui/parsing/caret-color-computed.html
- M third_party/blink/web_tests/external/wpt/css/css-ui/parsing/caret-color-invalid.html
- M third_party/blink/web_tests/external/wpt/css/css-ui/parsing/caret-color-valid.html
Code-Review: +1 by Kent Tamura
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/59715
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
luci-bisection@appspot.gserviceaccount.com (Gerrit)
Message from luci-bi...@appspot.gserviceaccount.com![]( "Open in Gerrit")
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5412722112987136
Sample build with failed test: https://ci.chromium.org/b/8682473116001001697
Affected test(s):
[://\:chrome_wpt_tests!webtest::external/wpt/css/css-ui/parsing#caret-color-computed.html](https://ci.chromium.org/ui/test/chromium/:%2F%2F%5C:chrome_wpt_tests%21webtest::external%2Fwpt%2Fcss%2Fcss-ui%2Fparsing%23caret-color-computed.html?q=VHash%3A6129bda16b001a29)
A revert for this change was not created because the builder that this CL broke is not watched by gardeners, therefore less important. You can consider revert this CL, fix forward or let builder owners resolve it themselves.
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5412722112987136&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7816635&type=BUG