Enumerate missing properties in getComputedStyle() iteration [chromium/src : main]

1 view
Skip to first unread message

Helmut Januschka (Gerrit)

unread,
Mar 2, 2026, 4:00:09 PM (9 days ago) Mar 2
to Helmut Januschka, Kevin Babbitt, Chromium LUCI CQ, chromium...@chromium.org, Menard, Alexis, AyeAye, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, blink-...@chromium.org
Attention needed from Kevin Babbitt

Helmut Januschka added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Helmut Januschka . resolved

@kbab...@microsoft.com please let me know if you want me to address anything. the external tests where the -expect file is updated are failing before already. i'll try to start some follow up work and see if they are fixable.

Open in Gerrit

Related details

Attention is currently required from:
  • Kevin Babbitt
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1e6fc1ed220d6fd419da054e3b607e5511862523
Gerrit-Change-Number: 7622332
Gerrit-PatchSet: 2
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-Attention: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-Comment-Date: Mon, 02 Mar 2026 20:59:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kevin Babbitt (Gerrit)

unread,
Mar 2, 2026, 5:20:52 PM (9 days ago) Mar 2
to Helmut Januschka, Chromium LUCI CQ, chromium...@chromium.org, Menard, Alexis, AyeAye, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, blink-...@chromium.org
Attention needed from Helmut Januschka

Kevin Babbitt added 1 comment

File third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-enumeration-regression.html
Kevin Babbitt . unresolved

Oriol had a comment in the issue discussion that was very on-point:

I guess we need a test that detects when new properties are not made enumerable.

Most of the time, if someone adds a property and makes it not enumerable, it's a bug. I'd love to see a that enforces that, not just for a given set of properties we're fixing now, but for all properties added in the future, minus intentional exceptions. Essentially:

  • iterate over all known properties
  • see if the property can be found via getComputedStyle
  • if not and it's not on the list of exceptions, fail the test

That might need to be a unit test rather than an HTML file so that we know we're looking at all implemented properties, but I think it would be worth doing.

Open in Gerrit

Related details

Attention is currently required from:
  • Helmut Januschka
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1e6fc1ed220d6fd419da054e3b607e5511862523
    Gerrit-Change-Number: 7622332
    Gerrit-PatchSet: 2
    Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
    Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
    Gerrit-Reviewer: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
    Gerrit-Comment-Date: Mon, 02 Mar 2026 22:20:46 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Helmut Januschka (Gerrit)

    unread,
    Mar 2, 2026, 6:59:26 PM (9 days ago) Mar 2
    to Helmut Januschka, Kevin Babbitt, Chromium LUCI CQ, chromium...@chromium.org, Menard, Alexis, AyeAye, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, blink-...@chromium.org
    Attention needed from Kevin Babbitt

    Helmut Januschka added 2 comments

    Patchset-level comments
    Helmut Januschka . resolved

    added test

    File third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-enumeration-regression.html
    Kevin Babbitt . resolved

    Oriol had a comment in the issue discussion that was very on-point:

    I guess we need a test that detects when new properties are not made enumerable.

    Most of the time, if someone adds a property and makes it not enumerable, it's a bug. I'd love to see a that enforces that, not just for a given set of properties we're fixing now, but for all properties added in the future, minus intentional exceptions. Essentially:

    • iterate over all known properties
    • see if the property can be found via getComputedStyle
    • if not and it's not on the list of exceptions, fail the test

    That might need to be a unit test rather than an HTML file so that we know we're looking at all implemented properties, but I think it would be worth doing.

    Helmut Januschka

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Kevin Babbitt
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I1e6fc1ed220d6fd419da054e3b607e5511862523
      Gerrit-Change-Number: 7622332
      Gerrit-PatchSet: 2
      Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
      Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
      Gerrit-Reviewer: Kevin Babbitt <kbab...@microsoft.com>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-Attention: Kevin Babbitt <kbab...@microsoft.com>
      Gerrit-Comment-Date: Mon, 02 Mar 2026 23:59:09 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Kevin Babbitt <kbab...@microsoft.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Kevin Babbitt (Gerrit)

      unread,
      Mar 2, 2026, 7:24:31 PM (9 days ago) Mar 2
      to Helmut Januschka, Chromium LUCI CQ, chromium...@chromium.org, Menard, Alexis, AyeAye, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, blink-...@chromium.org
      Attention needed from Helmut Januschka

      Kevin Babbitt voted and added 1 comment

      Votes added by Kevin Babbitt

      Code-Review+1

      1 comment

      Patchset-level comments
      File-level comment, Patchset 3 (Latest):
      Kevin Babbitt . resolved

      lgtm, thanks for fixing this!

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Helmut Januschka
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I1e6fc1ed220d6fd419da054e3b607e5511862523
      Gerrit-Change-Number: 7622332
      Gerrit-PatchSet: 3
      Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
      Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
      Gerrit-Reviewer: Kevin Babbitt <kbab...@microsoft.com>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
      Gerrit-Comment-Date: Tue, 03 Mar 2026 00:24:24 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Helmut Januschka (Gerrit)

      unread,
      Mar 3, 2026, 11:33:35 AM (8 days ago) Mar 3
      to Helmut Januschka, Kevin Babbitt, Chromium LUCI CQ, chromium...@chromium.org, Menard, Alexis, AyeAye, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, blink-...@chromium.org

      Helmut Januschka voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I1e6fc1ed220d6fd419da054e3b607e5511862523
      Gerrit-Change-Number: 7622332
      Gerrit-PatchSet: 3
      Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
      Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
      Gerrit-Reviewer: Kevin Babbitt <kbab...@microsoft.com>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-Comment-Date: Tue, 03 Mar 2026 16:33:22 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Mar 3, 2026, 12:25:39 PM (8 days ago) Mar 3
      to Helmut Januschka, Kevin Babbitt, chromium...@chromium.org, Menard, Alexis, AyeAye, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, blink-...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      Enumerate missing properties in getComputedStyle() iteration

      Remove stale computable:false exclusions for supported longhands, keep intentional non-computable entries, and update computed-style listing tests.
      Bug: 40127632
      Change-Id: I1e6fc1ed220d6fd419da054e3b607e5511862523
      Reviewed-by: Kevin Babbitt <kbab...@microsoft.com>
      Commit-Queue: Helmut Januschka <hel...@januschka.com>
      Cr-Commit-Position: refs/heads/main@{#1593272}
      Files:
      • M third_party/blink/renderer/core/css/css_computed_style_declaration_test.cc
      • M third_party/blink/renderer/core/css/css_properties.json5
      • M third_party/blink/web_tests/external/wpt/css/cssom/getComputedStyle-pseudo-expected.txt
      • M third_party/blink/web_tests/external/wpt/css/cssom/getComputedStyle-pseudo-picker-expected.txt
      • M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-empty-font-family-expected.txt
      • M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-font-family-expected.txt
      • M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-listing-expected.txt
      • M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
      • M third_party/blink/web_tests/fast/css/getComputedStyle/resources/computed-style-listing.js
      • M third_party/blink/web_tests/platform/linux/virtual/cssom-getcomputedstyle-pseudo-no-colon-disabled/external/wpt/css/cssom/getComputedStyle-pseudo-expected.txt
      • M third_party/blink/web_tests/svg/css/getComputedStyle-listing-expected.txt
      Change size: M
      Delta: 11 files changed, 179 insertions(+), 40 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Kevin Babbitt
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I1e6fc1ed220d6fd419da054e3b607e5511862523
      Gerrit-Change-Number: 7622332
      Gerrit-PatchSet: 4
      Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
      Gerrit-Reviewer: Kevin Babbitt <kbab...@microsoft.com>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages