[caret-color] Add unit tests for ResolvedCaretTextColor(). [chromium/src : main]

4 views
Skip to first unread message

Kent Tamura (Gerrit)

unread,
May 7, 2026, 6:21:34 PM (7 days ago) May 7
to Ziran Sun, Kent Tamura, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Ziran Sun

Kent Tamura voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ziran Sun
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaeedb5486ad3a9624356d4df88d2edd6e012905a
Gerrit-Change-Number: 7827653
Gerrit-PatchSet: 1
Gerrit-Owner: Ziran Sun <zs...@igalia.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Ziran Sun <zs...@igalia.com>
Gerrit-Attention: Ziran Sun <zs...@igalia.com>
Gerrit-Comment-Date: Thu, 07 May 2026 22:20:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Ziran Sun (Gerrit)

unread,
May 8, 2026, 4:24:44 AM (7 days ago) May 8
to Kent Tamura, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Ziran Sun voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaeedb5486ad3a9624356d4df88d2edd6e012905a
Gerrit-Change-Number: 7827653
Gerrit-PatchSet: 1
Gerrit-Owner: Ziran Sun <zs...@igalia.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Ziran Sun <zs...@igalia.com>
Gerrit-Comment-Date: Fri, 08 May 2026 08:24:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
May 8, 2026, 4:37:19 AM (7 days ago) May 8
to Ziran Sun, Kent Tamura, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[caret-color] Add unit tests for ResolvedCaretTextColor().

Add unit tests for function ComputedStyle::ResolvedCaretTextColor()
introduced in CL 7816635.
Bug: 498556169
Change-Id: Iaeedb5486ad3a9624356d4df88d2edd6e012905a
Reviewed-by: Kent Tamura <tk...@chromium.org>
Commit-Queue: Ziran Sun <zs...@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1627519}
Files:
  • M third_party/blink/renderer/core/style/computed_style.h
  • M third_party/blink/renderer/core/style/computed_style_test.cc
Change size: S
Delta: 2 files changed, 42 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Kent Tamura
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaeedb5486ad3a9624356d4df88d2edd6e012905a
Gerrit-Change-Number: 7827653
Gerrit-PatchSet: 2
Gerrit-Owner: Ziran Sun <zs...@igalia.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Ziran Sun <zs...@igalia.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages