[Masonry] Parse auto repeat with intrinsic minmax() [chromium/src : main]

[Ian Kilpatrick (Gerrit)]

Attention needed from Alison Maher

Ian Kilpatrick voted and added 1 comment

Votes added by Ian Kilpatrick

Code-Review

+1

1 comment

File third_party/blink/renderer/core/css/properties/css_parsing_utils.cc

Line 6609, Patchset 2 (Latest): auto* function = DynamicTo<CSSFunctionValue>(value);

Ian Kilpatrick . unresolved

.nit const

Open in Gerrit

Related details

Attention is currently required from:

• Alison Maher

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia1f01858cc277c0ab04f091df37021bb909fda1e

Gerrit-Change-Number: 7549426

Gerrit-PatchSet: 2

Gerrit-Owner: Alison Maher <alm...@microsoft.com>

Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Alison Maher <alm...@microsoft.com>

Gerrit-Comment-Date: Fri, 06 Feb 2026 09:21:57 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Alison Maher (Gerrit)]

Alison Maher voted and added 1 comment

Votes added by Alison Maher

Commit-Queue

+2

1 comment

File third_party/blink/renderer/core/css/properties/css_parsing_utils.cc

Line 6609, Patchset 2: auto* function = DynamicTo<CSSFunctionValue>(value);

Ian Kilpatrick . resolved

.nit const

Alison Maher

Done (and added const to a few other similar spots)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia1f01858cc277c0ab04f091df37021bb909fda1e

Gerrit-Change-Number: 7549426

Gerrit-PatchSet: 3

Gerrit-Owner: Alison Maher <alm...@microsoft.com>

Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Fri, 06 Feb 2026 17:28:45 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Ian Kilpatrick <ikilp...@chromium.org>

[Blink W3C Test Autoroller (Gerrit)]

Message from Blink W3C Test Autoroller

Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/57622.

When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia1f01858cc277c0ab04f091df37021bb909fda1e

Gerrit-Change-Number: 7549426

Gerrit-PatchSet: 3

Gerrit-Owner: Alison Maher <alm...@microsoft.com>

Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Fri, 06 Feb 2026 17:37:47 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: third_party/blink/renderer/core/css/properties/css_parsing_utils.cc
Insertions: 4, Deletions: 4.

@@ -6575,14 +6575,14 @@
 }
 
 bool IsGridBreadthIntrinsicSized(const CSSValue& value) {
-  if (auto* identifier_value = DynamicTo<CSSIdentifierValue>(value)) {
+  if (const auto* identifier_value = DynamicTo<CSSIdentifierValue>(value)) {
     CSSValueID value_id = identifier_value->GetValueID();
     return value_id == CSSValueID::kAuto ||
            value_id == CSSValueID::kMinContent ||
            value_id == CSSValueID::kMaxContent;
   }
 
-  if (auto* function = DynamicTo<CSSFunctionValue>(value)) {
+  if (const auto* function = DynamicTo<CSSFunctionValue>(value)) {
     return function->FunctionType() == CSSValueID::kFitContent;
   }
 
@@ -6594,7 +6594,7 @@
 }
 
 bool IsGridTrackFixedSized(const CSSValue& value) {
-  auto* function = DynamicTo<CSSFunctionValue>(value);
+  const auto* function = DynamicTo<CSSFunctionValue>(value);
   if (function && function->FunctionType() != CSSValueID::kFitContent) {
     const CSSValue& min_value = function->Item(0);
     const CSSValue& max_value = function->Item(1);
@@ -6606,7 +6606,7 @@
 }
 
 bool IsGridTrackIntrinsicSized(const CSSValue& value) {
-  auto* function = DynamicTo<CSSFunctionValue>(value);
+  const auto* function = DynamicTo<CSSFunctionValue>(value);
   if (function && function->FunctionType() != CSSValueID::kFitContent) {
     const CSSValue& min_value = function->Item(0);
     const CSSValue& max_value = function->Item(1);
```

Change information

Commit message:

[Masonry] Parse auto repeat with intrinsic minmax()

In grid-lanes, we support intrinsic auto repeats. This means we need to
support auto repeats with minmax() and intrinsic values for both the min
and max breadth.

For example, repeat(auto-fill, minmax(auto, auto).

This change adds parsing support for this addition. The implementation
of this will be done in a follow up change.

Bug: 465744009, 343257585

Change-Id: Ia1f01858cc277c0ab04f091df37021bb909fda1e

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7549426

Commit-Queue: Alison Maher <alm...@microsoft.com>

Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1580970}

Files:

• M third_party/blink/renderer/core/css/properties/css_parsing_utils.cc
• M third_party/blink/renderer/core/style/grid_track_size.h
• M third_party/blink/web_tests/external/wpt/css/css-grid/parsing/grid-template-columns-invalid.html
• M third_party/blink/web_tests/external/wpt/css/css-grid/parsing/grid-template-columns-repeat-intrinsic-valid.tentative.html
• M third_party/blink/web_tests/external/wpt/css/css-grid/parsing/grid-template-rows-invalid.html
• M third_party/blink/web_tests/external/wpt/css/css-grid/parsing/grid-template-rows-repeat-intrinsic-valid.tentative.html
• M third_party/blink/web_tests/virtual/disable-css-grid-lanes-layout/external/wpt/css/css-grid/parsing/grid-template-columns-repeat-intrinsic-valid.tentative-expected.txt
• M third_party/blink/web_tests/virtual/disable-css-grid-lanes-layout/external/wpt/css/css-grid/parsing/grid-template-rows-repeat-intrinsic-valid.tentative-expected.txt

Change size: M

Delta: 8 files changed, 59 insertions(+), 11 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Ian Kilpatrick

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia1f01858cc277c0ab04f091df37021bb909fda1e

Gerrit-Change-Number: 7549426

Gerrit-PatchSet: 4

Gerrit-Owner: Alison Maher <alm...@microsoft.com>

Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>

[Blink W3C Test Autoroller (Gerrit)]

Message from Blink W3C Test Autoroller

The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/57622

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia1f01858cc277c0ab04f091df37021bb909fda1e

Gerrit-Change-Number: 7549426

Gerrit-PatchSet: 4

Gerrit-Owner: Alison Maher <alm...@microsoft.com>

Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Thu, 12 Feb 2026 17:35:24 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No