Fix difference between canvas test YAML config and generated test files [chromium/src : main]

0 views
Skip to first unread message

Jean-Philippe Gravel (Gerrit)

unread,
Dec 1, 2025, 5:15:20 PM (8 days ago) Dec 1
to Chromium LUCI CQ, Jonathan Lee, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Jonathan Lee

Jean-Philippe Gravel voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jonathan Lee
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie7caf9cadafbb84f69e7695c43bbf01c1799fb5f
Gerrit-Change-Number: 7211440
Gerrit-PatchSet: 1
Gerrit-Owner: Jean-Philippe Gravel <jpgr...@chromium.org>
Gerrit-Reviewer: Jean-Philippe Gravel <jpgr...@chromium.org>
Gerrit-Reviewer: Jonathan Lee <jonath...@google.com>
Gerrit-Attention: Jonathan Lee <jonath...@google.com>
Gerrit-Comment-Date: Mon, 01 Dec 2025 22:15:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Jonathan Lee (Gerrit)

unread,
Dec 1, 2025, 5:35:51 PM (8 days ago) Dec 1
to Jean-Philippe Gravel, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Jean-Philippe Gravel

Jonathan Lee added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Jonathan Lee . unresolved

Thanks for the patch! I already regenerated the tests upstream with backticks (https://github.com/web-platform-tests/wpt/commit/37b6423453df43710ba8f675d09774c8c84234f3), which should propagate to chromium/src on the next successful import, so I don't think we need this CL.

Open in Gerrit

Related details

Attention is currently required from:
  • Jean-Philippe Gravel
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie7caf9cadafbb84f69e7695c43bbf01c1799fb5f
    Gerrit-Change-Number: 7211440
    Gerrit-PatchSet: 1
    Gerrit-Owner: Jean-Philippe Gravel <jpgr...@chromium.org>
    Gerrit-Reviewer: Jean-Philippe Gravel <jpgr...@chromium.org>
    Gerrit-Reviewer: Jonathan Lee <jonath...@google.com>
    Gerrit-Attention: Jean-Philippe Gravel <jpgr...@chromium.org>
    Gerrit-Comment-Date: Mon, 01 Dec 2025 22:35:45 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Jean-Philippe Gravel (Gerrit)

    unread,
    Dec 2, 2025, 8:14:58 AM (8 days ago) Dec 2
    to Chromium LUCI CQ, Jonathan Lee, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

    Jean-Philippe Gravel abandoned this change

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: abandon
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages