Fix a DCHECK failure by changing writing-mode of an element with text-combine-upright [chromium/src : main]
0 views
Skip to first unread message
Kent Tamura (Gerrit)
Nov 26, 2025, 1:58:37 AM (14 days ago) Nov 26
to Kent Tamura, Koji Ishii, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Koji Ishii
Kent Tamura voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kent Tamura
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Koji Ishii
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Koji Ishii (Gerrit)
Nov 26, 2025, 4:30:21 AM (14 days ago) Nov 26
to Kent Tamura, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Kent Tamura
Koji Ishii voted and added 1 comment![]( "Open in Gerrit")
Votes added by Koji Ishii
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Attention is currently required from:
- Kent Tamura
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 26, 2025, 4:37:34 AM (14 days ago) Nov 26
to Kent Tamura, Koji Ishii, AyeAye, chromium...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix a DCHECK failure by changing writing-mode of an element with text-combine-upright
* We used IsHorizontalWritingMode() and IsHorizontalTypographicMode()
inconsistently to check text-combine-upright capability. It caused a
DCHECK failure in PropagateStyleToAnonymousChildren(). This CL unify
them to the latter.
* Fix a null pointer deference in a DCHECK due to list-item.
Bug: 461332428
Change-Id: Ifcdb61bd59fccafb1e58173a1c073f99e34ba502
Commit-Queue: Koji Ishii <ko...@chromium.org>
Reviewed-by: Koji Ishii <ko...@chromium.org>
Auto-Submit: Kent Tamura <tk...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1550343}
Files:
- M third_party/blink/renderer/core/layout/layout_object.cc
- M third_party/blink/renderer/core/layout/layout_object_hot.cc
- M third_party/blink/renderer/core/layout/layout_text_combine.h
- M third_party/blink/renderer/core/style/computed_style.cc
- M third_party/blink/renderer/platform/runtime_enabled_features.json5
- A third_party/blink/web_tests/external/wpt/css/css-writing-modes/text-combine-upright-sideways-crash.html
Change size: M
Delta: 6 files changed, 42 insertions(+), 8 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Koji Ishii
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Nov 26, 2025, 5:37:45 AM (14 days ago) Nov 26
to Chromium LUCI CQ, Kent Tamura, Koji Ishii, AyeAye, chromium...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/56295
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages