[gardener] Convert crash test to async_test [chromium/src : main]

0 views
Skip to first unread message

Anders Hartvoll Ruud (Gerrit)

unread,
Sep 22, 2025, 5:18:39 AM (10 days ago) Sep 22
to Rune Lillesveen, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Rune Lillesveen

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Rune Lillesveen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id7f09db68927533e41241c45bcd22a7a5fcb754e
Gerrit-Change-Number: 6971552
Gerrit-PatchSet: 1
Gerrit-Owner: Anders Hartvoll Ruud <and...@chromium.org>
Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
Gerrit-Comment-Date: Mon, 22 Sep 2025 09:18:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Rune Lillesveen (Gerrit)

unread,
Sep 22, 2025, 5:20:00 AM (10 days ago) Sep 22
to Anders Hartvoll Ruud, Rune Lillesveen, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Anders Hartvoll Ruud

Rune Lillesveen voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Anders Hartvoll Ruud
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id7f09db68927533e41241c45bcd22a7a5fcb754e
    Gerrit-Change-Number: 6971552
    Gerrit-PatchSet: 1
    Gerrit-Owner: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Attention: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-Comment-Date: Mon, 22 Sep 2025 09:19:43 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Anders Hartvoll Ruud (Gerrit)

    unread,
    Sep 22, 2025, 7:04:47 AM (10 days ago) Sep 22
    to Rune Lillesveen, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

    Anders Hartvoll Ruud voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id7f09db68927533e41241c45bcd22a7a5fcb754e
    Gerrit-Change-Number: 6971552
    Gerrit-PatchSet: 1
    Gerrit-Owner: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Comment-Date: Mon, 22 Sep 2025 11:04:30 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 22, 2025, 7:36:15 AM (10 days ago) Sep 22
    to Anders Hartvoll Ruud, Rune Lillesveen, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [gardener] Convert crash test to async_test

    This test is flaky because we get a variable number of CONSOLE WARNINGs
    in the output. The exact output is not important for a crash test,
    hence this CL converts it to a testharness test which ignores
    the output.
    Change-Id: Id7f09db68927533e41241c45bcd22a7a5fcb754e
    Commit-Queue: Anders Hartvoll Ruud <and...@chromium.org>
    Reviewed-by: Rune Lillesveen <fut...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1518628}
    Files:
    • D third_party/blink/web_tests/fast/dom/StyleSheet/stylesheet-move-between-documents-crash-expected.txt
    • M third_party/blink/web_tests/fast/dom/StyleSheet/stylesheet-move-between-documents-crash.html
    Change size: S
    Delta: 2 files changed, 5 insertions(+), 20 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Rune Lillesveen
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id7f09db68927533e41241c45bcd22a7a5fcb754e
    Gerrit-Change-Number: 6971552
    Gerrit-PatchSet: 2
    Gerrit-Owner: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages