[animation-trigger] Parse trigger-scope [chromium/src : main]
0 views
Skip to first unread message
David Awogbemila (Gerrit)
Dec 4, 2025, 7:24:37 AM (6 days ago) Dec 4
to Anders Hartvoll Ruud, Chromium LUCI CQ, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Anders Hartvoll Ruud
David Awogbemila added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
David Awogbemila . resolved
Hi Anders, ptal at this CL for parsing trigger-scope, thanks.
Related details
Attention is currently required from:
- Anders Hartvoll Ruud
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anders Hartvoll Ruud (Gerrit)
Dec 4, 2025, 9:37:02 AM (6 days ago) Dec 4
to David Awogbemila, Chromium LUCI CQ, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from David Awogbemila
Anders Hartvoll Ruud added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/style/style_trigger_scope.h
Line 16, Patchset 4 (Latest):
class CORE_EXPORT StyleTriggerScope {Anders Hartvoll Ruud . unresolved
If it's identical to `StyleAnchorScope`, shouldn't we generalize/rename that instead. It would allow sharing converters, computed-value code (etc) as well.
Related details
Attention is currently required from:
- David Awogbemila
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Awogbemila (Gerrit)
Dec 4, 2025, 11:37:14 AM (5 days ago) Dec 4
to Anders Hartvoll Ruud, Chromium LUCI CQ, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Anders Hartvoll Ruud
David Awogbemila added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/style/style_trigger_scope.h
Line 16, Patchset 4 (Latest):
class CORE_EXPORT StyleTriggerScope {Anders Hartvoll Ruud . unresolved
If it's identical to `StyleAnchorScope`, shouldn't we generalize/rename that instead. It would allow sharing converters, computed-value code (etc) as well.
Attention is currently required from:
- Anders Hartvoll Ruud
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anders Hartvoll Ruud (Gerrit)
Dec 5, 2025, 5:40:20 AM (5 days ago) Dec 5
to David Awogbemila, Chromium LUCI CQ, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from David Awogbemila
Anders Hartvoll Ruud voted and added 1 comment![]( "Open in Gerrit")
Votes added by Anders Hartvoll Ruud
| Code-Review | +1 |
1 comment
File third_party/blink/renderer/core/style/style_trigger_scope.h
David AwogbemilaIf it's identical to `StyleAnchorScope`, shouldn't we generalize/rename that instead. It would allow sharing converters, computed-value code (etc) as well.
Okay, will take a stab at that.
Attention is currently required from:
- David Awogbemila
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Awogbemila (Gerrit)
Dec 5, 2025, 8:45:34 AM (5 days ago) Dec 5
to Anders Hartvoll Ruud, Chromium LUCI CQ, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
David Awogbemila voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Awogbemila (Gerrit)
Dec 5, 2025, 8:46:09 AM (5 days ago) Dec 5
to Anders Hartvoll Ruud, Chromium LUCI CQ, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
David Awogbemila voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 5, 2025, 8:51:47 AM (5 days ago) Dec 5
to David Awogbemila, Anders Hartvoll Ruud, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[animation-trigger] Parse trigger-scope
The working group resolved[1] to have a trigger-scope[2] property that
functions similar to anchor-scope, limiting the visibility of trigger
names which are global by default.
[1] https://github.com/w3c/csswg-drafts/issues/12581#issuecomment-3206707173
[2] https://drafts.csswg.org/css-animations-2/#trigger-scope
Bug: 390314945
Change-Id: Ia610f75b08a9597de5d6d15f71b8603e211e9d4a
Reviewed-by: Anders Hartvoll Ruud <and...@chromium.org>
Commit-Queue: David Awogbemila <awogb...@chromium.org>
Reviewed-by: David Awogbemila <awogb...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1554611}
Files:
- M third_party/blink/public/mojom/use_counter/metrics/css_property_id.mojom
- M third_party/blink/renderer/build/scripts/core/style/make_computed_style_base.py
- M third_party/blink/renderer/core/css/css_properties.json5
- M third_party/blink/renderer/core/css/css_property_equality.cc
- M third_party/blink/renderer/core/css/cssom/style_property_map.cc
- M third_party/blink/renderer/core/css/properties/computed_style_utils.cc
- M third_party/blink/renderer/core/css/properties/computed_style_utils.h
- M third_party/blink/renderer/core/css/properties/css_parsing_utils.cc
- M third_party/blink/renderer/core/css/properties/css_parsing_utils.h
- M third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc
- M third_party/blink/renderer/core/css/resolver/style_builder_converter.cc
- M third_party/blink/renderer/core/css/resolver/style_builder_converter.h
- M third_party/blink/renderer/core/style/build.gni
- M third_party/blink/renderer/core/style/style_anchor_scope.h
- A third_party/blink/renderer/core/style/style_name_scope.h
- A third_party/blink/renderer/core/style/style_trigger_scope.h
- A third_party/blink/web_tests/external/wpt/scroll-animations/animation-trigger/parsing/trigger-scope.tentative.html
- M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-listing-expected.txt
- M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
- M third_party/blink/web_tests/svg/css/getComputedStyle-listing-expected.txt
- M third_party/blink/web_tests/webexposed/css-properties-as-js-properties-expected.txt
- M third_party/blink/web_tests/webexposed/css-property-listing-expected.txt
- M tools/metrics/histograms/metadata/blink/enums.xml
Change size: L
Delta: 23 files changed, 224 insertions(+), 75 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Anders Hartvoll Ruud, +1 by David Awogbemila
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Dec 5, 2025, 9:32:58 AM (5 days ago) Dec 5
to David Awogbemila, Chromium LUCI CQ, Anders Hartvoll Ruud, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/56525
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages