Don't include style_engine.h so much where not needed. [chromium/src : main]

0 views
Skip to first unread message

Morten Stenshorne (Gerrit)

unread,
Nov 28, 2025, 10:04:22 AM (12 days ago) Nov 28
to Rune Lillesveen, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Rune Lillesveen

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Rune Lillesveen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5e2148967f0c63bbd84520632956be750dd515fc
Gerrit-Change-Number: 7207244
Gerrit-PatchSet: 2
Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
Gerrit-Comment-Date: Fri, 28 Nov 2025 15:04:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

David Grogan (Gerrit)

unread,
Nov 28, 2025, 10:58:35 PM (11 days ago) Nov 28
to Morten Stenshorne, David Grogan, Rune Lillesveen, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Morten Stenshorne and Rune Lillesveen

David Grogan voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Morten Stenshorne
  • Rune Lillesveen
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I5e2148967f0c63bbd84520632956be750dd515fc
    Gerrit-Change-Number: 7207244
    Gerrit-PatchSet: 3
    Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Reviewer: David Grogan <dgr...@chromium.org>
    Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Comment-Date: Sat, 29 Nov 2025 03:57:51 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Rune Lillesveen (Gerrit)

    unread,
    Dec 1, 2025, 3:45:48 AM (9 days ago) Dec 1
    to Morten Stenshorne, David Grogan, Rune Lillesveen, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org
    Attention needed from Morten Stenshorne

    Rune Lillesveen added 1 comment

    File third_party/blink/renderer/core/display_lock/display_lock_context.h
    Line 128, Patchset 3 (Latest): bool ScreenReaderWantsLayout() const;
    Rune Lillesveen . unresolved

    I'm not super-familiar with the terminology, but I think something like ShouldActivateForScreenReader() would be better?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Morten Stenshorne
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I5e2148967f0c63bbd84520632956be750dd515fc
      Gerrit-Change-Number: 7207244
      Gerrit-PatchSet: 3
      Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
      Gerrit-Reviewer: David Grogan <dgr...@chromium.org>
      Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
      Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
      Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
      Gerrit-Comment-Date: Mon, 01 Dec 2025 08:45:28 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Morten Stenshorne (Gerrit)

      unread,
      Dec 1, 2025, 6:13:59 AM (9 days ago) Dec 1
      to David Grogan, Rune Lillesveen, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org
      Attention needed from Rune Lillesveen

      Morten Stenshorne added 1 comment

      File third_party/blink/renderer/core/display_lock/display_lock_context.h
      Line 128, Patchset 3: bool ScreenReaderWantsLayout() const;
      Rune Lillesveen . resolved

      I'm not super-familiar with the terminology, but I think something like ShouldActivateForScreenReader() would be better?

      Morten Stenshorne

      Done

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Rune Lillesveen
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I5e2148967f0c63bbd84520632956be750dd515fc
        Gerrit-Change-Number: 7207244
        Gerrit-PatchSet: 3
        Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
        Gerrit-Reviewer: David Grogan <dgr...@chromium.org>
        Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
        Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
        Gerrit-CC: Menard, Alexis <alexis...@intel.com>
        Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
        Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
        Gerrit-Comment-Date: Mon, 01 Dec 2025 11:13:38 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        Comment-In-Reply-To: Rune Lillesveen <fut...@chromium.org>
        satisfied_requirement
        open
        diffy

        Rune Lillesveen (Gerrit)

        unread,
        Dec 1, 2025, 6:14:48 AM (9 days ago) Dec 1
        to Morten Stenshorne, Rune Lillesveen, David Grogan, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org
        Attention needed from Morten Stenshorne

        Rune Lillesveen voted Code-Review+1

        Code-Review+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Morten Stenshorne
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I5e2148967f0c63bbd84520632956be750dd515fc
        Gerrit-Change-Number: 7207244
        Gerrit-PatchSet: 5
        Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
        Gerrit-Reviewer: David Grogan <dgr...@chromium.org>
        Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
        Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
        Gerrit-CC: Menard, Alexis <alexis...@intel.com>
        Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
        Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
        Gerrit-Comment-Date: Mon, 01 Dec 2025 11:14:27 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Morten Stenshorne (Gerrit)

        unread,
        Dec 1, 2025, 6:28:15 AM (9 days ago) Dec 1
        to Rune Lillesveen, David Grogan, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org

        Morten Stenshorne voted Commit-Queue+2

        Commit-Queue+2
        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I5e2148967f0c63bbd84520632956be750dd515fc
        Gerrit-Change-Number: 7207244
        Gerrit-PatchSet: 5
        Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
        Gerrit-Reviewer: David Grogan <dgr...@chromium.org>
        Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
        Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
        Gerrit-CC: Menard, Alexis <alexis...@intel.com>
        Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
        Gerrit-Comment-Date: Mon, 01 Dec 2025 11:28:00 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Chromium LUCI CQ (Gerrit)

        unread,
        Dec 1, 2025, 7:58:05 AM (9 days ago) Dec 1
        to Morten Stenshorne, Rune Lillesveen, David Grogan, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org

        Chromium LUCI CQ submitted the change

        Change information

        Commit message:
        Don't include style_engine.h so much where not needed.

        Reduced the number of compilation units from about 930 to less than 200
        (unit tests excluded).

        Compile size details:
        Delta: -105.43 MiB (-110550712)
        Delta %: -0.03%
        Change-Id: I5e2148967f0c63bbd84520632956be750dd515fc
        Reviewed-by: Rune Lillesveen <fut...@chromium.org>
        Reviewed-by: David Grogan <dgr...@chromium.org>
        Commit-Queue: Morten Stenshorne <mste...@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#1552045}
        Files:
        • M third_party/blink/renderer/core/animation/timeline_offset.cc
        • M third_party/blink/renderer/core/animation/timeline_trigger.cc
        • M third_party/blink/renderer/core/css/container_query_evaluator.cc
        • M third_party/blink/renderer/core/css/resolver/style_resolver_state.cc
        • M third_party/blink/renderer/core/css/style_containment_scope.h
        • M third_party/blink/renderer/core/display_lock/display_lock_context.cc
        • M third_party/blink/renderer/core/display_lock/display_lock_context.h
        • M third_party/blink/renderer/core/display_lock/display_lock_document_state.cc
        • M third_party/blink/renderer/core/dom/document_test.cc
        • M third_party/blink/renderer/core/dom/layout_tree_builder.h
        • M third_party/blink/renderer/core/dom/pseudo_element.cc
        • M third_party/blink/renderer/core/exported/web_element.cc
        • M third_party/blink/renderer/core/frame/browser_controls_test.cc
        • M third_party/blink/renderer/core/html/html_frame_owner_element.cc
        • M third_party/blink/renderer/core/html/html_link_element.cc
        • M third_party/blink/renderer/core/html/link_style.cc
        • M third_party/blink/renderer/core/html/link_style.h
        • M third_party/blink/renderer/core/layout/column_layout_algorithm.cc
        • M third_party/blink/renderer/core/layout/forms/layout_text_control.cc
        • M third_party/blink/renderer/core/layout/out_of_flow_layout_part.cc
        • M third_party/blink/renderer/core/style/content_data.cc
        • M third_party/blink/renderer/core/testing/page_test_base.cc
        Change size: S
        Delta: 22 files changed, 30 insertions(+), 5 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by David Grogan, +1 by Rune Lillesveen
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I5e2148967f0c63bbd84520632956be750dd515fc
        Gerrit-Change-Number: 7207244
        Gerrit-PatchSet: 6
        Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: David Grogan <dgr...@chromium.org>
        Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
        Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages