[Masonry] Rename item-tolerance property to flow-tolerance [chromium/src : main]

0 views
Skip to first unread message

Alison Maher (Gerrit)

unread,
Jan 14, 2026, 5:02:20 PM (9 days ago) Jan 14
to Yanling Wang, Kurt Catti-Schmidt, Celeste Pan, Chromium LUCI CQ, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, Javier Fernandez, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
Attention needed from Kurt Catti-Schmidt and Yanling Wang

Alison Maher voted and added 3 comments

Votes added by Alison Maher

Code-Review+1

3 comments

File third_party/blink/renderer/core/css/css_properties.json5
Line 4114, Patchset 3 (Latest): name: "flow-tolerance",
Alison Maher . unresolved

nit: this can now be moved up below "flood-opacity" for alphabetical ordering

File third_party/blink/renderer/core/css/css_property_equality.cc
Line 593, Patchset 3 (Latest): case CSSPropertyID::kFlowTolerance:
Alison Maher . unresolved

nit: this can be moved up below "kFieldSizing" for alphabetical ordering

File third_party/blink/renderer/core/css/properties/computed_style_utils.h
Line 37, Patchset 3 (Latest):class FlowTolerance;
Alison Maher . unresolved

nit: same here about alphabetical ordering

Open in Gerrit

Related details

Attention is currently required from:
  • Kurt Catti-Schmidt
  • Yanling Wang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I23fab2394753512eb3ed9ebfd0939be2a4f380eb
Gerrit-Change-Number: 7475554
Gerrit-PatchSet: 3
Gerrit-Owner: Yanling Wang <yanli...@microsoft.com>
Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
Gerrit-Reviewer: Yanling Wang <yanli...@microsoft.com>
Gerrit-CC: Celeste Pan <celes...@microsoft.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-Attention: Kurt Catti-Schmidt <ksc...@microsoft.com>
Gerrit-Attention: Yanling Wang <yanli...@microsoft.com>
Gerrit-Comment-Date: Wed, 14 Jan 2026 22:02:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Yanling Wang (Gerrit)

unread,
Jan 14, 2026, 6:31:00 PM (9 days ago) Jan 14
to Alison Maher, Kurt Catti-Schmidt, Celeste Pan, Chromium LUCI CQ, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, Javier Fernandez, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
Attention needed from Alison Maher and Kurt Catti-Schmidt

Yanling Wang added 3 comments

File third_party/blink/renderer/core/css/css_properties.json5
Line 4114, Patchset 3: name: "flow-tolerance",
Alison Maher . resolved

nit: this can now be moved up below "flood-opacity" for alphabetical ordering

Yanling Wang

Done

File third_party/blink/renderer/core/css/css_property_equality.cc
Line 593, Patchset 3: case CSSPropertyID::kFlowTolerance:
Alison Maher . resolved

nit: this can be moved up below "kFieldSizing" for alphabetical ordering

Yanling Wang

Done

File third_party/blink/renderer/core/css/properties/computed_style_utils.h
Line 37, Patchset 3:class FlowTolerance;
Alison Maher . resolved

nit: same here about alphabetical ordering

Yanling Wang

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Alison Maher
  • Kurt Catti-Schmidt
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I23fab2394753512eb3ed9ebfd0939be2a4f380eb
    Gerrit-Change-Number: 7475554
    Gerrit-PatchSet: 4
    Gerrit-Owner: Yanling Wang <yanli...@microsoft.com>
    Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
    Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
    Gerrit-Reviewer: Yanling Wang <yanli...@microsoft.com>
    Gerrit-CC: Celeste Pan <celes...@microsoft.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-Attention: Alison Maher <alm...@microsoft.com>
    Gerrit-Attention: Kurt Catti-Schmidt <ksc...@microsoft.com>
    Gerrit-Comment-Date: Wed, 14 Jan 2026 23:30:50 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Alison Maher <alm...@microsoft.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Alison Maher (Gerrit)

    unread,
    Jan 14, 2026, 6:34:58 PM (9 days ago) Jan 14
    to Yanling Wang, Kurt Catti-Schmidt, Celeste Pan, Chromium LUCI CQ, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, Javier Fernandez, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
    Attention needed from Kurt Catti-Schmidt and Yanling Wang

    Alison Maher voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Kurt Catti-Schmidt
    • Yanling Wang
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I23fab2394753512eb3ed9ebfd0939be2a4f380eb
    Gerrit-Change-Number: 7475554
    Gerrit-PatchSet: 4
    Gerrit-Owner: Yanling Wang <yanli...@microsoft.com>
    Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
    Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
    Gerrit-Reviewer: Yanling Wang <yanli...@microsoft.com>
    Gerrit-CC: Celeste Pan <celes...@microsoft.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-Attention: Kurt Catti-Schmidt <ksc...@microsoft.com>
    Gerrit-Attention: Yanling Wang <yanli...@microsoft.com>
    Gerrit-Comment-Date: Wed, 14 Jan 2026 23:34:49 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Kurt Catti-Schmidt (Gerrit)

    unread,
    Jan 14, 2026, 7:19:30 PM (9 days ago) Jan 14
    to Yanling Wang, Alison Maher, Celeste Pan, Chromium LUCI CQ, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, Javier Fernandez, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
    Attention needed from Yanling Wang

    Kurt Catti-Schmidt voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Yanling Wang
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I23fab2394753512eb3ed9ebfd0939be2a4f380eb
      Gerrit-Change-Number: 7475554
      Gerrit-PatchSet: 4
      Gerrit-Owner: Yanling Wang <yanli...@microsoft.com>
      Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
      Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
      Gerrit-Reviewer: Yanling Wang <yanli...@microsoft.com>
      Gerrit-CC: Celeste Pan <celes...@microsoft.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-Attention: Yanling Wang <yanli...@microsoft.com>
      Gerrit-Comment-Date: Thu, 15 Jan 2026 00:19:20 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Yanling Wang (Gerrit)

      unread,
      Jan 15, 2026, 12:45:44 AM (9 days ago) Jan 15
      to Kurt Catti-Schmidt, Alison Maher, Celeste Pan, Chromium LUCI CQ, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, Javier Fernandez, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, zol...@webkit.org

      Yanling Wang voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I23fab2394753512eb3ed9ebfd0939be2a4f380eb
      Gerrit-Change-Number: 7475554
      Gerrit-PatchSet: 4
      Gerrit-Owner: Yanling Wang <yanli...@microsoft.com>
      Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
      Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
      Gerrit-Reviewer: Yanling Wang <yanli...@microsoft.com>
      Gerrit-CC: Celeste Pan <celes...@microsoft.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-Comment-Date: Thu, 15 Jan 2026 05:45:33 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Jan 15, 2026, 1:06:31 AM (8 days ago) Jan 15
      to Yanling Wang, Kurt Catti-Schmidt, Alison Maher, Celeste Pan, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, Javier Fernandez, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, zol...@webkit.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      [Masonry] Rename item-tolerance property to flow-tolerance

      This CL updates code to use "flow-tolerance" instead of "item-tolerance"
      based on the resolution here:
      https://github.com/w3c/csswg-drafts/issues/10884#issuecomment-3720053719
      Bug: 343257585, 474955260
      Change-Id: I23fab2394753512eb3ed9ebfd0939be2a4f380eb
      Reviewed-by: Alison Maher <alm...@microsoft.com>
      Reviewed-by: Kurt Catti-Schmidt <ksc...@microsoft.com>
      Commit-Queue: Yanling Wang <yanli...@microsoft.com>
      Cr-Commit-Position: refs/heads/main@{#1569526}
      Files:
      • M third_party/blink/public/mojom/use_counter/metrics/css_property_id.mojom
      • M third_party/blink/renderer/build/scripts/core/style/make_computed_style_base.py
      • M third_party/blink/renderer/core/css/css_properties.json5
      • M third_party/blink/renderer/core/css/css_property_equality.cc
      • M third_party/blink/renderer/core/css/properties/computed_style_utils.cc
      • M third_party/blink/renderer/core/css/properties/computed_style_utils.h
      • M third_party/blink/renderer/core/css/properties/css_parsing_utils.cc
      • M third_party/blink/renderer/core/css/properties/css_parsing_utils.h
      • M third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc
      • M third_party/blink/renderer/core/css/resolver/style_builder_converter.cc
      • M third_party/blink/renderer/core/css/resolver/style_builder_converter.h
      • M third_party/blink/renderer/core/layout/grid_lanes/grid_lanes_layout_algorithm.cc
      • M third_party/blink/renderer/core/layout/length_utils.cc
      • M third_party/blink/renderer/core/layout/length_utils.h
      • M third_party/blink/renderer/core/style/build.gni
      • A third_party/blink/renderer/core/style/flow_tolerance.h
      • D third_party/blink/renderer/core/style/item_tolerance.h
      • M third_party/blink/web_tests/TestExpectations
      • M third_party/blink/web_tests/external/wpt/css/css-grid/grid-lanes/tentative/item-placement/column-reverse-dense-packing-multi-span-006.html
      • M third_party/blink/web_tests/external/wpt/css/css-grid/grid-lanes/tentative/item-placement/dense-packing/column-dense-packing-007.html
      • M third_party/blink/web_tests/external/wpt/css/css-grid/grid-lanes/tentative/item-placement/dense-packing/column-dense-packing-008-ref.html
      • M third_party/blink/web_tests/external/wpt/css/css-grid/grid-lanes/tentative/item-placement/dense-packing/column-dense-packing-008.html
      • M third_party/blink/web_tests/external/wpt/css/css-grid/grid-lanes/tentative/item-placement/dense-packing/column-dense-packing-multi-span-010.html
      • M third_party/blink/web_tests/external/wpt/css/css-grid/grid-lanes/tentative/item-placement/dense-packing/column-dense-packing-multi-span-011.html
      • M third_party/blink/web_tests/external/wpt/css/css-grid/grid-lanes/tentative/item-placement/dense-packing/column-dense-packing-multi-span-012.html
      • M third_party/blink/web_tests/external/wpt/css/css-grid/grid-lanes/tentative/item-placement/row-reverse-dense-packing-002.html
      • D third_party/blink/web_tests/external/wpt/css/css-grid/grid-lanes/tentative/parsing/flow-tolerance-computed-expected.txt
      • D third_party/blink/web_tests/external/wpt/css/css-grid/grid-lanes/tentative/parsing/flow-tolerance-valid-expected.txt
      • M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-listing-expected.txt
      • M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
      • M third_party/blink/web_tests/svg/css/getComputedStyle-listing-expected.txt
      • M third_party/blink/web_tests/webexposed/css-properties-as-js-properties-expected.txt
      • M third_party/blink/web_tests/webexposed/css-property-listing-expected.txt
      • M third_party/blink/web_tests/wpt_internal/css/css-grid-lanes/column-dense-packing-multi-span-005.html
      • M tools/metrics/histograms/metadata/blink/enums.xml
      Change size: L
      Delta: 35 files changed, 120 insertions(+), 166 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Kurt Catti-Schmidt, +1 by Alison Maher
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I23fab2394753512eb3ed9ebfd0939be2a4f380eb
      Gerrit-Change-Number: 7475554
      Gerrit-PatchSet: 5
      Gerrit-Owner: Yanling Wang <yanli...@microsoft.com>
      Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
      Gerrit-Reviewer: Yanling Wang <yanli...@microsoft.com>
      Gerrit-CC: Celeste Pan <celes...@microsoft.com>
      open
      diffy
      satisfied_requirement

      Blink W3C Test Autoroller (Gerrit)

      unread,
      Jan 15, 2026, 1:51:49 AM (8 days ago) Jan 15
      to Chromium LUCI CQ, Yanling Wang, Kurt Catti-Schmidt, Alison Maher, Celeste Pan, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, Javier Fernandez, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, zol...@webkit.org

      Message from Blink W3C Test Autoroller

      The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/57180

      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I23fab2394753512eb3ed9ebfd0939be2a4f380eb
      Gerrit-Change-Number: 7475554
      Gerrit-PatchSet: 5
      Gerrit-Owner: Yanling Wang <yanli...@microsoft.com>
      Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
      Gerrit-Reviewer: Yanling Wang <yanli...@microsoft.com>
      Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
      Gerrit-CC: Celeste Pan <celes...@microsoft.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-Comment-Date: Thu, 15 Jan 2026 06:51:42 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: No
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages