[CC Clip Paths] Ensure PaintLayer [chromium/src : main]

0 views
Skip to first unread message

Kevin Ellis (Gerrit)

unread,
Mar 5, 2026, 8:13:11 AM (6 days ago) Mar 5
to Claire Chambers, Olga Gerchikov, AyeAye, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Xida Chen, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Claire Chambers and Olga Gerchikov

Kevin Ellis voted and added 1 comment

Votes added by Kevin Ellis

Code-Review+1

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Claire Chambers
  • Olga Gerchikov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I14d5bb95886f2dbb1ff15d54180115d951c115bb
Gerrit-Change-Number: 7635727
Gerrit-PatchSet: 2
Gerrit-Owner: Claire Chambers <clcha...@microsoft.com>
Gerrit-Reviewer: Claire Chambers <clcha...@microsoft.com>
Gerrit-Reviewer: Kevin Ellis <kev...@chromium.org>
Gerrit-Reviewer: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Xida Chen <xida...@chromium.org>
Gerrit-Attention: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-Attention: Claire Chambers <clcha...@microsoft.com>
Gerrit-Comment-Date: Thu, 05 Mar 2026 13:13:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Olga Gerchikov (Gerrit)

unread,
Mar 5, 2026, 11:44:35 AM (6 days ago) Mar 5
to Claire Chambers, Kevin Ellis, AyeAye, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Xida Chen, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Claire Chambers

Olga Gerchikov voted and added 1 comment

Votes added by Olga Gerchikov

Code-Review+1

1 comment

Commit Message
Line 13, Patchset 2 (Latest):on cc wil be stuck until style invalidation is forced, which is how this
Olga Gerchikov . unresolved

nit: will

Open in Gerrit

Related details

Attention is currently required from:
  • Claire Chambers
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I14d5bb95886f2dbb1ff15d54180115d951c115bb
    Gerrit-Change-Number: 7635727
    Gerrit-PatchSet: 2
    Gerrit-Owner: Claire Chambers <clcha...@microsoft.com>
    Gerrit-Reviewer: Claire Chambers <clcha...@microsoft.com>
    Gerrit-Reviewer: Kevin Ellis <kev...@chromium.org>
    Gerrit-Reviewer: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Xida Chen <xida...@chromium.org>
    Gerrit-Attention: Claire Chambers <clcha...@microsoft.com>
    Gerrit-Comment-Date: Thu, 05 Mar 2026 16:44:24 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Claire Chambers (Gerrit)

    unread,
    Mar 5, 2026, 2:23:49 PM (6 days ago) Mar 5
    to Olga Gerchikov, Kevin Ellis, AyeAye, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Xida Chen, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

    Claire Chambers added 1 comment

    Commit Message
    Line 13, Patchset 2:on cc wil be stuck until style invalidation is forced, which is how this
    Olga Gerchikov . resolved

    nit: will

    Claire Chambers

    Done

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I14d5bb95886f2dbb1ff15d54180115d951c115bb
      Gerrit-Change-Number: 7635727
      Gerrit-PatchSet: 3
      Gerrit-Owner: Claire Chambers <clcha...@microsoft.com>
      Gerrit-Reviewer: Claire Chambers <clcha...@microsoft.com>
      Gerrit-Reviewer: Kevin Ellis <kev...@chromium.org>
      Gerrit-Reviewer: Olga Gerchikov <gerc...@microsoft.com>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-CC: Xida Chen <xida...@chromium.org>
      Gerrit-Comment-Date: Thu, 05 Mar 2026 19:23:39 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Olga Gerchikov <gerc...@microsoft.com>
      satisfied_requirement
      open
      diffy

      Claire Chambers (Gerrit)

      unread,
      Mar 5, 2026, 2:23:52 PM (6 days ago) Mar 5
      to Olga Gerchikov, Kevin Ellis, AyeAye, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Xida Chen, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

      Claire Chambers voted Commit-Queue+2

      Commit-Queue+2
      Gerrit-Comment-Date: Thu, 05 Mar 2026 19:23:43 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Mar 5, 2026, 2:37:52 PM (6 days ago) Mar 5
      to Claire Chambers, Olga Gerchikov, Kevin Ellis, AyeAye, Menard, Alexis, chromium...@chromium.org, Xida Chen, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

      Chromium LUCI CQ submitted the change

      Unreviewed changes

      2 is the latest approved patch-set.
      No files were changed between the latest approved patch-set and the submitted one.

      Change information

      Commit message:
      [CC Clip Paths] Ensure PaintLayer

      Mask-based clip paths require a PaintLayer to paint, however, one isn't
      always necessarily guaranteed by the presence of a clip-path during the
      delay of an animation, or during discontinuous keyframe pairs involving
      clip-path: none. When there is no PaintLayer, the clip-path animation on
      cc will be stuck until style invalidation is forced, which is how this
      bug evaded web tests. A unit test invariant is added to capture this
      issue in future.

      To solve this issue, this CL reintroduces HasCurrentClipPathAnimation
      style flag.
      Bug: 489791428
      Change-Id: I14d5bb95886f2dbb1ff15d54180115d951c115bb
      Reviewed-by: Olga Gerchikov <gerc...@microsoft.com>
      Commit-Queue: Claire Chambers <clcha...@microsoft.com>
      Reviewed-by: Kevin Ellis <kev...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1594846}
      Files:
      • M third_party/blink/renderer/core/animation/css/css_animations.cc
      • M third_party/blink/renderer/core/style/computed_style.h
      • M third_party/blink/renderer/core/style/computed_style_extra_fields.json5
      • M third_party/blink/renderer/core/style/computed_style_test.cc
      • M third_party/blink/renderer/modules/csspaint/nativepaint/clip_path_paint_definition_test.cc
      Change size: S
      Delta: 5 files changed, 37 insertions(+), 1 deletion(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Kevin Ellis, +1 by Olga Gerchikov
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I14d5bb95886f2dbb1ff15d54180115d951c115bb
      Gerrit-Change-Number: 7635727
      Gerrit-PatchSet: 4
      Gerrit-Owner: Claire Chambers <clcha...@microsoft.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Claire Chambers <clcha...@microsoft.com>
      Gerrit-Reviewer: Kevin Ellis <kev...@chromium.org>
      Gerrit-Reviewer: Olga Gerchikov <gerc...@microsoft.com>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages