Pass BasicShape by reference to containing objects [chromium/src : main]
0 views
Skip to first unread message
Fredrik Söderquist (Gerrit)
May 5, 2026, 4:20:38 AM (10 days ago) May 5
to Ian Kilpatrick, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Ian Kilpatrick
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Ian Kilpatrick
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Kilpatrick (Gerrit)
May 5, 2026, 12:07:27 PM (10 days ago) May 5
to Fredrik Söderquist, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Fredrik Söderquist
Ian Kilpatrick voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Fredrik Söderquist
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fredrik Söderquist (Gerrit)
May 6, 2026, 4:42:51 AM (9 days ago) May 6
to Ian Kilpatrick, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Fredrik Söderquist voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fredrik Söderquist (Gerrit)
May 6, 2026, 10:44:13 AM (9 days ago) May 6
to Ian Kilpatrick, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Chromium LUCI CQ (Gerrit)
May 6, 2026, 10:48:01 AM (9 days ago) May 6
to Fredrik Söderquist, Ian Kilpatrick, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Pass BasicShape by reference to containing objects
ShapeOffsetPathOperation, ShapeClipPathOperation and ShapeValue can all
hold BasicShapes. For all cases the invariant is that the shape can't be
null. This is inconsistently reflected across these types - all three
take a const BasicShape*, but the getter on ShapeOffsetPathOperation
returns a reference.
Align all three so that they take a reference in the constructor and
return a reference in the getter. Update calling code.
Change-Id: Ib845a4bbde8ffc0ab822dd8356ab1d84550f0096
Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>
Commit-Queue: Fredrik Söderquist <f...@opera.com>
Cr-Commit-Position: refs/heads/main@{#1626176}
Files:
- M third_party/blink/renderer/core/animation/css_basic_shape_interpolation_type.cc
- M third_party/blink/renderer/core/animation/css_path_interpolation_type.cc
- M third_party/blink/renderer/core/animation/css_ray_interpolation_type.cc
- M third_party/blink/renderer/core/animation/css_shape_interpolation_type.cc
- M third_party/blink/renderer/core/css/properties/computed_style_utils.cc
- M third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc
- M third_party/blink/renderer/core/css/resolver/style_builder_converter.cc
- M third_party/blink/renderer/core/layout/shapes/shape_outside_info.cc
- M third_party/blink/renderer/core/style/computed_style_test.cc
- M third_party/blink/renderer/core/style/shape_clip_path_operation.h
- M third_party/blink/renderer/core/style/shape_offset_path_operation.h
- M third_party/blink/renderer/core/style/shape_value.h
Change size: M
Delta: 12 files changed, 44 insertions(+), 56 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ian Kilpatrick
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages