Rename StyleImage::IsAccessAllowed() to IsCorsSameOrigin() [chromium/src : main]

0 views
Skip to first unread message

Fredrik Söderquist (Gerrit)

unread,
Apr 16, 2026, 11:37:49 AM (2 days ago) Apr 16
to Stephen Chenney, Chromium LUCI CQ, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Stephen Chenney

Fredrik Söderquist voted and added 1 comment

Votes added by Fredrik Söderquist

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1:
Stephen Chenney . resolved

Please make it IsCorsSameOrigin, because at the end of the day that's what it's actually checking and the most accurate assessment of what it means to allow access. See ImageResource::IsAccessAllowed
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/loader/resource/image_resource.cc;drc=ab3903cafa49d204b050a363fc6a835e366b75b5;l=661

Fredrik Söderquist

Yep, good call. Done.

Open in Gerrit

Related details

Attention is currently required from:
  • Stephen Chenney
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4a687582a86a48f10bcbe3a13e7e7a661b8f8338
Gerrit-Change-Number: 7765110
Gerrit-PatchSet: 3
Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Stephen Chenney <sche...@chromium.org>
Gerrit-Comment-Date: Thu, 16 Apr 2026 15:37:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Stephen Chenney <sche...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Stephen Chenney (Gerrit)

unread,
Apr 16, 2026, 12:27:17 PM (2 days ago) Apr 16
to Fredrik Söderquist, Chromium LUCI CQ, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Fredrik Söderquist

Stephen Chenney voted and added 1 comment

Votes added by Stephen Chenney

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Stephen Chenney . resolved

Lgtm. Any plans to push it all the way down through Image to ImageResource?

Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4a687582a86a48f10bcbe3a13e7e7a661b8f8338
    Gerrit-Change-Number: 7765110
    Gerrit-PatchSet: 3
    Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Stephen Chenney <sche...@chromium.org>
    Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
    Gerrit-Comment-Date: Thu, 16 Apr 2026 16:27:10 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Fredrik Söderquist (Gerrit)

    unread,
    Apr 16, 2026, 12:37:33 PM (2 days ago) Apr 16
    to Stephen Chenney, Chromium LUCI CQ, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org

    Fredrik Söderquist voted and added 1 comment

    Votes added by Fredrik Söderquist

    Auto-Submit+0
    Commit-Queue+2

    1 comment

    Patchset-level comments
    Stephen Chenney . resolved

    Lgtm. Any plans to push it all the way down through Image to ImageResource?

    Fredrik Söderquist

    Will look into that. It looks like it may be a smaller change than this even.

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4a687582a86a48f10bcbe3a13e7e7a661b8f8338
    Gerrit-Change-Number: 7765110
    Gerrit-PatchSet: 3
    Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Stephen Chenney <sche...@chromium.org>
    Gerrit-Comment-Date: Thu, 16 Apr 2026 16:37:13 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Stephen Chenney <sche...@chromium.org>
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Apr 16, 2026, 1:45:24 PM (2 days ago) Apr 16
    to Fredrik Söderquist, Stephen Chenney, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Rename StyleImage::IsAccessAllowed() to IsCorsSameOrigin()

    This should better convey what the function does. Add an overload which
    allows not passing an argument - for convenience.
    Change-Id: I4a687582a86a48f10bcbe3a13e7e7a661b8f8338
    Commit-Queue: Fredrik Söderquist <f...@opera.com>
    Reviewed-by: Stephen Chenney <sche...@chromium.org>
    Commit-Queue: Stephen Chenney <sche...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1615998}
    Files:
    • M third_party/blink/renderer/core/layout/shapes/shape_outside_info.cc
    • M third_party/blink/renderer/core/paint/box_painter_base.cc
    • M third_party/blink/renderer/core/paint/inline_box_fragment_painter.cc
    • M third_party/blink/renderer/core/style/style_crossfade_image.cc
    • M third_party/blink/renderer/core/style/style_crossfade_image.h
    • M third_party/blink/renderer/core/style/style_fetched_image.cc
    • M third_party/blink/renderer/core/style/style_fetched_image.h
    • M third_party/blink/renderer/core/style/style_generated_image.h
    • M third_party/blink/renderer/core/style/style_image.cc
    • M third_party/blink/renderer/core/style/style_image.h
    • M third_party/blink/renderer/core/style/style_image_set.cc
    • M third_party/blink/renderer/core/style/style_image_set.h
    • M third_party/blink/renderer/core/style/style_mask_source_image.cc
    • M third_party/blink/renderer/core/style/style_mask_source_image.h
    • M third_party/blink/renderer/core/style/style_pending_image.h
    Change size: M
    Delta: 15 files changed, 27 insertions(+), 23 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Stephen Chenney
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4a687582a86a48f10bcbe3a13e7e7a661b8f8338
    Gerrit-Change-Number: 7765110
    Gerrit-PatchSet: 4
    Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Stephen Chenney <sche...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages