Support margin-trim on block containers. [chromium/src : main]

0 views
Skip to first unread message

Morten Stenshorne (Gerrit)

unread,
Feb 5, 2026, 6:25:19 AM (8 days ago) Feb 5
to Rune Lillesveen, Ian Kilpatrick, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
Attention needed from Ian Kilpatrick and Rune Lillesveen

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Ian Kilpatrick
  • Rune Lillesveen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie00d463b5f42fb09eac2958bc7ed7cb2ae28df2b
Gerrit-Change-Number: 7544283
Gerrit-PatchSet: 8
Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
Gerrit-Comment-Date: Thu, 05 Feb 2026 11:25:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Ian Kilpatrick (Gerrit)

unread,
Feb 5, 2026, 7:22:21 AM (8 days ago) Feb 5
to Morten Stenshorne, Rune Lillesveen, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
Attention needed from Morten Stenshorne and Rune Lillesveen

Ian Kilpatrick voted and added 1 comment

Votes added by Ian Kilpatrick

Code-Review+1

1 comment

File third_party/blink/renderer/core/css/css_properties.json5
Line 4224, Patchset 8 (Latest): invalidate: ["layout", "paint"],
Ian Kilpatrick . unresolved

arguably only layout?

Open in Gerrit

Related details

Attention is currently required from:
  • Morten Stenshorne
  • Rune Lillesveen
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie00d463b5f42fb09eac2958bc7ed7cb2ae28df2b
    Gerrit-Change-Number: 7544283
    Gerrit-PatchSet: 8
    Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Comment-Date: Thu, 05 Feb 2026 12:22:05 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Rune Lillesveen (Gerrit)

    unread,
    Feb 5, 2026, 7:30:43 AM (8 days ago) Feb 5
    to Morten Stenshorne, Ian Kilpatrick, Rune Lillesveen, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
    Attention needed from Morten Stenshorne

    Rune Lillesveen added 1 comment

    File third_party/blink/renderer/core/css/css_margin_trim_value.h
    Line 16, Patchset 8 (Latest):class CSSMarginTrimValue : public CSSValue {
    Rune Lillesveen . unresolved

    We typically use CSSValuePair instead of creating new CSSValue classes and do the mapping to e.g. a mask for ApplyValue().

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Morten Stenshorne
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie00d463b5f42fb09eac2958bc7ed7cb2ae28df2b
    Gerrit-Change-Number: 7544283
    Gerrit-PatchSet: 8
    Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Comment-Date: Thu, 05 Feb 2026 12:30:26 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Morten Stenshorne (Gerrit)

    unread,
    Feb 5, 2026, 8:10:24 AM (8 days ago) Feb 5
    to Ian Kilpatrick, Rune Lillesveen, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
    Attention needed from Rune Lillesveen

    Morten Stenshorne added 2 comments

    File third_party/blink/renderer/core/css/css_margin_trim_value.h
    Line 16, Patchset 8:class CSSMarginTrimValue : public CSSValue {
    Rune Lillesveen . unresolved

    We typically use CSSValuePair instead of creating new CSSValue classes and do the mapping to e.g. a mask for ApplyValue().

    Morten Stenshorne

    In patch set 6 I created a CSSValueList.
    https://chromium-review.googlesource.com/c/chromium/src/+/7544283/6

    ... which worked fine except for serialization.

    So I ended up with this, so that both getPropertyValue() and getComputedStyle() would return "block-start block-end" as "block". There are tests for this.

    Why would CSSValuePair be any better than CSSValueList? This property takes between one and four values.

    File third_party/blink/renderer/core/css/css_properties.json5
    Line 4224, Patchset 8: invalidate: ["layout", "paint"],
    Ian Kilpatrick . resolved

    arguably only layout?

    Morten Stenshorne

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Rune Lillesveen
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie00d463b5f42fb09eac2958bc7ed7cb2ae28df2b
    Gerrit-Change-Number: 7544283
    Gerrit-PatchSet: 8
    Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Comment-Date: Thu, 05 Feb 2026 13:10:12 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Ian Kilpatrick <ikilp...@chromium.org>
    Comment-In-Reply-To: Rune Lillesveen <fut...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Morten Stenshorne (Gerrit)

    unread,
    Feb 5, 2026, 8:11:54 AM (8 days ago) Feb 5
    to Ian Kilpatrick, Rune Lillesveen, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
    Attention needed from Rune Lillesveen

    Morten Stenshorne added 1 comment

    File third_party/blink/renderer/core/css/css_margin_trim_value.h
    Line 16, Patchset 8:class CSSMarginTrimValue : public CSSValue {
    Rune Lillesveen . unresolved

    We typically use CSSValuePair instead of creating new CSSValue classes and do the mapping to e.g. a mask for ApplyValue().

    Morten Stenshorne

    In patch set 6 I created a CSSValueList.
    https://chromium-review.googlesource.com/c/chromium/src/+/7544283/6

    ... which worked fine except for serialization.

    So I ended up with this, so that both getPropertyValue() and getComputedStyle() would return "block-start block-end" as "block". There are tests for this.

    Why would CSSValuePair be any better than CSSValueList? This property takes between one and four values.

    Morten Stenshorne

    Should I rather go back to patch set 6, and simplify the values in MarginTrim::ParseSingleValue()?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Rune Lillesveen
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie00d463b5f42fb09eac2958bc7ed7cb2ae28df2b
    Gerrit-Change-Number: 7544283
    Gerrit-PatchSet: 9
    Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Comment-Date: Thu, 05 Feb 2026 13:11:40 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Rune Lillesveen <fut...@chromium.org>
    Comment-In-Reply-To: Morten Stenshorne <mste...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Rune Lillesveen (Gerrit)

    unread,
    Feb 5, 2026, 8:23:15 AM (8 days ago) Feb 5
    to Morten Stenshorne, Ian Kilpatrick, Rune Lillesveen, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
    Attention needed from Morten Stenshorne

    Rune Lillesveen added 1 comment

    File third_party/blink/renderer/core/css/css_margin_trim_value.h
    Line 16, Patchset 8:class CSSMarginTrimValue : public CSSValue {
    Rune Lillesveen . unresolved

    We typically use CSSValuePair instead of creating new CSSValue classes and do the mapping to e.g. a mask for ApplyValue().

    Morten Stenshorne

    In patch set 6 I created a CSSValueList.
    https://chromium-review.googlesource.com/c/chromium/src/+/7544283/6

    ... which worked fine except for serialization.

    So I ended up with this, so that both getPropertyValue() and getComputedStyle() would return "block-start block-end" as "block". There are tests for this.

    Why would CSSValuePair be any better than CSSValueList? This property takes between one and four values.

    Morten Stenshorne

    Should I rather go back to patch set 6, and simplify the values in MarginTrim::ParseSingleValue()?

    Rune Lillesveen

    Why would CSSValuePair be any better than CSSValueList? This property takes between one and four values.

    I thought it took two, so yeah, a list would be the right choice then.

    Should I rather go back to patch set 6, and simplify the values in MarginTrim::ParseSingleValue()?

    That's what would match how we typically do it, at least for re-ordering.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Morten Stenshorne
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie00d463b5f42fb09eac2958bc7ed7cb2ae28df2b
    Gerrit-Change-Number: 7544283
    Gerrit-PatchSet: 9
    Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Comment-Date: Thu, 05 Feb 2026 13:23:00 +0000
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Morten Stenshorne (Gerrit)

    unread,
    Feb 5, 2026, 8:49:28 AM (8 days ago) Feb 5
    to Ian Kilpatrick, Rune Lillesveen, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
    Attention needed from Ian Kilpatrick and Rune Lillesveen

    Morten Stenshorne added 1 comment

    File third_party/blink/renderer/core/css/css_margin_trim_value.h
    Line 16, Patchset 8:class CSSMarginTrimValue : public CSSValue {
    Rune Lillesveen . resolved

    We typically use CSSValuePair instead of creating new CSSValue classes and do the mapping to e.g. a mask for ApplyValue().

    Morten Stenshorne

    In patch set 6 I created a CSSValueList.
    https://chromium-review.googlesource.com/c/chromium/src/+/7544283/6

    ... which worked fine except for serialization.

    So I ended up with this, so that both getPropertyValue() and getComputedStyle() would return "block-start block-end" as "block". There are tests for this.

    Why would CSSValuePair be any better than CSSValueList? This property takes between one and four values.

    Morten Stenshorne

    Should I rather go back to patch set 6, and simplify the values in MarginTrim::ParseSingleValue()?

    Rune Lillesveen

    Why would CSSValuePair be any better than CSSValueList? This property takes between one and four values.

    I thought it took two, so yeah, a list would be the right choice then.

    Should I rather go back to patch set 6, and simplify the values in MarginTrim::ParseSingleValue()?

    That's what would match how we typically do it, at least for re-ordering.

    Morten Stenshorne

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ian Kilpatrick
    • Rune Lillesveen
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie00d463b5f42fb09eac2958bc7ed7cb2ae28df2b
      Gerrit-Change-Number: 7544283
      Gerrit-PatchSet: 9
      Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
      Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
      Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
      Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
      Gerrit-Comment-Date: Thu, 05 Feb 2026 13:49:15 +0000
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Rune Lillesveen (Gerrit)

      unread,
      Feb 5, 2026, 9:39:49 AM (8 days ago) Feb 5
      to Morten Stenshorne, Ian Kilpatrick, Rune Lillesveen, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
      Attention needed from Ian Kilpatrick and Morten Stenshorne

      Rune Lillesveen added 2 comments

      File third_party/blink/renderer/core/css/css_properties.json5
      Line 4222, Patchset 10 (Latest): typedom_types: ["Keyword"],
      Rune Lillesveen . unresolved

      How did this in combination with ConvertFlags and all the keywords above not crash StylePropertyMapTest_CSSKeywordValuesTest?

      Line 4223, Patchset 10 (Latest): computable: false,
      Rune Lillesveen . unresolved

      Why is this false?

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Ian Kilpatrick
      • Morten Stenshorne
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ie00d463b5f42fb09eac2958bc7ed7cb2ae28df2b
        Gerrit-Change-Number: 7544283
        Gerrit-PatchSet: 10
        Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
        Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
        Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
        Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
        Gerrit-CC: Menard, Alexis <alexis...@intel.com>
        Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
        Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
        Gerrit-Comment-Date: Thu, 05 Feb 2026 14:39:36 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Morten Stenshorne (Gerrit)

        unread,
        Feb 5, 2026, 11:54:31 AM (8 days ago) Feb 5
        to Ian Kilpatrick, Rune Lillesveen, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
        Attention needed from Ian Kilpatrick and Rune Lillesveen

        Morten Stenshorne added 2 comments

        File third_party/blink/renderer/core/css/css_properties.json5
        Line 4222, Patchset 10: typedom_types: ["Keyword"],
        Rune Lillesveen . resolved

        How did this in combination with ConvertFlags and all the keywords above not crash StylePropertyMapTest_CSSKeywordValuesTest?

        Morten Stenshorne

        Oh, wait. It appears that I re-added `keywords`. This will cause a crash. Removed again.

        Line 4223, Patchset 10: computable: false,
        Rune Lillesveen . resolved

        Why is this false?

        Morten Stenshorne

        Removed. Doesn't have any effect?

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Ian Kilpatrick
        • Rune Lillesveen
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: Ie00d463b5f42fb09eac2958bc7ed7cb2ae28df2b
          Gerrit-Change-Number: 7544283
          Gerrit-PatchSet: 11
          Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
          Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
          Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
          Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
          Gerrit-CC: Menard, Alexis <alexis...@intel.com>
          Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
          Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
          Gerrit-Comment-Date: Thu, 05 Feb 2026 16:54:17 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          Comment-In-Reply-To: Rune Lillesveen <fut...@chromium.org>
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Rune Lillesveen (Gerrit)

          unread,
          Feb 6, 2026, 3:05:24 AM (7 days ago) Feb 6
          to Morten Stenshorne, Ian Kilpatrick, Rune Lillesveen, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
          Attention needed from Ian Kilpatrick and Morten Stenshorne

          Rune Lillesveen added 1 comment

          File third_party/blink/renderer/core/css/css_properties.json5
          Line 4223, Patchset 10: computable: false,
          Rune Lillesveen . resolved

          Why is this false?

          Morten Stenshorne

          Removed. Doesn't have any effect?

          Rune Lillesveen

          Seems to have had an effect given the latest run?

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Ian Kilpatrick
          • Morten Stenshorne
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: Ie00d463b5f42fb09eac2958bc7ed7cb2ae28df2b
          Gerrit-Change-Number: 7544283
          Gerrit-PatchSet: 13
          Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
          Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
          Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
          Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
          Gerrit-CC: Menard, Alexis <alexis...@intel.com>
          Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
          Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
          Gerrit-Comment-Date: Fri, 06 Feb 2026 08:05:12 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          Comment-In-Reply-To: Rune Lillesveen <fut...@chromium.org>
          Comment-In-Reply-To: Morten Stenshorne <mste...@chromium.org>
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Ian Kilpatrick (Gerrit)

          unread,
          Feb 6, 2026, 4:22:53 AM (7 days ago) Feb 6
          to Morten Stenshorne, Rune Lillesveen, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
          Attention needed from Morten Stenshorne

          Ian Kilpatrick voted Code-Review+1

          Code-Review+1
          Open in Gerrit

          Related details

          Attention is currently required from:
          • Morten Stenshorne
          Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement satisfiedCode-Owners
            • requirement satisfiedCode-Review
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: Ie00d463b5f42fb09eac2958bc7ed7cb2ae28df2b
            Gerrit-Change-Number: 7544283
            Gerrit-PatchSet: 15
            Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
            Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
            Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
            Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
            Gerrit-CC: Menard, Alexis <alexis...@intel.com>
            Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
            Gerrit-Comment-Date: Fri, 06 Feb 2026 09:22:40 +0000
            Gerrit-HasComments: No
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            open
            diffy

            Morten Stenshorne (Gerrit)

            unread,
            Feb 6, 2026, 4:23:56 AM (7 days ago) Feb 6
            to Ian Kilpatrick, Rune Lillesveen, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
            Attention needed from Rune Lillesveen

            Morten Stenshorne added 1 comment

            File third_party/blink/renderer/core/css/css_properties.json5
            Line 4223, Patchset 10: computable: false,
            Rune Lillesveen . resolved

            Why is this false?

            Morten Stenshorne

            Removed. Doesn't have any effect?

            Rune Lillesveen

            Seems to have had an effect given the latest run?

            Morten Stenshorne

            It sure did.
            There was also a parser mistake (assuming that everything is keywords) that I've now fixed.

            Open in Gerrit

            Related details

            Attention is currently required from:
            • Rune Lillesveen
            Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement satisfiedCode-Owners
            • requirement satisfiedCode-Review
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: Ie00d463b5f42fb09eac2958bc7ed7cb2ae28df2b
            Gerrit-Change-Number: 7544283
            Gerrit-PatchSet: 15
            Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
            Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
            Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
            Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
            Gerrit-CC: Menard, Alexis <alexis...@intel.com>
            Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
            Gerrit-Comment-Date: Fri, 06 Feb 2026 09:23:45 +0000
            satisfied_requirement
            open
            diffy

            Rune Lillesveen (Gerrit)

            unread,
            Feb 6, 2026, 4:25:40 AM (7 days ago) Feb 6
            to Morten Stenshorne, Rune Lillesveen, Ian Kilpatrick, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
            Attention needed from Morten Stenshorne

            Rune Lillesveen voted Code-Review+1

            Code-Review+1
            Open in Gerrit

            Related details

            Attention is currently required from:
            • Morten Stenshorne
            Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement satisfiedCode-Owners
            • requirement satisfiedCode-Review
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: Ie00d463b5f42fb09eac2958bc7ed7cb2ae28df2b
            Gerrit-Change-Number: 7544283
            Gerrit-PatchSet: 15
            Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
            Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
            Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
            Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
            Gerrit-CC: Menard, Alexis <alexis...@intel.com>
            Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
            Gerrit-Comment-Date: Fri, 06 Feb 2026 09:25:27 +0000
            Gerrit-HasComments: No
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            open
            diffy

            Morten Stenshorne (Gerrit)

            unread,
            Feb 6, 2026, 5:12:22 AM (7 days ago) Feb 6
            to Rune Lillesveen, Ian Kilpatrick, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org

            Morten Stenshorne voted Commit-Queue+2

            Commit-Queue+2
            Open in Gerrit

            Related details

            Attention set is empty
            Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement satisfiedCode-Owners
            • requirement satisfiedCode-Review
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: Ie00d463b5f42fb09eac2958bc7ed7cb2ae28df2b
            Gerrit-Change-Number: 7544283
            Gerrit-PatchSet: 15
            Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
            Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
            Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
            Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
            Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
            Gerrit-CC: Menard, Alexis <alexis...@intel.com>
            Gerrit-Comment-Date: Fri, 06 Feb 2026 10:12:06 +0000
            Gerrit-HasComments: No
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            open
            diffy

            Chromium LUCI CQ (Gerrit)

            unread,
            Feb 6, 2026, 6:16:20 AM (7 days ago) Feb 6
            to Morten Stenshorne, Rune Lillesveen, Ian Kilpatrick, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org

            Chromium LUCI CQ submitted the change

            Change information

            Commit message:
            Support margin-trim on block containers.

            This adds parsing support for the CSS margin-trim property, and layout
            support for block containers. Still no support for flex, grid or
            multicol containers.
            See https://drafts.csswg.org/css-box-4/#margin-trim

            Also note that in our implementation margin-trim doesn't affect the
            resolved value of margin properties, at least for now. There are
            existing tests that expect this, but not clear whether it's correct.
            See https://github.com/w3c/csswg-drafts/issues/11506

            There are still some failures in css-box/parsing/margin-trim.html , but
            not sure if they are valid. Canonical order should match the order in
            the spec, which is "block" before "inline", and "start" before "end".
            Bug: 40886857
            Change-Id: Ie00d463b5f42fb09eac2958bc7ed7cb2ae28df2b
            Skip-Clang-Tidy-Checks: google-readability-casting
            Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>
            Reviewed-by: Rune Lillesveen <fut...@chromium.org>
            Commit-Queue: Morten Stenshorne <mste...@chromium.org>
            Cr-Commit-Position: refs/heads/main@{#1580724}
            Files:
            • M third_party/blink/public/mojom/use_counter/metrics/css_property_id.mojom
            • M third_party/blink/renderer/core/css/css_identifier_value_mappings.h
            • M third_party/blink/renderer/core/css/css_properties.json5
            • M third_party/blink/renderer/core/css/css_property_equality.cc
            • M third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc
            • M third_party/blink/renderer/core/layout/block_layout_algorithm.cc
            • M third_party/blink/renderer/core/layout/block_layout_algorithm.h
            • M third_party/blink/renderer/core/layout/constraint_space.h
            • M third_party/blink/renderer/core/layout/constraint_space_builder.h
            • M third_party/blink/renderer/core/layout/geometry/margin_strut.cc
            • M third_party/blink/renderer/core/layout/geometry/margin_strut.h
            • M third_party/blink/renderer/core/layout/layout_algorithm.h
            • M third_party/blink/renderer/core/layout/layout_result.h
            • M third_party/blink/renderer/core/style/computed_style_constants.h
            • M third_party/blink/renderer/platform/runtime_enabled_features.json5
            • M third_party/blink/web_tests/TestExpectations
            • D third_party/blink/web_tests/external/wpt/css/css-box/inheritance-expected.txt
            • D third_party/blink/web_tests/external/wpt/css/css-box/margin-trim/block-container-block-end-last-child-with-border-expected.txt
            • D third_party/blink/web_tests/external/wpt/css/css-box/margin-trim/block-container-block-end-nested-last-child-with-border-expected.txt
            • A third_party/blink/web_tests/external/wpt/css/css-box/margin-trim/block-container-block-end-self-collapsing-and-border.html
            • A third_party/blink/web_tests/external/wpt/css/css-box/margin-trim/block-container-block-end-self-collapsing-block-start-margin-nested.html
            • A third_party/blink/web_tests/external/wpt/css/css-box/margin-trim/block-container-block-end-self-collapsing-block-start-margin.html
            • D third_party/blink/web_tests/external/wpt/css/css-box/margin-trim/block-container-block-end-self-collapsing-children-nested-at-bottom-expected.txt
            • D third_party/blink/web_tests/external/wpt/css/css-box/margin-trim/block-container-block-end-self-collapsing-children-nested-margin-trim-expected.txt
            • D third_party/blink/web_tests/external/wpt/css/css-box/margin-trim/block-container-block-end-self-collapsing-children-offsets-expected.txt
            • D third_party/blink/web_tests/external/wpt/css/css-box/margin-trim/block-container-block-end-self-collapsing-children-offsets-nested-multiple-times-expected.txt
            • D third_party/blink/web_tests/external/wpt/css/css-box/margin-trim/block-container-block-end-self-collapsing-children-offsets-nested-once-expected.txt
            • D third_party/blink/web_tests/external/wpt/css/css-box/margin-trim/block-container-block-end-self-collapsing-children-offsets-vert-lr-expected.txt
            • A third_party/blink/web_tests/external/wpt/css/css-box/margin-trim/block-container-block-end-start-margin.html
            • A third_party/blink/web_tests/external/wpt/css/css-box/margin-trim/block-container-block-start-003.html
            • A third_party/blink/web_tests/external/wpt/css/css-box/margin-trim/block-container-block-start-004.html
            • D third_party/blink/web_tests/external/wpt/css/css-box/parsing/margin-trim-computed-expected.txt
            • M third_party/blink/web_tests/external/wpt/css/css-box/parsing/margin-trim-expected.txt
            • M third_party/blink/web_tests/external/wpt/css/css-box/parsing/margin-trim.html
            • M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-listing-expected.txt
            • M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
            • M third_party/blink/web_tests/svg/css/getComputedStyle-listing-expected.txt
            • M third_party/blink/web_tests/webexposed/css-properties-as-js-properties-expected.txt
            • M third_party/blink/web_tests/webexposed/css-property-listing-expected.txt
            • M tools/metrics/histograms/metadata/blink/enums.xml
            Change size: L
            Delta: 40 files changed, 446 insertions(+), 165 deletions(-)
            Branch: refs/heads/main
            Submit Requirements:
            • requirement satisfiedCode-Review: +1 by Ian Kilpatrick, +1 by Rune Lillesveen
            Open in Gerrit
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: merged
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: Ie00d463b5f42fb09eac2958bc7ed7cb2ae28df2b
            Gerrit-Change-Number: 7544283
            Gerrit-PatchSet: 16
            Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
            Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
            open
            diffy
            satisfied_requirement

            Blink W3C Test Autoroller (Gerrit)

            unread,
            Feb 6, 2026, 7:20:57 AM (7 days ago) Feb 6
            to Chromium LUCI CQ, Morten Stenshorne, Rune Lillesveen, Ian Kilpatrick, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org

            Message from Blink W3C Test Autoroller

            The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/57608

            Open in Gerrit

            Related details

            Attention set is empty
            Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement satisfiedCode-Owners
            • requirement satisfiedCode-Review
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: Ie00d463b5f42fb09eac2958bc7ed7cb2ae28df2b
            Gerrit-Change-Number: 7544283
            Gerrit-PatchSet: 16
            Gerrit-Owner: Morten Stenshorne <mste...@chromium.org>
            Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
            Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
            Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
            Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
            Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
            Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
            Gerrit-CC: Menard, Alexis <alexis...@intel.com>
            Gerrit-Comment-Date: Fri, 06 Feb 2026 12:20:50 +0000
            Gerrit-HasComments: No
            Gerrit-Has-Labels: No
            satisfied_requirement
            open
            diffy
            Reply all
            Reply to author
            Forward
            0 new messages