Remove dead lazy-load logic for style images [chromium/src : main]

0 views
Skip to first unread message

Dominic Farolino (Gerrit)

unread,
Jan 6, 2026, 11:20:29 AMJan 6
to Stefan Zager, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Stefan Zager

Dominic Farolino voted and added 1 comment

Votes added by Dominic Farolino

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Dominic Farolino . resolved

Beautiful! Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Stefan Zager
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I00760d52444b908ea25d6951958245eea40da595
Gerrit-Change-Number: 7398642
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Zager <sza...@chromium.org>
Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
Gerrit-Reviewer: Stefan Zager <sza...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-Attention: Stefan Zager <sza...@chromium.org>
Gerrit-Comment-Date: Tue, 06 Jan 2026 16:20:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Stefan Zager (Gerrit)

unread,
Jan 14, 2026, 4:09:25 PM (9 days ago) Jan 14
to Dominic Farolino, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Stefan Zager voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I00760d52444b908ea25d6951958245eea40da595
Gerrit-Change-Number: 7398642
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Zager <sza...@chromium.org>
Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
Gerrit-Reviewer: Stefan Zager <sza...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-Comment-Date: Wed, 14 Jan 2026 21:09:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jan 14, 2026, 6:32:19 PM (9 days ago) Jan 14
to Stefan Zager, Dominic Farolino, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Chromium LUCI CQ submitted the change

Unreviewed changes

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
Remove dead lazy-load logic for style images

We no longer lazy load style images under any circumstances.
Bug: 473389267
Change-Id: I00760d52444b908ea25d6951958245eea40da595
Reviewed-by: Dominic Farolino <d...@chromium.org>
Commit-Queue: Stefan Zager <sza...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1569383}
Files:
  • M third_party/blink/renderer/core/css/css_image_value.cc
  • M third_party/blink/renderer/core/css/css_image_value.h
  • M third_party/blink/renderer/core/css/resolver/element_style_resources.cc
  • M third_party/blink/renderer/core/html/lazy_load_image_observer.cc
  • M third_party/blink/renderer/core/style/computed_style.cc
  • M third_party/blink/renderer/core/style/computed_style.h
  • M third_party/blink/renderer/core/style/style_fetched_image.cc
  • M third_party/blink/renderer/core/style/style_fetched_image.h
  • M third_party/blink/renderer/core/style/style_image.h
Change size: M
Delta: 9 files changed, 12 insertions(+), 82 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Dominic Farolino
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I00760d52444b908ea25d6951958245eea40da595
Gerrit-Change-Number: 7398642
Gerrit-PatchSet: 3
Gerrit-Owner: Stefan Zager <sza...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
Gerrit-Reviewer: Stefan Zager <sza...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages