[gap-decorations] Introduce rule-break: auto [chromium/src : main]

0 views
Skip to first unread message

Javier Contreras (Gerrit)

unread,
Dec 3, 2025, 6:51:33 PM (6 days ago) Dec 3
to Alison Maher, AyeAye, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Alison Maher

Javier Contreras voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alison Maher
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2a1657cb35694e33e57928efc9d9e6848e47ec54
Gerrit-Change-Number: 7219668
Gerrit-PatchSet: 9
Gerrit-Owner: Javier Contreras <javi...@microsoft.com>
Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
Gerrit-Reviewer: Javier Contreras <javi...@microsoft.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-Attention: Alison Maher <alm...@microsoft.com>
Gerrit-Comment-Date: Wed, 03 Dec 2025 23:51:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Alison Maher (Gerrit)

unread,
Dec 3, 2025, 7:26:06 PM (6 days ago) Dec 3
to Javier Contreras, AyeAye, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Javier Contreras

Alison Maher voted and added 2 comments

Votes added by Alison Maher

Code-Review+1

2 comments

File third_party/blink/renderer/core/css/css_gap_decoration_property_utils.cc
Line 190, Patchset 9 (Latest): // Resolve `auto` value based on container type.
Alison Maher . unresolved

nit: "the"

Line 190, Patchset 9 (Latest): // Resolve `auto` value based on container type.
// TODO(javiercon): For now, `auto` will always resolve to `none` for flex and
Alison Maher . unresolved

nit: I'd suggest adding comment separation here like so:

```
  // Resolve `auto` value based on container type.
  //
  // TODO(javiercon): ...
```
Open in Gerrit

Related details

Attention is currently required from:
  • Javier Contreras
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2a1657cb35694e33e57928efc9d9e6848e47ec54
Gerrit-Change-Number: 7219668
Gerrit-PatchSet: 9
Gerrit-Owner: Javier Contreras <javi...@microsoft.com>
Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
Gerrit-Reviewer: Javier Contreras <javi...@microsoft.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-Attention: Javier Contreras <javi...@microsoft.com>
Gerrit-Comment-Date: Thu, 04 Dec 2025 00:25:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Javier Contreras (Gerrit)

unread,
Dec 4, 2025, 11:27:51 AM (5 days ago) Dec 4
to Alison Maher, AyeAye, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Javier Contreras added 2 comments

File third_party/blink/renderer/core/css/css_gap_decoration_property_utils.cc
Line 190, Patchset 9: // Resolve `auto` value based on container type.
Alison Maher . resolved

nit: "the"

Javier Contreras

Done

Line 190, Patchset 9: // Resolve `auto` value based on container type.

// TODO(javiercon): For now, `auto` will always resolve to `none` for flex and
Alison Maher . resolved

nit: I'd suggest adding comment separation here like so:

```
  // Resolve `auto` value based on container type.
  //
  // TODO(javiercon): ...
```
Javier Contreras

Done

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2a1657cb35694e33e57928efc9d9e6848e47ec54
    Gerrit-Change-Number: 7219668
    Gerrit-PatchSet: 11
    Gerrit-Owner: Javier Contreras <javi...@microsoft.com>
    Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
    Gerrit-Reviewer: Javier Contreras <javi...@microsoft.com>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-Comment-Date: Thu, 04 Dec 2025 16:27:40 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Alison Maher <alm...@microsoft.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Javier Contreras (Gerrit)

    unread,
    Dec 4, 2025, 11:49:47 AM (5 days ago) Dec 4
    to Alison Maher, AyeAye, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

    Javier Contreras voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I2a1657cb35694e33e57928efc9d9e6848e47ec54
      Gerrit-Change-Number: 7219668
      Gerrit-PatchSet: 12
      Gerrit-Owner: Javier Contreras <javi...@microsoft.com>
      Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
      Gerrit-Reviewer: Javier Contreras <javi...@microsoft.com>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-Comment-Date: Thu, 04 Dec 2025 16:49:37 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Dec 4, 2025, 12:14:31 PM (5 days ago) Dec 4
      to Javier Contreras, Alison Maher, AyeAye, Menard, Alexis, chromium...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

      Chromium LUCI CQ submitted the change with unreviewed changes

      Unreviewed changes

      9 is the latest approved patch-set.
      The change was submitted with unreviewed changes in the following files:

      ```
      The name of the file: third_party/blink/renderer/core/css/css_gap_decoration_property_utils.cc
      Insertions: 2, Deletions: 1.

      @@ -187,7 +187,8 @@
           return rule_break;
         }
       
      -  // Resolve `auto` value based on container type.
      +  // Resolve `auto` value based on thecontainer type.
      +  //

         // TODO(javiercon): For now, `auto` will always resolve to `none` for flex and
         // multicol. This may change in the future depending on the resolution to
         // https://github.com/w3c/csswg-drafts/issues/13127
      ```

      Change information

      Commit message:
      [gap-decorations] Introduce rule-break: auto

      This CL introduces an `auto` keyword for `rule-break` properties in
      GapDecorations. While this isn't spec'd yet exactly, there seems to be
      consensus that we will introduce it. The exact behavior of it might
      change, but for now wit will resolve to `none` on non-grid container
      types (flex and multicol) while resolving to `spanning-item` for grid.

      Moreover we make `auto` the default for `rule-break` properties.

      If needed this change is easily revertible, but at the same time easily
      extendable for future behavior differences we might want for this
      property among container types.

      No extra tests are added since all currently existing tests that don't
      specify `rule-break` will be exercising this logic.

      https://github.com/w3c/csswg-drafts/issues/13127.
      Bug: 357648037
      Change-Id: I2a1657cb35694e33e57928efc9d9e6848e47ec54
      Commit-Queue: Javier Contreras <javi...@microsoft.com>
      Reviewed-by: Alison Maher <alm...@microsoft.com>
      Cr-Commit-Position: refs/heads/main@{#1554082}
      Files:
      • M third_party/blink/renderer/core/css/css_gap_decoration_property_utils.cc
      • M third_party/blink/renderer/core/css/css_gap_decoration_property_utils.h
      • M third_party/blink/renderer/core/css/css_properties.json5
      • M third_party/blink/renderer/core/css/css_value_keywords.json5
      • M third_party/blink/renderer/core/css/parser/css_parser_fast_paths.cc
      • M third_party/blink/renderer/core/css/properties/shorthands/shorthands_custom.cc
      • M third_party/blink/renderer/core/paint/gap_decorations_painter.cc
      • M third_party/blink/web_tests/external/wpt/css/css-gaps/parsing/rule-break-computed.html
      • M third_party/blink/web_tests/external/wpt/css/css-gaps/parsing/rule-break-invalid.html
      • M third_party/blink/web_tests/external/wpt/css/css-gaps/parsing/rule-break-valid.html
      • M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-listing-expected.txt
      • M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
      • M third_party/blink/web_tests/svg/css/getComputedStyle-listing-expected.txt
      Change size: M
      Delta: 13 files changed, 54 insertions(+), 17 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Alison Maher
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I2a1657cb35694e33e57928efc9d9e6848e47ec54
      Gerrit-Change-Number: 7219668
      Gerrit-PatchSet: 13
      Gerrit-Owner: Javier Contreras <javi...@microsoft.com>
      Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Javier Contreras <javi...@microsoft.com>
      open
      diffy
      satisfied_requirement

      Blink W3C Test Autoroller (Gerrit)

      unread,
      Dec 4, 2025, 2:18:24 PM (5 days ago) Dec 4
      to Chromium LUCI CQ, Javier Contreras, Alison Maher, AyeAye, Menard, Alexis, chromium...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

      Message from Blink W3C Test Autoroller

      The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/56494

      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I2a1657cb35694e33e57928efc9d9e6848e47ec54
      Gerrit-Change-Number: 7219668
      Gerrit-PatchSet: 13
      Gerrit-Owner: Javier Contreras <javi...@microsoft.com>
      Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Javier Contreras <javi...@microsoft.com>
      Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-Comment-Date: Thu, 04 Dec 2025 19:18:20 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: No
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages