[gestures] Make ::overscroll-area-parent siblings to scrolled content. [chromium/src : main]

0 views
Skip to first unread message

Robert Flack (Gerrit)

unread,
Dec 2, 2025, 11:50:29 AM (7 days ago) Dec 2
to Vladimir Levin, Menard, Alexis, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, apavlo...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Vladimir Levin

Robert Flack voted and added 1 comment

Votes added by Robert Flack

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Robert Flack . resolved

This patch removes the client area and changes the pseudo structure as discussed.

Open in Gerrit

Related details

Attention is currently required from:
  • Vladimir Levin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id2d46f1d94146b9b53de7baf6dfeca882fe85c65
Gerrit-Change-Number: 7217648
Gerrit-PatchSet: 1
Gerrit-Owner: Robert Flack <fla...@chromium.org>
Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-Attention: Vladimir Levin <vmp...@chromium.org>
Gerrit-Comment-Date: Tue, 02 Dec 2025 16:50:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Vladimir Levin (Gerrit)

unread,
Dec 3, 2025, 3:39:20 PM (6 days ago) Dec 3
to Robert Flack, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, apavlo...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Robert Flack

Vladimir Levin voted and added 2 comments

Votes added by Vladimir Levin

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Vladimir Levin . resolved

lgtm with nit

File third_party/blink/renderer/core/dom/layout_tree_builder_traversal.cc
Line 385, Patchset 2 (Latest): for (auto iter = overscroll_areas->GetNames().rbegin();
Vladimir Levin . unresolved

there's base::Reversed that you can use here (the clangtidy review seems valid)

Open in Gerrit

Related details

Attention is currently required from:
  • Robert Flack
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id2d46f1d94146b9b53de7baf6dfeca882fe85c65
    Gerrit-Change-Number: 7217648
    Gerrit-PatchSet: 2
    Gerrit-Owner: Robert Flack <fla...@chromium.org>
    Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
    Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
    Gerrit-Attention: Robert Flack <fla...@chromium.org>
    Gerrit-Comment-Date: Wed, 03 Dec 2025 20:39:12 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Robert Flack (Gerrit)

    unread,
    Dec 3, 2025, 4:18:26 PM (6 days ago) Dec 3
    to Chris Harrelson, Vladimir Levin, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, apavlo...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
    Attention needed from Chris Harrelson

    Robert Flack voted Commit-Queue+1

    Commit-Queue+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Chris Harrelson
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id2d46f1d94146b9b53de7baf6dfeca882fe85c65
    Gerrit-Change-Number: 7217648
    Gerrit-PatchSet: 3
    Gerrit-Owner: Robert Flack <fla...@chromium.org>
    Gerrit-Reviewer: Chris Harrelson <chri...@chromium.org>
    Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
    Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
    Gerrit-Attention: Chris Harrelson <chri...@chromium.org>
    Gerrit-Comment-Date: Wed, 03 Dec 2025 21:18:17 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Robert Flack (Gerrit)

    unread,
    Dec 3, 2025, 4:18:36 PM (6 days ago) Dec 3
    to Chris Harrelson, Vladimir Levin, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, apavlo...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
    Attention needed from Chris Harrelson

    Robert Flack added 1 comment

    File third_party/blink/renderer/core/dom/layout_tree_builder_traversal.cc
    Line 385, Patchset 2: for (auto iter = overscroll_areas->GetNames().rbegin();
    Vladimir Levin . resolved

    there's base::Reversed that you can use here (the clangtidy review seems valid)

    Robert Flack

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Chris Harrelson
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Id2d46f1d94146b9b53de7baf6dfeca882fe85c65
      Gerrit-Change-Number: 7217648
      Gerrit-PatchSet: 3
      Gerrit-Owner: Robert Flack <fla...@chromium.org>
      Gerrit-Reviewer: Chris Harrelson <chri...@chromium.org>
      Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
      Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
      Gerrit-Attention: Chris Harrelson <chri...@chromium.org>
      Gerrit-Comment-Date: Wed, 03 Dec 2025 21:18:28 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Vladimir Levin <vmp...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Robert Flack (Gerrit)

      unread,
      Dec 3, 2025, 5:16:24 PM (6 days ago) Dec 3
      to Chris Harrelson, Vladimir Levin, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, apavlo...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
      Attention needed from Chris Harrelson

      Robert Flack voted Commit-Queue+1

      Commit-Queue+1
      Gerrit-Comment-Date: Wed, 03 Dec 2025 22:16:08 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Robert Flack (Gerrit)

      unread,
      Dec 5, 2025, 9:30:56 AM (5 days ago) Dec 5
      to Chris Harrelson, Vladimir Levin, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, apavlo...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
      Attention needed from Chris Harrelson

      Robert Flack added 1 comment

      Patchset-level comments
      File-level comment, Patchset 3 (Latest):
      Robert Flack . unresolved

      Hey Chris, just need your review on third_party/blink/public/devtools_protocol/domains/DOM.pdl

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Chris Harrelson
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Id2d46f1d94146b9b53de7baf6dfeca882fe85c65
        Gerrit-Change-Number: 7217648
        Gerrit-PatchSet: 3
        Gerrit-Owner: Robert Flack <fla...@chromium.org>
        Gerrit-Reviewer: Chris Harrelson <chri...@chromium.org>
        Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
        Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
        Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
        Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
        Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
        Gerrit-CC: Menard, Alexis <alexis...@intel.com>
        Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
        Gerrit-Attention: Chris Harrelson <chri...@chromium.org>
        Gerrit-Comment-Date: Fri, 05 Dec 2025 14:30:40 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Chris Harrelson (Gerrit)

        unread,
        Dec 5, 2025, 5:53:33 PM (4 days ago) Dec 5
        to Robert Flack, Vladimir Levin, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, apavlo...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
        Attention needed from Robert Flack

        Chris Harrelson voted Code-Review+1

        Code-Review+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Robert Flack
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Id2d46f1d94146b9b53de7baf6dfeca882fe85c65
        Gerrit-Change-Number: 7217648
        Gerrit-PatchSet: 3
        Gerrit-Owner: Robert Flack <fla...@chromium.org>
        Gerrit-Reviewer: Chris Harrelson <chri...@chromium.org>
        Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
        Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
        Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
        Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
        Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
        Gerrit-CC: Menard, Alexis <alexis...@intel.com>
        Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
        Gerrit-Attention: Robert Flack <fla...@chromium.org>
        Gerrit-Comment-Date: Fri, 05 Dec 2025 22:53:21 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Robert Flack (Gerrit)

        unread,
        Dec 8, 2025, 10:24:02 AM (yesterday) Dec 8
        to Chris Harrelson, Vladimir Levin, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, apavlo...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

        Robert Flack voted Commit-Queue+2

        Commit-Queue+2
        Open in Gerrit

        Related details

        Attention set is empty
        Gerrit-Comment-Date: Mon, 08 Dec 2025 15:23:50 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Robert Flack (Gerrit)

        unread,
        Dec 8, 2025, 10:27:40 AM (yesterday) Dec 8
        to Chris Harrelson, Vladimir Levin, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, apavlo...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

        Robert Flack voted and added 1 comment

        Votes added by Robert Flack

        Commit-Queue+2

        1 comment

        Patchset-level comments
        Robert Flack . resolved

        Hey Chris, just need your review on third_party/blink/public/devtools_protocol/domains/DOM.pdl

        Robert Flack

        Acknowledged

        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: Id2d46f1d94146b9b53de7baf6dfeca882fe85c65
          Gerrit-Change-Number: 7217648
          Gerrit-PatchSet: 3
          Gerrit-Owner: Robert Flack <fla...@chromium.org>
          Gerrit-Reviewer: Chris Harrelson <chri...@chromium.org>
          Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
          Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
          Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
          Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
          Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
          Gerrit-CC: Menard, Alexis <alexis...@intel.com>
          Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
          Gerrit-Comment-Date: Mon, 08 Dec 2025 15:27:26 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: Yes
          Comment-In-Reply-To: Robert Flack <fla...@chromium.org>
          satisfied_requirement
          open
          diffy

          Chromium LUCI CQ (Gerrit)

          unread,
          Dec 8, 2025, 11:40:55 AM (yesterday) Dec 8
          to Robert Flack, Chris Harrelson, Vladimir Levin, Akihiro Ota, Menard, Alexis, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, apavlo...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

          Chromium LUCI CQ submitted the change

          Change information

          Commit message:
          [gestures] Make ::overscroll-area-parent siblings to scrolled content.

          Remove overscroll-client-area and add area parents as regular children.
          This will allow the regular content to continue to lay out correctly.
          Future patches will chain scrolling from the element to the
          overscroll area parents.
          Bug: 457468300
          Change-Id: Id2d46f1d94146b9b53de7baf6dfeca882fe85c65
          Reviewed-by: Chris Harrelson <chri...@chromium.org>
          Reviewed-by: Vladimir Levin <vmp...@chromium.org>
          Commit-Queue: Robert Flack <fla...@chromium.org>
          Cr-Commit-Position: refs/heads/main@{#1555504}
          Files:
          • M third_party/blink/public/devtools_protocol/domains/DOM.pdl
          • M third_party/blink/renderer/core/css/css_default_style_sheets.cc
          • M third_party/blink/renderer/core/css/css_selector.cc
          • M third_party/blink/renderer/core/css/css_selector.h
          • M third_party/blink/renderer/core/css/css_test_helpers.cc
          • M third_party/blink/renderer/core/css/invalidation/rule_invalidation_data_visitor.cc
          • M third_party/blink/renderer/core/css/overscroll.css
          • M third_party/blink/renderer/core/css/resolver/style_resolver.cc
          • M third_party/blink/renderer/core/css/rule_set.cc
          • M third_party/blink/renderer/core/css/selector_checker.cc
          • M third_party/blink/renderer/core/dom/document.cc
          • M third_party/blink/renderer/core/dom/element.cc
          • M third_party/blink/renderer/core/dom/element.h
          • M third_party/blink/renderer/core/dom/element_test.cc
          • M third_party/blink/renderer/core/dom/layout_tree_builder_traversal.cc
          • M third_party/blink/renderer/core/dom/overscroll_pseudo_element_data.h
          • M third_party/blink/renderer/core/dom/pseudo_element.cc
          • M third_party/blink/renderer/core/dom/pseudo_element_data.h
          • M third_party/blink/renderer/core/inspector/inspector_dom_agent.cc
          • M third_party/blink/renderer/core/style/computed_style.h
          • M third_party/blink/renderer/core/style/computed_style_constants.h
          • M third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
          Change size: L
          Delta: 22 files changed, 89 insertions(+), 189 deletions(-)
          Branch: refs/heads/main
          Submit Requirements:
          • requirement satisfiedCode-Review: +1 by Vladimir Levin, +1 by Chris Harrelson
          Open in Gerrit
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: merged
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: Id2d46f1d94146b9b53de7baf6dfeca882fe85c65
          Gerrit-Change-Number: 7217648
          Gerrit-PatchSet: 4
          Gerrit-Owner: Robert Flack <fla...@chromium.org>
          Gerrit-Reviewer: Chris Harrelson <chri...@chromium.org>
          Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
          Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
          Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
          Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
          Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
          open
          diffy
          satisfied_requirement
          Reply all
          Reply to author
          Forward
          0 new messages