[Masonry] Implement auto repeat with intrinsic minmax() [chromium/src : main]

0 views
Skip to first unread message

Alison Maher (Gerrit)

unread,
Feb 6, 2026, 5:46:32 PM (7 days ago) Feb 6
to Ian Kilpatrick, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Ian Kilpatrick

Alison Maher voted Commit-Queue+0

Commit-Queue+0
Open in Gerrit

Related details

Attention is currently required from:
  • Ian Kilpatrick
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I03a183771844a27c84db4940d730fbc1d1d9cc7c
Gerrit-Change-Number: 7553190
Gerrit-PatchSet: 1
Gerrit-Owner: Alison Maher <alm...@microsoft.com>
Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Comment-Date: Fri, 06 Feb 2026 22:46:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

一丝 (Gerrit)

unread,
Feb 9, 2026, 10:41:08 PM (3 days ago) Feb 9
to Alison Maher, Ian Kilpatrick, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Alison Maher and Ian Kilpatrick

一丝 added 1 comment

File third_party/blink/web_tests/external/wpt/css/css-grid/grid-lanes/tentative/track-sizing/auto-repeat/intrinsic-auto-repeat/column-auto-repeat-minmax-001.html
Line 44, Patchset 1 (Latest):</html>
一丝 . unresolved

To maintain a consistent style, it seems possible to remove `body` and `html`.

Open in Gerrit

Related details

Attention is currently required from:
  • Alison Maher
  • Ian Kilpatrick
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I03a183771844a27c84db4940d730fbc1d1d9cc7c
    Gerrit-Change-Number: 7553190
    Gerrit-PatchSet: 1
    Gerrit-Owner: Alison Maher <alm...@microsoft.com>
    Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-CC: 一丝 <yio...@gmail.com>
    Gerrit-Attention: Alison Maher <alm...@microsoft.com>
    Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Comment-Date: Tue, 10 Feb 2026 03:40:41 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Alison Maher (Gerrit)

    unread,
    Feb 10, 2026, 12:08:50 PM (3 days ago) Feb 10
    to 一丝, Ian Kilpatrick, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
    Attention needed from Ian Kilpatrick and 一丝

    Alison Maher added 1 comment

    File third_party/blink/web_tests/external/wpt/css/css-grid/grid-lanes/tentative/track-sizing/auto-repeat/intrinsic-auto-repeat/column-auto-repeat-minmax-001.html
    一丝 . resolved

    To maintain a consistent style, it seems possible to remove `body` and `html`.

    Alison Maher

    Yeah those shouldn't be needed, but these were based on other tests in the suite that had these, so keeping for consistency, but it's a good point that it might be worth following up on these to remove it across the board.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ian Kilpatrick
    • 一丝
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I03a183771844a27c84db4940d730fbc1d1d9cc7c
      Gerrit-Change-Number: 7553190
      Gerrit-PatchSet: 1
      Gerrit-Owner: Alison Maher <alm...@microsoft.com>
      Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
      Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
      Gerrit-CC: 一丝 <yio...@gmail.com>
      Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
      Gerrit-Attention: 一丝 <yio...@gmail.com>
      Gerrit-Comment-Date: Tue, 10 Feb 2026 17:08:41 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: 一丝 <yio...@gmail.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Ian Kilpatrick (Gerrit)

      unread,
      Feb 10, 2026, 1:50:29 PM (3 days ago) Feb 10
      to Alison Maher, 一丝, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
      Attention needed from Alison Maher and 一丝

      Ian Kilpatrick voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Alison Maher
      • 一丝
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I03a183771844a27c84db4940d730fbc1d1d9cc7c
        Gerrit-Change-Number: 7553190
        Gerrit-PatchSet: 1
        Gerrit-Owner: Alison Maher <alm...@microsoft.com>
        Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
        Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
        Gerrit-CC: 一丝 <yio...@gmail.com>
        Gerrit-Attention: Alison Maher <alm...@microsoft.com>
        Gerrit-Attention: 一丝 <yio...@gmail.com>
        Gerrit-Comment-Date: Tue, 10 Feb 2026 18:50:20 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Blink W3C Test Autoroller (Gerrit)

        unread,
        Feb 10, 2026, 1:52:13 PM (3 days ago) Feb 10
        to Alison Maher, Ian Kilpatrick, 一丝, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
        Attention needed from Alison Maher and 一丝

        Message from Blink W3C Test Autoroller

        Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/57687.

        When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

        WPT Export docs:
        https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Alison Maher
        • 一丝
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I03a183771844a27c84db4940d730fbc1d1d9cc7c
        Gerrit-Change-Number: 7553190
        Gerrit-PatchSet: 1
        Gerrit-Owner: Alison Maher <alm...@microsoft.com>
        Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
        Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
        Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
        Gerrit-CC: 一丝 <yio...@gmail.com>
        Gerrit-Attention: Alison Maher <alm...@microsoft.com>
        Gerrit-Attention: 一丝 <yio...@gmail.com>
        Gerrit-Comment-Date: Tue, 10 Feb 2026 18:52:06 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: No
        satisfied_requirement
        open
        diffy

        Alison Maher (Gerrit)

        unread,
        Feb 10, 2026, 2:17:34 PM (3 days ago) Feb 10
        to Blink W3C Test Autoroller, Ian Kilpatrick, 一丝, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
        Attention needed from 一丝

        Alison Maher voted Commit-Queue+2

        Commit-Queue+2
        Open in Gerrit

        Related details

        Attention is currently required from:
        • 一丝
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I03a183771844a27c84db4940d730fbc1d1d9cc7c
        Gerrit-Change-Number: 7553190
        Gerrit-PatchSet: 1
        Gerrit-Owner: Alison Maher <alm...@microsoft.com>
        Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
        Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
        Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
        Gerrit-CC: 一丝 <yio...@gmail.com>
        Gerrit-Attention: 一丝 <yio...@gmail.com>
        Gerrit-Comment-Date: Tue, 10 Feb 2026 19:17:22 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Chromium LUCI CQ (Gerrit)

        unread,
        Feb 10, 2026, 4:25:32 PM (3 days ago) Feb 10
        to Alison Maher, Blink W3C Test Autoroller, Ian Kilpatrick, 一丝, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

        Chromium LUCI CQ submitted the change

        Change information

        Commit message:
        [Masonry] Implement auto repeat with intrinsic minmax()

        In grid-lanes, we support intrinsic auto repeats. This means we need to
        support auto repeats with minmax() and intrinsic values for both the min
        and max breadth.

        For example, repeat(auto-fill, minmax(auto, auto).

        This change adds support for this addition by updating what tracks we
        consider to be intrinsic in GridTrackSize. The rest of the intrinsic
        auto repeat just ends up working as expected.
        Bug: 465744009, 343257585
        Change-Id: I03a183771844a27c84db4940d730fbc1d1d9cc7c
        Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>
        Commit-Queue: Alison Maher <alm...@microsoft.com>
        Cr-Commit-Position: refs/heads/main@{#1582775}
        Files:
        • M third_party/blink/renderer/core/style/grid_track_size.h
        • A third_party/blink/web_tests/external/wpt/css/css-grid/grid-lanes/tentative/track-sizing/auto-repeat/intrinsic-auto-repeat/column-auto-repeat-minmax-001.html
        • A third_party/blink/web_tests/external/wpt/css/css-grid/grid-lanes/tentative/track-sizing/auto-repeat/intrinsic-auto-repeat/column-auto-repeat-minmax-002.html
        • A third_party/blink/web_tests/external/wpt/css/css-grid/grid-lanes/tentative/track-sizing/auto-repeat/intrinsic-auto-repeat/column-auto-repeat-minmax-003.html
        • A third_party/blink/web_tests/external/wpt/css/css-grid/grid-lanes/tentative/track-sizing/auto-repeat/intrinsic-auto-repeat/column-auto-repeat-minmax-004.html
        • A third_party/blink/web_tests/external/wpt/css/css-grid/grid-lanes/tentative/track-sizing/auto-repeat/intrinsic-auto-repeat/column-auto-repeat-minmax-005.html
        • A third_party/blink/web_tests/external/wpt/css/css-grid/grid-lanes/tentative/track-sizing/auto-repeat/intrinsic-auto-repeat/row-auto-repeat-minmax-001.html
        • A third_party/blink/web_tests/external/wpt/css/css-grid/grid-lanes/tentative/track-sizing/auto-repeat/intrinsic-auto-repeat/row-auto-repeat-minmax-002.html
        • A third_party/blink/web_tests/external/wpt/css/css-grid/grid-lanes/tentative/track-sizing/auto-repeat/intrinsic-auto-repeat/row-auto-repeat-minmax-003.html
        • A third_party/blink/web_tests/external/wpt/css/css-grid/grid-lanes/tentative/track-sizing/auto-repeat/intrinsic-auto-repeat/row-auto-repeat-minmax-004.html
        • A third_party/blink/web_tests/external/wpt/css/css-grid/grid-lanes/tentative/track-sizing/auto-repeat/intrinsic-auto-repeat/row-auto-repeat-minmax-005.html
        Change size: L
        Delta: 11 files changed, 420 insertions(+), 6 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Ian Kilpatrick
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I03a183771844a27c84db4940d730fbc1d1d9cc7c
        Gerrit-Change-Number: 7553190
        Gerrit-PatchSet: 2
        Gerrit-Owner: Alison Maher <alm...@microsoft.com>
        Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
        Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
        Gerrit-CC: 一丝 <yio...@gmail.com>
        open
        diffy
        satisfied_requirement

        Blink W3C Test Autoroller (Gerrit)

        unread,
        Feb 10, 2026, 5:04:37 PM (3 days ago) Feb 10
        to Chromium LUCI CQ, Alison Maher, Ian Kilpatrick, 一丝, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

        Message from Blink W3C Test Autoroller

        The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/57687

        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I03a183771844a27c84db4940d730fbc1d1d9cc7c
        Gerrit-Change-Number: 7553190
        Gerrit-PatchSet: 2
        Gerrit-Owner: Alison Maher <alm...@microsoft.com>
        Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
        Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
        Gerrit-CC: 一丝 <yio...@gmail.com>
        Gerrit-Comment-Date: Tue, 10 Feb 2026 22:04:33 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: No
        satisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages