Scoped VT: Add contain: size and contain-intrinsic-size: auto [chromium/src : main]
1 view
Skip to first unread message
Kevin Ellis (Gerrit)
Jul 20, 2026, 1:09:03 PM (8 days ago) Jul 20
to Vladimir Levin, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
Attention needed from Vladimir Levin
Kevin Ellis added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Kevin Ellis . resolved
Change breaks 3 scope-containment tests. Will hold off on review until this failures are addressed.
Related details
Attention is currently required from:
- Vladimir Levin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vladimir Levin (Gerrit)
Jul 22, 2026, 1:45:19 PM (6 days ago) Jul 22
to android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Kevin Ellis, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
Vladimir Levin added 1 comment![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vladimir Levin (Gerrit)
Jul 22, 2026, 1:45:40 PM (6 days ago) Jul 22
to android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Kevin Ellis, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
Attention needed from Kevin Ellis
Vladimir Levin added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Kevin Ellis . resolved
Change breaks 3 scope-containment tests. Will hold off on review until this failures are addressed.
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kevin Ellis (Gerrit)
Jul 23, 2026, 8:50:30 AM (6 days ago) Jul 23
to Vladimir Levin, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
Attention needed from Vladimir Levin
Kevin Ellis voted and added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Vladimir Levin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Jul 23, 2026, 9:04:06 AM (5 days ago) Jul 23
to Vladimir Levin, Kevin Ellis, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
Attention needed from Vladimir Levin
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/61499.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention is currently required from:
- Vladimir Levin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vladimir Levin (Gerrit)
Jul 23, 2026, 9:50:11 AM (5 days ago) Jul 23
to Blink W3C Test Autoroller, Kevin Ellis, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
Vladimir Levin voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 23, 2026, 11:26:15 AM (5 days ago) Jul 23
to Vladimir Levin, Blink W3C Test Autoroller, Kevin Ellis, android-bu...@system.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Scoped VT: Add contain: size and contain-intrinsic-size: auto
Based on the resolution (see referenced bug), this adds a flag-guarded
contain: size and contain-intrinsic-size: auto. The latter is introduced
via a EffectiveContainIntrinsicSize computed style function.
R=kev...@chromium.org
Bug: 535198786
Change-Id: I4e252fe966e0fa89350175600307fe9b749ddc00
Commit-Queue: Vladimir Levin <vmp...@chromium.org>
Reviewed-by: Kevin Ellis <kev...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1667123}
Files:
- M third_party/blink/renderer/core/css/resolver/style_adjuster.cc
- M third_party/blink/renderer/core/dom/element.cc
- M third_party/blink/renderer/core/layout/layout_box.cc
- M third_party/blink/renderer/core/style/computed_style.h
- M third_party/blink/renderer/core/style/computed_style_extra_fields.json5
- M third_party/blink/renderer/core/view_transition/view_transition.cc
- M third_party/blink/renderer/core/view_transition/view_transition.h
- M third_party/blink/renderer/platform/runtime_enabled_features.json5
- A third_party/blink/web_tests/external/wpt/css/css-view-transitions/scoped/scope-containment-during-capture.html
- A third_party/blink/web_tests/external/wpt/css/css-view-transitions/scoped/scope-containment-pseudo-border-ref.html
- A third_party/blink/web_tests/external/wpt/css/css-view-transitions/scoped/scope-containment-pseudo-border.html
- A third_party/blink/web_tests/external/wpt/css/css-view-transitions/scoped/scope-containment-sibling-offset.html
Change size: L
Delta: 12 files changed, 381 insertions(+), 18 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kevin Ellis
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Jul 23, 2026, 12:15:42 PM (5 days ago) Jul 23
to Chromium LUCI CQ, Vladimir Levin, Kevin Ellis, android-bu...@system.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/61499
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages