[ruby-overhang] Support for parsing and serialization [chromium/src : main]

0 views
Skip to first unread message

Minseong Kim (Gerrit)

unread,
Sep 15, 2025, 7:41:37 PMSep 15
to Kent Tamura, Chromium LUCI CQ, AyeAye, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Kent Tamura

Minseong Kim added 1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Minseong Kim . resolved

Hi! Would you review this CL, please?

Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic9e87764312c2e48df41bbcf067f8ca81c7e264d
Gerrit-Change-Number: 6944447
Gerrit-PatchSet: 5
Gerrit-Owner: Minseong Kim <jja0...@gmail.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Minseong Kim <jja0...@gmail.com>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Kent Tamura <tk...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Sep 2025 23:41:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kent Tamura (Gerrit)

unread,
Sep 15, 2025, 8:59:29 PMSep 15
to Minseong Kim, Kent Tamura, Chromium LUCI CQ, AyeAye, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Minseong Kim

Kent Tamura added 1 comment

Patchset-level comments
Kent Tamura . resolved

This is a new feature, and we need to send an intent-to-implement or an intent-to-ship to blink-dev@ first.

https://www.chromium.org/blink/launching-features/

Open in Gerrit

Related details

Attention is currently required from:
  • Minseong Kim
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic9e87764312c2e48df41bbcf067f8ca81c7e264d
Gerrit-Change-Number: 6944447
Gerrit-PatchSet: 5
Gerrit-Owner: Minseong Kim <jja0...@gmail.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Minseong Kim <jja0...@gmail.com>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Minseong Kim <jja0...@gmail.com>
Gerrit-Comment-Date: Tue, 16 Sep 2025 00:59:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Minseong Kim (Gerrit)

unread,
Sep 18, 2025, 8:12:36 PM (12 days ago) Sep 18
to Kent Tamura, Chromium LUCI CQ, AyeAye, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

Minseong Kim added 1 comment

Patchset-level comments
Kent Tamura . unresolved

This is a new feature, and we need to send an intent-to-implement or an intent-to-ship to blink-dev@ first.

https://www.chromium.org/blink/launching-features/

Minseong Kim

Okay. I sent https://groups.google.com/a/chromium.org/g/blink-dev/c/cDjEhUgDiW8 and I'm waiting for LGTMs. Thanks for your help!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic9e87764312c2e48df41bbcf067f8ca81c7e264d
    Gerrit-Change-Number: 6944447
    Gerrit-PatchSet: 5
    Gerrit-Owner: Minseong Kim <jja0...@gmail.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Minseong Kim <jja0...@gmail.com>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Comment-Date: Fri, 19 Sep 2025 00:12:10 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Kent Tamura <tk...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Kent Tamura (Gerrit)

    unread,
    Sep 18, 2025, 8:19:26 PM (12 days ago) Sep 18
    to Minseong Kim, Kent Tamura, Chromium LUCI CQ, AyeAye, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
    Attention needed from Minseong Kim

    Kent Tamura added 1 comment

    Patchset-level comments
    Kent Tamura . resolved

    This is a new feature, and we need to send an intent-to-implement or an intent-to-ship to blink-dev@ first.

    https://www.chromium.org/blink/launching-features/

    Minseong Kim

    Okay. I sent https://groups.google.com/a/chromium.org/g/blink-dev/c/cDjEhUgDiW8 and I'm waiting for LGTMs. Thanks for your help!

    Kent Tamura

    I2P doesn't need LGTMs. So we can proceed this.
    Please rebase the CL.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Minseong Kim
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic9e87764312c2e48df41bbcf067f8ca81c7e264d
    Gerrit-Change-Number: 6944447
    Gerrit-PatchSet: 5
    Gerrit-Owner: Minseong Kim <jja0...@gmail.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Minseong Kim <jja0...@gmail.com>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Minseong Kim <jja0...@gmail.com>
    Gerrit-Comment-Date: Fri, 19 Sep 2025 00:18:54 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Minseong Kim <jja0...@gmail.com>
    Comment-In-Reply-To: Kent Tamura <tk...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Minseong Kim (Gerrit)

    unread,
    Sep 18, 2025, 8:37:06 PM (12 days ago) Sep 18
    to Kent Tamura, Chromium LUCI CQ, AyeAye, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
    Attention needed from Kent Tamura

    Minseong Kim added 1 comment

    Patchset-level comments
    Kent Tamura . resolved

    This is a new feature, and we need to send an intent-to-implement or an intent-to-ship to blink-dev@ first.

    https://www.chromium.org/blink/launching-features/

    Minseong Kim

    Okay. I sent https://groups.google.com/a/chromium.org/g/blink-dev/c/cDjEhUgDiW8 and I'm waiting for LGTMs. Thanks for your help!

    Kent Tamura

    I2P doesn't need LGTMs. So we can proceed this.
    Please rebase the CL.

    Minseong Kim

    Ah, I see. Thanks! I rebased the CL. Would you take a look, please?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Kent Tamura
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic9e87764312c2e48df41bbcf067f8ca81c7e264d
    Gerrit-Change-Number: 6944447
    Gerrit-PatchSet: 6
    Gerrit-Owner: Minseong Kim <jja0...@gmail.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Minseong Kim <jja0...@gmail.com>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Fri, 19 Sep 2025 00:36:42 +0000
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Kent Tamura (Gerrit)

    unread,
    Sep 18, 2025, 9:42:33 PM (12 days ago) Sep 18
    to Minseong Kim, Kent Tamura, Chromium LUCI CQ, AyeAye, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
    Attention needed from Minseong Kim

    Kent Tamura voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Minseong Kim
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic9e87764312c2e48df41bbcf067f8ca81c7e264d
    Gerrit-Change-Number: 6944447
    Gerrit-PatchSet: 6
    Gerrit-Owner: Minseong Kim <jja0...@gmail.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Minseong Kim <jja0...@gmail.com>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Minseong Kim <jja0...@gmail.com>
    Gerrit-Comment-Date: Fri, 19 Sep 2025 01:42:00 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Minseong Kim (Gerrit)

    unread,
    Sep 18, 2025, 9:48:04 PM (12 days ago) Sep 18
    to Koji Ishii, Kent Tamura, Chromium LUCI CQ, AyeAye, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
    Attention needed from Koji Ishii

    Minseong Kim added 1 comment

    Patchset-level comments
    File-level comment, Patchset 6 (Latest):
    Minseong Kim . resolved

    Hi, @ko...@chromium.org. Would you review this, please?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Koji Ishii
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic9e87764312c2e48df41bbcf067f8ca81c7e264d
    Gerrit-Change-Number: 6944447
    Gerrit-PatchSet: 6
    Gerrit-Owner: Minseong Kim <jja0...@gmail.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
    Gerrit-Reviewer: Minseong Kim <jja0...@gmail.com>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Koji Ishii <ko...@chromium.org>
    Gerrit-Comment-Date: Fri, 19 Sep 2025 01:47:31 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Koji Ishii (Gerrit)

    unread,
    Sep 22, 2025, 1:49:55 PM (8 days ago) Sep 22
    to Minseong Kim, Kent Tamura, Chromium LUCI CQ, AyeAye, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
    Attention needed from Minseong Kim

    Koji Ishii voted and added 1 comment

    Votes added by Koji Ishii

    Code-Review+1

    1 comment

    Patchset-level comments
    Koji Ishii . resolved

    lgtm

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Minseong Kim
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ic9e87764312c2e48df41bbcf067f8ca81c7e264d
      Gerrit-Change-Number: 6944447
      Gerrit-PatchSet: 6
      Gerrit-Owner: Minseong Kim <jja0...@gmail.com>
      Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
      Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
      Gerrit-Reviewer: Minseong Kim <jja0...@gmail.com>
      Gerrit-CC: Alexis Menard <alexis...@intel.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-Attention: Minseong Kim <jja0...@gmail.com>
      Gerrit-Comment-Date: Mon, 22 Sep 2025 17:49:21 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Minseong Kim (Gerrit)

      unread,
      Sep 22, 2025, 5:36:41 PM (8 days ago) Sep 22
      to Koji Ishii, Kent Tamura, Chromium LUCI CQ, AyeAye, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

      Minseong Kim voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ic9e87764312c2e48df41bbcf067f8ca81c7e264d
      Gerrit-Change-Number: 6944447
      Gerrit-PatchSet: 6
      Gerrit-Owner: Minseong Kim <jja0...@gmail.com>
      Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
      Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
      Gerrit-Reviewer: Minseong Kim <jja0...@gmail.com>
      Gerrit-CC: Alexis Menard <alexis...@intel.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-Comment-Date: Mon, 22 Sep 2025 21:36:06 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Minseong Kim (Gerrit)

      unread,
      Sep 22, 2025, 7:45:16 PM (8 days ago) Sep 22
      to Koji Ishii, Kent Tamura, Chromium LUCI CQ, AyeAye, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
      Gerrit-Comment-Date: Mon, 22 Sep 2025 23:44:44 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Sep 22, 2025, 7:49:18 PM (8 days ago) Sep 22
      to Minseong Kim, Koji Ishii, Kent Tamura, AyeAye, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      [ruby-overhang] Support for parsing and serialization

      The new behavior is behind a runtime flag, CSSRubyOverhang.

      Spec: https://drafts.csswg.org/css-ruby/#ruby-overhang
      Bug: 366873207
      Change-Id: Ic9e87764312c2e48df41bbcf067f8ca81c7e264d
      Reviewed-by: Kent Tamura <tk...@chromium.org>
      Reviewed-by: Koji Ishii <ko...@chromium.org>
      Commit-Queue: Minseong Kim <jja0...@gmail.com>
      Cr-Commit-Position: refs/heads/main@{#1519017}
      Files:
      • M third_party/blink/public/mojom/use_counter/metrics/css_property_id.mojom
      • M third_party/blink/renderer/core/css/css_properties.json5
      • M third_party/blink/renderer/core/css/css_property_equality.cc
      • M third_party/blink/renderer/core/css/parser/css_parser_fast_paths.cc
      • M third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc
      • M third_party/blink/renderer/platform/runtime_enabled_features.json5
      • M third_party/blink/web_tests/external/wpt/css/css-ruby/inheritance-expected.txt
      • D third_party/blink/web_tests/external/wpt/css/css-ruby/parsing/ruby-overhang-valid-expected.txt
      • M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-listing-expected.txt
      • M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
      • M third_party/blink/web_tests/svg/css/getComputedStyle-listing-expected.txt
      • M third_party/blink/web_tests/webexposed/css-properties-as-js-properties-expected.txt
      • M third_party/blink/web_tests/webexposed/css-property-listing-expected.txt
      • M tools/metrics/histograms/metadata/blink/enums.xml
      Change size: S
      Delta: 14 files changed, 35 insertions(+), 11 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Kent Tamura, +1 by Koji Ishii
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ic9e87764312c2e48df41bbcf067f8ca81c7e264d
      Gerrit-Change-Number: 6944447
      Gerrit-PatchSet: 7
      Gerrit-Owner: Minseong Kim <jja0...@gmail.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
      Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
      Gerrit-Reviewer: Minseong Kim <jja0...@gmail.com>
      Gerrit-CC: Alexis Menard <alexis...@intel.com>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages