[pseudo&] Support matching of pseudo-elements in logical combinations [chromium/src : main]
0 views
Skip to first unread message
Anders Hartvoll Ruud (Gerrit)
Sep 15, 2025, 9:58:07 AMSep 15
to Daniil Sakhapov, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Daniil Sakhapov
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Daniil Sakhapov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniil Sakhapov (Gerrit)
Sep 16, 2025, 7:28:40 AMSep 16
to Anders Hartvoll Ruud, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Anders Hartvoll Ruud
Daniil Sakhapov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Daniil Sakhapov
| Code-Review | +1 |
1 comment
File third_party/blink/renderer/core/css/selector_checker.cc
Line 1435, Patchset 2 (Latest):
if (!RuntimeEnabledFeatures::CSSLogicalCombinationPseudoEnabled()) {Daniil Sakhapov . unresolved
drop a line here and below on why we need to keep pseudo_id?
Related details
Attention is currently required from:
- Anders Hartvoll Ruud
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anders Hartvoll Ruud (Gerrit)
Sep 16, 2025, 1:33:03 PMSep 16
to Daniil Sakhapov, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Anders Hartvoll Ruud voted and added 1 comment![]( "Open in Gerrit")
Votes added by Anders Hartvoll Ruud
| Commit-Queue | +2 |
1 comment
File third_party/blink/renderer/core/css/selector_checker.cc
Line 1435, Patchset 2:
if (!RuntimeEnabledFeatures::CSSLogicalCombinationPseudoEnabled()) {Daniil Sakhapov . resolved
drop a line here and below on why we need to keep pseudo_id?
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 16, 2025, 4:05:45 PMSep 16
to Anders Hartvoll Ruud, Daniil Sakhapov, Alexis Menard, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: third_party/blink/renderer/core/css/selector_checker.cc
Insertions: 4, Deletions: 0.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[pseudo&] Support matching of pseudo-elements in logical combinations
CL:6947585 implemented support for matching against selectors
with implicit pseudo-child combinators (kPseudoChild), but deferred
support for logical combination pseudo-classes, which is done in
this CL instead.
Bug: 444386484
Change-Id: If88bc4443def0c03e7a2ca83dcc4b4b4fcba6407
Reviewed-by: Daniil Sakhapov <sakh...@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <and...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1516224}
Files:
- M third_party/blink/renderer/core/css/selector_checker.cc
- M third_party/blink/renderer/core/css/selector_checker_test.cc
Change size: M
Delta: 2 files changed, 49 insertions(+), 11 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Daniil Sakhapov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages