FitText: Merge two properties into one [chromium/src : main]
0 views
Skip to first unread message
Kent Tamura (Gerrit)
Jan 19, 2026, 4:22:51 AM (4 days ago) Jan 19
to Kent Tamura, Koji Ishii, Chromium LUCI CQ, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
Attention needed from Koji Ishii
Kent Tamura voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kent Tamura
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Koji Ishii
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Koji Ishii (Gerrit)
Jan 19, 2026, 8:24:39 AM (4 days ago) Jan 19
to Kent Tamura, Chromium LUCI CQ, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
Attention needed from Kent Tamura
Koji Ishii voted and added 2 comments![]( "Open in Gerrit")
Votes added by Koji Ishii
| Code-Review | +1 |
2 comments
Patchset-level comments
Koji Ishii . resolved
lgtm w/a comment
File third_party/blink/renderer/core/css/properties/css_parsing_utils.cc
Line 9497, Patchset 4 (Latest):
// [ none | grow | shrink] && [ consistent | per-line | per-line-all]? &&
// <percentage>?Koji Ishii . unresolved
The [`&&` operator](https://drafts.csswg.org/css-values-4/#comb-all) is "in any order", so you'll need a loop, like the one in [`TextIndent::ParseSingleValue`](https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc?q=TextIndent::ParseSingleValue&ss=chromium).
Or, should the use of `&&` in the syntax be changed?
Related details
Attention is currently required from:
- Kent Tamura
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kent Tamura (Gerrit)
Jan 19, 2026, 7:03:03 PM (4 days ago) Jan 19
to Kent Tamura, Koji Ishii, Chromium LUCI CQ, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
Kent Tamura added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/css/properties/css_parsing_utils.cc
Line 9497, Patchset 4 (Latest):
// [ none | grow | shrink] && [ consistent | per-line | per-line-all]? &&
// <percentage>?Koji Ishii . resolved
The [`&&` operator](https://drafts.csswg.org/css-values-4/#comb-all) is "in any order", so you'll need a loop, like the one in [`TextIndent::ParseSingleValue`](https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc?q=TextIndent::ParseSingleValue&ss=chromium).
Or, should the use of `&&` in the syntax be changed?
Kent Tamura
Thank you for pointing it out.
I misunderstood `&&`. I want to start with a stricter syntax, and meant ordered components.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kent Tamura (Gerrit)
Jan 19, 2026, 10:03:23 PM (4 days ago) Jan 19
to Kent Tamura, Koji Ishii, Chromium LUCI CQ, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
Kent Tamura voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 19, 2026, 10:07:41 PM (4 days ago) Jan 19
to Kent Tamura, Koji Ishii, Menard, Alexis, Chromium Metrics Reviews, chromium...@chromium.org, apavlo...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: third_party/blink/renderer/core/css/properties/css_parsing_utils.cc
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
FitText: Merge two properties into one
This CL removes `text-grow` and `text-shrink` properties, and introduces
the `text-fit` property that covers both functionalities.
New Property Syntax:
text-fit: [ none | grow | shrink]
[ consistent | per-line | per-line-all]?
<percentage>?
This CL doesn't change the last component from <length> to <percentage>.
It will be addressed in a following CL.
* blink::ComputedStyle had two blink::FitText instances. Now it has
a single blink::FitText, and blink::FitText has a type field of
which value is kNone, kGrow, or kShrink.
* wpt_internal/css/fit-width-text/
text-shrink-valid.html, text-shrink-invalid.html, and text-shrink-computed.html tests are merged into text-grow-*.html.
We're going to rename tests in this directory later.
Bug: 417306102
Change-Id: Ie72590ea479ab84bf7b004823e6fbf849648274d
Commit-Queue: Kent Tamura <tk...@chromium.org>
Reviewed-by: Koji Ishii <ko...@chromium.org>
Auto-Submit: Kent Tamura <tk...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1571404}
Files:
- M third_party/blink/public/mojom/use_counter/metrics/css_property_id.mojom
- M third_party/blink/renderer/core/css/css_properties.json5
- M third_party/blink/renderer/core/css/css_property_equality.cc
- M third_party/blink/renderer/core/css/css_value_keywords.json5
- M third_party/blink/renderer/core/css/properties/computed_style_utils.cc
- M third_party/blink/renderer/core/css/properties/css_parsing_utils.cc
- M third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc
- M third_party/blink/renderer/core/css/resolver/style_builder_converter.cc
- M third_party/blink/renderer/core/layout/block_layout_algorithm.cc
- M third_party/blink/renderer/core/layout/inline/fit_text_utils.cc
- M third_party/blink/renderer/core/style/fit_text.cc
- M third_party/blink/renderer/core/style/fit_text.h
- M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-listing-expected.txt
- M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
- M third_party/blink/web_tests/svg/css/getComputedStyle-listing-expected.txt
- M third_party/blink/web_tests/webexposed/css-properties-as-js-properties-expected.txt
- M third_party/blink/web_tests/webexposed/css-property-listing-expected.txt
- M third_party/blink/web_tests/wpt_internal/css/fit-width-text/text-grow-computed.html
- M third_party/blink/web_tests/wpt_internal/css/fit-width-text/text-grow-consistent-ref.html
- M third_party/blink/web_tests/wpt_internal/css/fit-width-text/text-grow-consistent.html
- M third_party/blink/web_tests/wpt_internal/css/fit-width-text/text-grow-invalid.html
- M third_party/blink/web_tests/wpt_internal/css/fit-width-text/text-grow-per-line-font-size.html
- M third_party/blink/web_tests/wpt_internal/css/fit-width-text/text-grow-per-line-line-height.html
- M third_party/blink/web_tests/wpt_internal/css/fit-width-text/text-grow-valid.html
- D third_party/blink/web_tests/wpt_internal/css/fit-width-text/text-shrink-computed.html
- M third_party/blink/web_tests/wpt_internal/css/fit-width-text/text-shrink-consistent-ref.html
- M third_party/blink/web_tests/wpt_internal/css/fit-width-text/text-shrink-consistent.html
- D third_party/blink/web_tests/wpt_internal/css/fit-width-text/text-shrink-invalid.html
- M third_party/blink/web_tests/wpt_internal/css/fit-width-text/text-shrink-per-line-scale-minimum-setting.html
- M third_party/blink/web_tests/wpt_internal/css/fit-width-text/text-shrink-per-line-scale.html
- D third_party/blink/web_tests/wpt_internal/css/fit-width-text/text-shrink-valid.html
- M tools/metrics/histograms/metadata/blink/enums.xml
Change size: L
Delta: 32 files changed, 182 insertions(+), 334 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Koji Ishii
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages