Add kAuxiliaryReasonsForBackdropRoot, fix bugs for backdrop root [chromium/src : main]
0 views
Skip to first unread message
Wangsong Jin (Gerrit)
Jan 12, 2026, 5:20:16 PM (11 days ago) Jan 12
to Claire Chambers, Olga Gerchikov, AyeAye, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, Chromium LUCI CQ, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Attention needed from Claire Chambers and Olga Gerchikov
Wangsong Jin added 3 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Wangsong Jin . unresolved
Do we have test coverage for will-change:clip-path without backdrop filter won't create a backdrop root?
File third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
Line 1739, Patchset 1 (Latest):
if (object_.HasLayer()) {Wangsong Jin . unresolved
Do we still need a feature gate here?
Line 1754, Patchset 1 (Latest):
if (RuntimeEnabledFeatures::
BackdropRootForClipPathWithBackdropFilterEnabled() &&
properties_ && properties_->ClipPathClip() && object_.HasLayer()) {
}Wangsong Jin . unresolved
This if block is now empty.
Related details
Attention is currently required from:
- Claire Chambers
- Olga Gerchikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Claire Chambers (Gerrit)
Jan 13, 2026, 1:03:46 PM (10 days ago) Jan 13
to Olga Gerchikov, Wangsong Jin, AyeAye, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, Chromium LUCI CQ, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Attention needed from Olga Gerchikov and Wangsong Jin
Claire Chambers added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Wangsong Jin . resolved
Do we have test coverage for will-change:clip-path without backdrop filter won't create a backdrop root?
Claire Chambers
This is impossible to check with a web test as the only way to visually determine whether a backdrop root exists is by putting a backdrop filter over it. Anything else would be a bug.
Related details
Attention is currently required from:
- Olga Gerchikov
- Wangsong Jin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Wangsong Jin (Gerrit)
Jan 13, 2026, 5:52:03 PM (10 days ago) Jan 13
to Claire Chambers, Olga Gerchikov, AyeAye, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, Chromium LUCI CQ, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Attention needed from Claire Chambers and Olga Gerchikov
Wangsong Jin added 2 comments![]( "Open in Gerrit")
File third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
Line 1739, Patchset 1 (Latest):
if (object_.HasLayer()) {Wangsong Jin . resolved
Wangsong JinDo we still need a feature gate here?
Just a reminder: if `BackdropRootForClipPathWithBackdropFilterEnabled` is no longer needed, please remove it from runtime_enabled_features.json5.
Related details
Attention is currently required from:
- Claire Chambers
- Olga Gerchikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Claire Chambers (Gerrit)
Jan 15, 2026, 1:23:30 AM (8 days ago) Jan 15
to Olga Gerchikov, Wangsong Jin, AyeAye, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, Chromium LUCI CQ, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Attention needed from Olga Gerchikov and Wangsong Jin
Claire Chambers added 2 comments![]( "Open in Gerrit")
File third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
Line 1754, Patchset 1:
if (RuntimeEnabledFeatures::
BackdropRootForClipPathWithBackdropFilterEnabled() &&
properties_ && properties_->ClipPathClip() && object_.HasLayer()) {
}Wangsong Jin . resolved
This if block is now empty.
Attention is currently required from:
- Olga Gerchikov
- Wangsong Jin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Wangsong Jin (Gerrit)
Jan 15, 2026, 12:35:07 PM (8 days ago) Jan 15
to Claire Chambers, Olga Gerchikov, AyeAye, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, Chromium LUCI CQ, jmedle...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Attention needed from Claire Chambers and Olga Gerchikov
Wangsong Jin added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Claire Chambers
- Olga Gerchikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages