Auto value of text-emphasis-position in Chinese [chromium/src : main]
0 views
Skip to first unread message
Felipe Erias (Gerrit)
12:12 AM (13 hours ago) 12:12 AM
to Kent Tamura, Koji Ishii, Steinar H Gunderson, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Kent Tamura, Koji Ishii and Steinar H Gunderson
Felipe Erias added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Felipe Erias . resolved
Hello,
This CL fixes a small issue with the position of the emphasis mark in Chinese text.
Thank you for your feedback.
Best,
Felipe
Related details
Attention is currently required from:
- Kent Tamura
- Koji Ishii
- Steinar H Gunderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kent Tamura (Gerrit)
12:45 AM (12 hours ago) 12:45 AM
to Felipe Erias, Kent Tamura, Koji Ishii, Steinar H Gunderson, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Felipe Erias, Koji Ishii and Steinar H Gunderson
Kent Tamura voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Felipe Erias
- Koji Ishii
- Steinar H Gunderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Koji Ishii (Gerrit)
1:35 AM (11 hours ago) 1:35 AM
to Felipe Erias, Kent Tamura, Steinar H Gunderson, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Felipe Erias and Steinar H Gunderson
Koji Ishii voted and added 1 comment![]( "Open in Gerrit")
Votes added by Koji Ishii
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Felipe Erias
- Steinar H Gunderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Felipe Erias (Gerrit)
5:13 AM (8 hours ago) 5:13 AM
to Koji Ishii, Kent Tamura, Steinar H Gunderson, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Steinar H Gunderson
Felipe Erias voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Steinar H Gunderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
5:58 AM (7 hours ago) 5:58 AM
to Felipe Erias, Koji Ishii, Kent Tamura, Steinar H Gunderson, AyeAye, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Auto value of text-emphasis-position in Chinese
For the Chinese language, the CSS Text Decoration spec recommends that
emphasis marks appear below the text.
This change uses IsMacrolanguageChinese() when resolving the 'auto'
value for text-emphasis-position to determine the correct position.
https://drafts.csswg.org/css-text-decor/#text-emphasis-position-property
Test: external/wpt/css/css-text-decor/text-emphasis-position-auto-002.html
Bug: 368657256
Change-Id: I6147d5251f219402371b90c935795f9d1ef174da
Reviewed-by: Koji Ishii <ko...@chromium.org>
Reviewed-by: Kent Tamura <tk...@chromium.org>
Commit-Queue: Felipe Erias <felip...@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1573589}
Files:
- M third_party/blink/renderer/core/style/computed_style.cc
- M third_party/blink/web_tests/TestExpectations
Change size: XS
Delta: 2 files changed, 7 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kent Tamura, +1 by Koji Ishii
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages