Short-circuit after-change style for @starting-style. [chromium/src : main]
0 views
Skip to first unread message
Rune Lillesveen (Gerrit)
Feb 2, 2026, 10:14:13 AM (11 days ago) Feb 2
to Steinar H Gunderson, Rune Lillesveen, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Steinar H Gunderson
Rune Lillesveen voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Steinar H Gunderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Steinar H Gunderson (Gerrit)
Feb 2, 2026, 10:48:12 AM (11 days ago) Feb 2
to Rune Lillesveen, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Steinar H Gunderson voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 2, 2026, 10:52:28 AM (11 days ago) Feb 2
to Steinar H Gunderson, Rune Lillesveen, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Short-circuit after-change style for @starting-style.
https://chromium-review.googlesource.com/c/chromium/src/+/6228640
added a test to reduce ancestry walking to find after-change style
for parents with no animated style, by adding a test to
CalculateAfterChangeStyle(). However, we also have a separate test
for @starting-style that calls EnsureAfterChangeStyleIfNecessary()
directly, without going through CalculateAfterChangeStyle().
Add the short-circuiting test there as well.
Change-Id: I41f1d2e18ffab893fac2fd80f2f49bacc7dfe197
Commit-Queue: Steinar H Gunderson <se...@chromium.org>
Reviewed-by: Rune Lillesveen <fut...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1578141}
Files:
- M third_party/blink/renderer/core/animation/css/css_animations.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Rune Lillesveen
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages