Short-circuit after-change style for @starting-style. [chromium/src : main]

0 views
Skip to first unread message

Rune Lillesveen (Gerrit)

unread,
Feb 2, 2026, 10:14:13 AM (11 days ago) Feb 2
to Steinar H Gunderson, Rune Lillesveen, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Steinar H Gunderson

Rune Lillesveen voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Steinar H Gunderson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I41f1d2e18ffab893fac2fd80f2f49bacc7dfe197
Gerrit-Change-Number: 7532010
Gerrit-PatchSet: 2
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
Gerrit-Reviewer: Steinar H Gunderson <se...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-Attention: Steinar H Gunderson <se...@chromium.org>
Gerrit-Comment-Date: Mon, 02 Feb 2026 15:13:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Steinar H Gunderson (Gerrit)

unread,
Feb 2, 2026, 10:48:12 AM (11 days ago) Feb 2
to Rune Lillesveen, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Steinar H Gunderson voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I41f1d2e18ffab893fac2fd80f2f49bacc7dfe197
Gerrit-Change-Number: 7532010
Gerrit-PatchSet: 2
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
Gerrit-Reviewer: Steinar H Gunderson <se...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-Comment-Date: Mon, 02 Feb 2026 15:47:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Feb 2, 2026, 10:52:28 AM (11 days ago) Feb 2
to Steinar H Gunderson, Rune Lillesveen, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Short-circuit after-change style for @starting-style.

https://chromium-review.googlesource.com/c/chromium/src/+/6228640
added a test to reduce ancestry walking to find after-change style
for parents with no animated style, by adding a test to
CalculateAfterChangeStyle(). However, we also have a separate test
for @starting-style that calls EnsureAfterChangeStyleIfNecessary()
directly, without going through CalculateAfterChangeStyle().
Add the short-circuiting test there as well.
Change-Id: I41f1d2e18ffab893fac2fd80f2f49bacc7dfe197
Commit-Queue: Steinar H Gunderson <se...@chromium.org>
Reviewed-by: Rune Lillesveen <fut...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1578141}
Files:
  • M third_party/blink/renderer/core/animation/css/css_animations.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Rune Lillesveen
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I41f1d2e18ffab893fac2fd80f2f49bacc7dfe197
Gerrit-Change-Number: 7532010
Gerrit-PatchSet: 3
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
Gerrit-Reviewer: Steinar H Gunderson <se...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages